aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/test/channel
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-026-6/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-016-0/+6
|
* Fix a race in ActionCable stream testsMatthew Draper2017-03-231-0/+4
| | | | | These tests double-stub connection.pubsub, so we need to ensure the first call's completed before we set up for the second.
* correctly check error messageyuuji.yaginuma2017-01-251-3/+6
| | | | | | | `assert_raise` does not check error message. However, in some tests, it seems like expecting error message checking with `assert_raise`. Instead of specifying an error message in `assert_raise`, modify to use another assert to check the error message.
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-1/+1
|
* Add Channel#ensure_confirmation_sent; call #subscribe_to_channel after ↵palkan2016-09-224-6/+15
| | | | initializing
* [Fix #25381] Avoid race condition on subscription confirmationpalkan2016-09-202-5/+33
|
* Prevent invocation of channel action if rejected connectionJon Moss2016-08-191-0/+15
| | | | | | | | | Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel.
* Add three new rubocop rulesRafael Mendonça França2016-08-161-3/+3
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* applies remaining conventions across the projectXavier Noria2016-08-061-1/+0
|
* remove redundant curlies from hash argumentsXavier Noria2016-08-064-5/+5
|
* applies new string literal convention in actioncable/testXavier Noria2016-08-066-62/+62
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Properly support reloading for Action Cable channelsMatthew Draper2016-06-021-4/+0
|
* Cable: Extract stream handler constructionJeremy Daer2016-04-181-0/+1
| | | | | | | | * Use separate stream handler builders for easy override and testing. * Fix worker pool execution that was silently failing since it only expected connection receivers. Sparked by code in #24162.
* Cable: Periodic timers refreshJeremy Daer2016-04-181-10/+38
| | | | | | | | | * Rewrite docs * Support blocks in addition to method names and Proc args * Check for valid arguments * Convert `periodically :method_name` to Proc callbacks * Drop periodic runner methods from the worker pool * Ensure we clear active periodic timers after shutdown
* Run Action Cable callbacks through the worker poolSean Griffin2016-04-131-3/+25
| | | | | | | | | | Alternate implementation of #24162 with tests. The code had diverged too far on master to pull that implemenation directly. Fixes #23778 Close #24162 [Mattew Draper & Sean Griffin]
* Cable message encodingJeremy Daer2016-03-313-48/+118
| | | | | | | | | | | | | | | | | | | * Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
* Keep logging in the ActionCable::Channel::BaseRafael Mendonça França2016-03-301-69/+0
| | | | | | To move Action Cable logging to a LoggingSubscriber we need to pass the log tags in the notification payload since Action Cable logging use the Channel instance to tag the logs.
* Add AS::Notifications and LogSubscriber to ActionCable::ChannelMatthew Wear2016-03-042-0/+144
| | | | | This commit adds ActiveSupport::Notifications instrumentation hooks and a LogSuscriber to ActionCable::Channel::Base.
* Support faye-websocket + EventMachine as an optionMatthew Draper2016-03-021-1/+1
|
* Convert stream broadcasting to a stringJay Hayes2016-02-241-0/+17
| | | | | | | ActionCable does some things behind the scenes that expects these "broadcasting"s or "channel"s to be strings. However it's not immediately obvious that the value must be a string. So adding this conversion ensures things work as expected.
* whitespaceJay Hayes2016-02-241-1/+0
|
* Revert "Revert "Eliminate the EventMachine dependency""Matthew Draper2016-01-302-15/+9
|
* Revert "Eliminate the EventMachine dependency"David Heinemeier Hansson2016-01-272-9/+15
|
* Using a hacked faye-websocket, drop EventMachineMatthew Draper2016-01-242-15/+9
|
* Fix code review commentsJon Moss2016-01-181-3/+3
| | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters
* All Redis deps are now optional, Postgres --> PostgreSQL adapterJon Moss2016-01-181-1/+0
|
* Tests passing and small refactoringJon Moss2016-01-181-4/+5
|
* [ActionCable] declare asset_logged privateAkshay Vishnoi2015-12-191-14/+14
|
* Merge pull request #22668 from ryohashimoto/151219_receiveKasper Timm Hansen2015-12-181-1/+1
|\ | | | | Fix `receive` spelling
| * Fix `receive` spellingRyo Hashimoto2015-12-191-1/+1
| |
* | Merge pull request #22667 from akshay-vishnoi/base_test_caseRafael França2015-12-181-0/+22
|\ \ | |/ |/| [ActionCable] Test invalid action on channel
| * [ActionCable] Test invalid action on channelAkshay Vishnoi2015-12-181-0/+22
| |
* | Fix `receive` spelling and add whitespaceKasper Timm Hansen2015-12-181-3/+3
|/ | | | | Found `recieve` next to the correctly spelled method name, fixed it. Also we prefer a one space padding within hashes, add that.
* [ActionCable] test perform action with default actionAkshay Vishnoi2015-12-181-1/+11
|
* [ActionCable] Test available actions on ChannelAkshay Vishnoi2015-12-181-0/+4
|
* Remove warnings from actioncableArun Agrawal2015-12-171-1/+1
| | | | Warnings coming from code and test are removed
* Get ready to merge into RailsDavid Heinemeier Hansson2015-12-146-0/+332
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 05:48:08 +0000