Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | In-line the configuration points that only existed for Faye support | Matthew Draper | 2016-10-01 | 4 | -12/+4 |
| | |||||
* | Remove Faye mode | Matthew Draper | 2016-10-01 | 4 | -105/+3 |
| | | | | No deprecation, because it was never documented. | ||||
* | Merge pull request #26547 from ↵ | Matthew Draper | 2016-10-01 | 3 | -18/+28 |
|\ | | | | | | | | | | | palkan/fix/actioncable-confirmation-race-condition Avoid race condition on subscription confirmation | ||||
| * | Add Channel#ensure_confirmation_sent; call #subscribe_to_channel after ↵ | palkan | 2016-09-22 | 3 | -27/+24 |
| | | | | | | | | initializing | ||||
| * | [Fix #25381] Avoid race condition on subscription confirmation | palkan | 2016-09-20 | 3 | -10/+23 |
| | | |||||
* | | Buffer writes to the cable sockets | Matthew Draper | 2016-09-28 | 2 | -11/+92 |
| | | | | | | | | | | Otherwise, they can sometimes block, leading to reduced system throughput. | ||||
* | | [ci skip] Fix formatting of documentation of worker_pool method from ↵ | Prathamesh Sonpatki | 2016-09-07 | 1 | -1/+1 |
| | | | | | | | | AC::Server::Base | ||||
* | | [ci skip] Fix formatting in Action Cable Connection::Base module docs | Prathamesh Sonpatki | 2016-09-07 | 1 | -1/+1 |
| | | |||||
* | | [ci fix] Fix API documentation for Streams module from Action Cable | Prathamesh Sonpatki | 2016-09-06 | 1 | -4/+4 |
|/ | |||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -1/+1 |
| | |||||
* | Prevent invocation of channel action if rejected connection | Jon Moss | 2016-08-19 | 1 | -1/+1 |
| | | | | | | | | | Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel. | ||||
* | copy-edits an exception message | Xavier Noria | 2016-08-07 | 1 | -1/+1 |
| | | | | | | | | | | | | | | Inserted spaces in the name of Rails components. Since I was on it, also used PostgreSQL instead of Postgres because albeit Postgres is an accepted alias, PostgreSQL is the official name and the actual name of the adapter. See https://wiki.postgresql.org/wiki/ProjectName with regard to PostgreSQL vs Postgres. | ||||
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 1 | -1/+0 |
| | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in actioncable/lib | Xavier Noria | 2016-08-06 | 28 | -90/+90 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Give importance to rails command in the comment section. | Santosh Wadghule | 2016-07-13 | 1 | -1/+1 |
| | |||||
* | Merge pull request #25624 from tinco/actioncable_write_race | Matthew Draper | 2016-07-09 | 1 | -2/+7 |
|\ | | | | | | | Fix race condition in websocket stream write | ||||
| * | fix race condition in websocket stream write | Tinco Andringa | 2016-07-01 | 1 | -0/+4 |
| | | |||||
* | | Merge pull request #24988 from mwear/action_cable_broadcast_notifications | Matthew Draper | 2016-07-04 | 1 | -2/+6 |
|\ \ | | | | | | | Add ActiveSupport::Notifications hook to ActionCable::Server.broadcast | ||||
| * | | Add ActiveSupport::Notifications hook to Broadcaster#broadcast | Matthew Wear | 2016-05-12 | 1 | -2/+6 |
| | | | | | | | | | | | | | | | This addition of this notification hook will give users better visibility into the messages being sent over the PubSub adapter. | ||||
* | | | Merge pull request #25030 from mmmpa/pull_request | Matthew Draper | 2016-07-04 | 1 | -1/+5 |
|\ \ \ | | | | | | | | | ActionCable, sometimes add_channel is not called. | ||||
| * | | | Add guard to broadcast. | mmmpa | 2016-05-26 | 1 | -1/+5 |
| | | | | |||||
* | | | | Merge pull request #25293 from y-yagi/remove_needless_comments | Matthew Draper | 2016-07-03 | 3 | -5/+0 |
|\ \ \ \ | | | | | | | | | | | remove needless comments | ||||
| * | | | | remove needless comments | yuuji.yaginuma | 2016-06-06 | 3 | -5/+0 |
| | | | | | | | | | | | | | | | | | | | | Follow up to #25240. | ||||
* | | | | | close hijacked i/o socket after use (fixes #25613) | Tinco Andringa | 2016-07-01 | 1 | -0/+1 |
| |_|_|/ |/| | | | |||||
* | | | | Periodic timers: delegate async instance_exec to the worker pool | Jeremy Daer | 2016-06-29 | 2 | -7/+9 |
| | | | | |||||
* | | | | Allow actioncable connections from any port in development | Michael Dever | 2016-06-16 | 1 | -1/+1 |
|/ / / | |||||
* | | | Properly support reloading for Action Cable channels | Matthew Draper | 2016-06-02 | 4 | -30/+9 |
| | | | |||||
* | | | fix grammar | Rajat Bansal | 2016-05-31 | 1 | -1/+1 |
|/ / | |||||
* | | Merge pull request #25076 from jeroenvisser101/keep-to-max-length | Sean Griffin | 2016-05-21 | 2 | -2/+4 |
|\ \ | | | | | | | Change comments to not exceed 80 characters | ||||
| * | | Change comments to not exceed 80 characters | Jeroen Visser | 2016-05-19 | 2 | -2/+4 |
| | | | | | | | | | | | | Other generated files do keep to this, but action cable doesn't. | ||||
* | | | Pass over Action Cable docs | Jon Moss | 2016-05-21 | 2 | -4/+4 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Merge pull request #24918 from prathamesh-sonpatki/cable-assets | Rafael França | 2016-05-21 | 2 | -1/+20 |
|\ \ \ | |/ / |/| | | Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application | ||||
| * | | Cable: Generate .js or .coffee files while generating channel as per the ↵ | Prathamesh Sonpatki | 2016-05-17 | 2 | -1/+20 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper] | ||||
* | | | Improve method description | Roman Pushkin | 2016-05-18 | 1 | -0/+1 |
|/ / | | | | | Method description improved to reflect little bit more complicated scenario when names are camel-cased. | ||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2016-05-14 | 1 | -2/+2 |
|\ \ | |/ |/| | | | | | Conflicts: guides/source/configuring.md | ||||
| * | Fix code formatting in docs | Jay Hayes | 2016-05-03 | 1 | -2/+2 |
| | | |||||
* | | Start Rails 5.1 development :tada: | Rafael Mendonça França | 2016-05-10 | 1 | -2/+2 |
| | | |||||
* | | Preparing for 5.0.0.rc1 release | Rafael Mendonça França | 2016-05-06 | 1 | -1/+1 |
| | | |||||
* | | renames ActionCable::Railtie to ActionCable::Engine | Xavier Noria | 2016-05-04 | 1 | -1/+1 |
|/ | | | | | | | | This is an engine living in action_cable/engine.rb, convention is to call these things *::Engine. Looking at thi git history looks like the current *::Railtie was just an accident. | ||||
* | Prep Rails 5 beta 4 | eileencodes | 2016-04-27 | 1 | -1/+1 |
| | |||||
* | Merge pull request #24669 from tomkadwill/action_pack_typos | Vipul A M | 2016-04-22 | 1 | -1/+1 |
|\ | | | | | Actioncable and Actionpack documentation typos [ci skip] | ||||
| * | Actioncable and Actionpack documentation typos [ci skip] | Tom Kadwill | 2016-04-21 | 1 | -1/+1 |
| | | |||||
* | | Log if redis connection is in stale/failed state. | Vipul A M | 2016-04-21 | 1 | -0/+4 |
|/ | |||||
* | Cable: Extract stream handler construction | Jeremy Daer | 2016-04-18 | 2 | -18/+62 |
| | | | | | | | | * Use separate stream handler builders for easy override and testing. * Fix worker pool execution that was silently failing since it only expected connection receivers. Sparked by code in #24162. | ||||
* | Cable: Periodic timers refresh | Jeremy Daer | 2016-04-18 | 2 | -19/+45 |
| | | | | | | | | | * Rewrite docs * Support blocks in addition to method names and Proc args * Check for valid arguments * Convert `periodically :method_name` to Proc callbacks * Drop periodic runner methods from the worker pool * Ensure we clear active periodic timers after shutdown | ||||
* | Merge pull request #24600 from tomkadwill/action-cabel-channel-typos | Vipul A M | 2016-04-18 | 3 | -4/+4 |
|\ | | | | | Fix typos in ActionCable Channel [ci skip] | ||||
| * | Fix typos in ActionCable Channel [ci skip] | Tom Kadwill | 2016-04-18 | 3 | -4/+4 |
| | | |||||
* | | don't remove `cable.js` | yuuji.yaginuma | 2016-04-16 | 1 | -1/+3 |
| | | | | | | | | `cable.js` is required for other Channels. |