Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #22639 from arunagw/aa-remove-few-warnings-actioncable | Guillermo Iguaran | 2015-12-17 | 5 | -4/+11 |
|\ | | | | | Remove warnings from actioncable test | ||||
| * | Remove warnings from actioncable | Arun Agrawal | 2015-12-17 | 5 | -4/+11 |
| | | | | | | | | Warnings coming from code and test are removed | ||||
* | | Should also stub the received callback | David Heinemeier Hansson | 2015-12-17 | 1 | -0/+3 |
| | | |||||
* | | Don't log Action Cable to STDOUT in development | eileencodes | 2015-12-17 | 2 | -10/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Logging Action Cable to STDOUT caused the development log to see double messages like this: ``` Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500 Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500 Processing by Rails::WelcomeController#index as HTML Processing by Rails::WelcomeController#index as HTML Rendered /welcome/index.html.erb (0.0ms) Rendered /welcome/index.html.erb (0.0ms) Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms) Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms) ``` Now that Action Cable is part of Rails it doesn't need it's own logger and will log to STDOUT via the local dev server here: https://github.com/rails/rails/blob/master/railties/lib/rails/commands/server.rb | ||||
* | | traditional make sense with `<tt>ActiveSupport::TaggedLogging</tt>` | Gaurav Sharma | 2015-12-18 | 1 | -2/+2 |
|/ | |||||
* | Update USAGE | Paul Montero | 2015-12-17 | 1 | -1/+1 |
| | | | Fix typo | ||||
* | Clarify | David Heinemeier Hansson | 2015-12-16 | 1 | -3/+3 |
| | |||||
* | Generate all the ApplicationCable stubs by default, like all other ↵ | David Heinemeier Hansson | 2015-12-16 | 4 | -41/+0 |
| | | | | Application* stubs | ||||
* | Comment out the user handling so default setup connects directly | David Heinemeier Hansson | 2015-12-16 | 1 | -18/+18 |
| | |||||
* | Cargo cult fix to make Celluloid behave | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+3 |
| | |||||
* | Require tree | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Simpler directory structure | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 |
| | |||||
* | Note that changes to the cable setup requires restarting the server | David Heinemeier Hansson | 2015-12-16 | 3 | -0/+3 |
| | |||||
* | @App could have been set elsewhere | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Another stab at only mounting redis if the config is there | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 |
| | |||||
* | Assume that the cable server is running in-process by default, offer option ↵ | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+2 |
| | | | | to change that in config/environments/production.rb | ||||
* | Fix parent class | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Doh, should have read ff370ee61754b00f864f3ddd0af62be4dfa0de67 | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | | | | Indeed we need this to be an engine for the internal assets to work | ||||
* | Only initialize redis if the config file is there | David Heinemeier Hansson | 2015-12-16 | 1 | -5/+5 |
| | |||||
* | Include changes made to the engine | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+5 |
| | |||||
* | Move Cable to ActionCable for client-side constant to avoid conflicts | David Heinemeier Hansson | 2015-12-16 | 8 | -49/+49 |
| | |||||
* | We are using railtie, not engine | David Heinemeier Hansson | 2015-12-16 | 2 | -36/+1 |
| | |||||
* | Basic channel generator | David Heinemeier Hansson | 2015-12-15 | 7 | -0/+101 |
| | |||||
* | Move the require to the right place | Rafael Mendonça França | 2015-12-15 | 2 | -2/+1 |
| | |||||
* | Remove the default logger | Rafael Mendonça França | 2015-12-15 | 1 | -1/+0 |
| | | | | It should be configured through the railtie | ||||
* | Configure the Action Cable's redis in the engine | Rafael Mendonça França | 2015-12-15 | 2 | -22/+6 |
| | | | | This will decouple Action Cable from Rails. | ||||
* | Action Cable need to be a engine | Rafael Mendonça França | 2015-12-15 | 1 | -0/+30 |
| | | | | Otherwise assets will not work | ||||
* | Bring latest changes over from actioncable/master | Javan Makhmali | 2015-12-15 | 1 | -1/+12 |
| | |||||
* | Switch from engine to railtie | David Heinemeier Hansson | 2015-12-15 | 1 | -5/+5 |
| | |||||
* | Hook in ActionView::Base, not in ApplicationController | Rafael Mendonça França | 2015-12-14 | 1 | -2/+4 |
| | | | | | | The application can have more than one ApplicationController and we want Action Cable helpers in all controllers and their views so we should hook in the same place that others helpers. | ||||
* | Require the top level file in the engine | Rafael Mendonça França | 2015-12-14 | 1 | -0/+1 |
| | |||||
* | Initial stab at adding Action Cable to rails/master | David Heinemeier Hansson | 2015-12-14 | 4 | -12/+49 |
| | |||||
* | Get ready to merge into Rails | David Heinemeier Hansson | 2015-12-14 | 36 | -0/+1905 |