Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Handle more IO errors (especially, ECONNRESET) | Matthew Draper | 2016-01-30 | 1 | -21/+47 |
| | | | | | | Also, address the possibility of the listen thread dying and needing to be respawned. As a bonus, we now defer construction of the thread until we are first given something to monitor. | ||||
* | Synchronize the lazy setters in Server | Matthew Draper | 2016-01-30 | 5 | -15/+47 |
| | | | | They're all at risk of races on the first requests. | ||||
* | Fix arguments to on_close | Matthew Draper | 2016-01-30 | 2 | -5/+3 |
| | |||||
* | Revert "Revert "Eliminate the EventMachine dependency"" | Matthew Draper | 2016-01-30 | 16 | -46/+349 |
| | |||||
* | Revert "Eliminate the EventMachine dependency" | David Heinemeier Hansson | 2016-01-27 | 16 | -349/+46 |
| | |||||
* | Merge branch '5-0-beta-sec' | Aaron Patterson | 2016-01-25 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | * 5-0-beta-sec: bumping version fix version update task to deal with .beta1.1 Eliminate instance level writers for class accessors allow :file to be outside rails root, but anything else must be inside the rails view directory Don't short-circuit reject_if proc stop caching mime types globally use secure string comparisons for basic auth username / password | ||||
| * | bumping version | Aaron Patterson | 2016-01-25 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #23185 from droptheplot/actioncable-custom-channels | Kasper Timm Hansen | 2016-01-24 | 1 | -3/+5 |
|\ \ | | | | | | | ActionCable: Allow adding custom paths for channels | ||||
| * | | Rename channels_path var and fix channel_paths method for ActionCable config | Sergey Novikov | 2016-01-23 | 1 | -5/+5 |
| | | | |||||
| * | | Allow adding custom paths for action_cable channels | Sergey Novikov | 2016-01-22 | 1 | -2/+4 |
| | | | |||||
* | | | Ditch the EM error logging helper | Matthew Draper | 2016-01-24 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | We're no longer doing our work in the EM event loop, so errors are quite unlikely, and if they do occur, they're not really our responsibility to handle. | ||||
* | | | Import the relevant portions of faye-websocket | Matthew Draper | 2016-01-24 | 7 | -21/+321 |
| | | | | | | | | | | | | (as adapted to use concurrent-ruby / nio4r instead of eventmachine) | ||||
* | | | Using a hacked faye-websocket, drop EventMachine | Matthew Draper | 2016-01-24 | 9 | -22/+33 |
| | | | |||||
* | | | Allow subscription adapters to be shut down | Matthew Draper | 2016-01-24 | 4 | -14/+40 |
| | | | |||||
* | | | Add Async and Inline adapters | Matthew Draper | 2016-01-24 | 2 | -0/+44 |
| | | | | | | | | | | | | | | | Just like their ActiveJob equivalents, these only work within the current process. | ||||
* | | | Normalize on no arguments for the success callback | Matthew Draper | 2016-01-24 | 2 | -2/+2 |
| | | | |||||
* | | | Split internal subscriber tracking from Postgres adapter | Matthew Draper | 2016-01-24 | 3 | -24/+70 |
| | | | |||||
* | | | Use the correct reference to the redis connection | Brit Gardner | 2016-01-22 | 1 | -1/+1 |
|/ / | | | | | | | | | Fixes #23193 This was throwing `There was an exception - NameError(undefined local variable or method `hi_redis_conn' for #<ActionCable::SubscriptionAdapter::Redis:0x007fb1449e2b70>)` on unsubscribe. | ||||
* | | Merge pull request #22950 from maclover7/adapterize-storage-actioncable | Matthew Draper | 2016-01-20 | 14 | -42/+205 |
|\ \ | | | | | | | | | | Adapterize storage for ActionCable | ||||
| * | | Fix code review comments | Jon Moss | 2016-01-18 | 9 | -46/+42 |
| | | | | | | | | | | | | | | | | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters | ||||
| * | | Small PostgreSQL adapter refactors / cleanup | Jon Moss | 2016-01-18 | 2 | -15/+16 |
| | | | | | | | | | | | | | | | - Escape the channel name when subscribing in PG - Refactor popping the queue to make it easier to read | ||||
| * | | ActionCable::StorageAdapter ==> ActionCable::SubscriptionAdapter | Jon Moss | 2016-01-18 | 8 | -15/+17 |
| | | | |||||
| * | | All Redis deps are now optional, Postgres --> PostgreSQL adapter | Jon Moss | 2016-01-18 | 3 | -4/+14 |
| | | | |||||
| * | | config_opts => cable, per @kaspth | Jon Moss | 2016-01-18 | 3 | -6/+7 |
| | | | |||||
| * | | Listener no longer needs to be a singleton | Matthew Draper | 2016-01-18 | 1 | -52/+58 |
| | | | | | | | | | | | | | | | | | | | | | We now only create one adapter instance for the server, so it can hold the listener. This in turn allows the listener to get the PG connection from the adapter, which will be a good place to allow more flexible configuration. | ||||
| * | | Tests passing and small refactoring | Jon Moss | 2016-01-18 | 1 | -1/+1 |
| | | | |||||
| * | | Blanket unsubscribe doesn't appear to be used | Matthew Draper | 2016-01-18 | 1 | -6/+2 |
| | | | |||||
| * | | Don't execute callbacks on our main listener thread | Matthew Draper | 2016-01-18 | 1 | -1/+1 |
| | | | |||||
| * | | Pull the action methods directly onto the adapter | Matthew Draper | 2016-01-18 | 8 | -56/+51 |
| | | | |||||
| * | | Add Postgres adapter | Jon Moss | 2016-01-18 | 2 | -0/+110 |
| | | | |||||
| * | | Refactor storage_adapter | Jon Moss | 2016-01-18 | 1 | -11/+3 |
| | | | |||||
| * | | Adapterize ActionCable storage and extract behavior | Jon Moss | 2016-01-18 | 12 | -38/+94 |
|/ / | |||||
* | | Fix the updated API (this sorts the concurrent-ruby switch with Basecamp) | David Heinemeier Hansson | 2016-01-16 | 1 | -1/+1 |
| | | |||||
* | | Revert "Merge pull request #22977 from rails/revert-22934-master" | David Heinemeier Hansson | 2016-01-16 | 5 | -21/+44 |
| | | | | | | | | | | This reverts commit d0393fccffc118a5de37654aa222774b66123393, reversing changes made to 3b7ccadfc1c8dfec61af898167e1300b17f5cf25. | ||||
* | | [ci skip] Fix typo in docs | DAVID MOORE | 2016-01-15 | 1 | -1/+1 |
| | | | | | | | | | | Found this small omission while reviewing the ActionCable docs. [Dave Moore] | ||||
* | | Revert "Move async execution from celluloid to concurrent-ruby" | David Heinemeier Hansson | 2016-01-08 | 5 | -44/+21 |
| | | |||||
* | | don't need explicit dep and a pretty neat pick | Mike Perham | 2016-01-05 | 1 | -1/+1 |
| | | |||||
* | | Use Module#thread_mattr_accessor | Mike Perham | 2016-01-05 | 1 | -8/+6 |
| | | |||||
* | | Move async execution from celluloid to concurrent-ruby | Mike Perham | 2016-01-05 | 5 | -21/+46 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes 8 runtime gem dependencies from Rails: ``` Using hitimes 1.2.3 Using timers 4.1.1 Using celluloid-essentials 0.20.5 Using celluloid-extras 0.20.5 Using celluloid-fsm 0.20.5 Using celluloid-pool 0.20.5 Using celluloid-supervision 0.20.5 Using celluloid 0.17.2 ``` | ||||
* | | Update copyright notices to 2016 [ci skip] | Rashmi Yadav | 2015-12-31 | 1 | -1/+1 |
| | | |||||
* | | Remove client-side Action Cable debugging code | Javan Makhmali | 2015-12-31 | 4 | -28/+0 |
| | | | | | | | | Added to aid in developing Action Cable, but isn't neccessary for production operation. | ||||
* | | [ActionCable] remove not needed protected call and newlines | Jan Habermann | 2015-12-25 | 2 | -9/+1 |
| | | |||||
* | | Use the generators options to not generate channel assets | Rafael Mendonça França | 2015-12-21 | 1 | -1/+4 |
| | | |||||
* | | Action Cable channel generator should not create JS assets in --api mode | Ryo Hashimoto | 2015-12-19 | 1 | -1/+3 |
|/ | |||||
* | Change `alpha` to `beta1` to prep for release of Rails 5 | eileencodes | 2015-12-18 | 1 | -1/+1 |
| | | | | :tada: :beers: | ||||
* | Merge pull request #22660 from y-yagi/add_line_break_between_methods | Rafael França | 2015-12-18 | 1 | -1/+1 |
|\ | | | | | add line break between method of generated channel js | ||||
| * | add line break between method of generated channel js | yuuji.yaginuma | 2015-12-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` ``` # after App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` | ||||
* | | [ci skip] Fix grammar | Akshay Vishnoi | 2015-12-18 | 2 | -2/+2 |
|/ | |||||
* | [ci skip] Fix typo | Akshay Vishnoi | 2015-12-18 | 1 | -1/+1 |
| | |||||
* | Merge pull request #22639 from arunagw/aa-remove-few-warnings-actioncable | Guillermo Iguaran | 2015-12-17 | 5 | -4/+11 |
|\ | | | | | Remove warnings from actioncable test |