| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\
| |
| | |
Fix typos in ActionCable Channel [ci skip]
|
| | |
|
| |
| |
| |
| | |
`cable.js` is required for other Channels.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Alternate implementation of #24162 with tests. The code had diverged
too far on master to pull that implemenation directly.
Fixes #23778
Close #24162
[Mattew Draper & Sean Griffin]
|
|/
|
|
|
|
|
|
|
| |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
|\
| |
| |
| | |
ActionCable protocol negotiation
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is primarily for backwards compatibility for when
or if the protocol is changed in future versions.
If the server fails to respond with an acceptable
protocol, the client disconnects and disables
the monitor.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Introduce a connection coder responsible for encoding Cable messages
as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck-
typing to any object responding to `#encode` and `#decode`.
* Consolidate encoding responsibility to the connection. No longer
explicitly JSON-encode from channels or other sources. Pass Cable
messages as Hashes to `#transmit` and rely on it to encode.
* Introduce stream encoders responsible for decoding pubsub messages.
Preserve the currently raw encoding, but make it easy to use JSON.
Same duck type as the connection encoder.
* Revert recent data normalization/quoting (#23649) which treated
`identifier` and `data` values as nested JSON objects rather than as
opaque JSON-encoded strings. That dealt us an awkward hand where we'd
decode JSON strings… or not, but always encode as JSON. Embedding
JSON object values directly is preferably, no extra JSON encoding,
but that should be a purposeful protocol version change rather than
ambiguously, inadvertently supporting multiple message formats.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whack it down from 100 to 4.
Large worker pools means large db connection counts. We aren't set up
for that by default and most apps won't need it out of the box.
We're better off tuning the default worker pool for low traffic, low
resource consumption apps. Those who have higher traffic will scale up
to meet demand.
|
| |
| |
| |
| |
| |
| | |
To move Action Cable logging to a LoggingSubscriber we need to pass the
log tags in the notification payload since Action Cable logging use the
Channel instance to tag the logs.
|
|\ \
| | |
| | |
| | | |
Add ActiveSupport::Notification to Channel::Base#perform_action
|
| | |
| | |
| | |
| | |
| | | |
This commit adds ActiveSupport::Notifications instrumentation hooks
and a LogSuscriber to ActionCable::Channel::Base.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We'll get `Errno::ECONNRESET` if the client forcibly disconnected.
Just close the socket rather than raising the exception.
Handle other errors in `ClientSocket#write`, too, mirroring the Faye
error handling which swallows all `StandardError` on write.
|
| |/
|/|
| |
| | |
[ci skip]
|
|/ |
|
| |
|
|\
| |
| | |
Support faye-websocket + EventMachine as an option
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Fixes #22675
Allow channel identifiers and also data with no backslahes/escaping to be accepted by
the subscription storer.
|
|\ \
| | |
| | |
| | | |
ActionCable: Add a "welcome" and "ping" message type
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This change makes ping into a message type, which
makes the whole protocol a lot more consistent.
Also fixes hacks on the client side to make this all
work.
|
| | | |
|
|\ \ \
| |_|/
|/| | |
convert cable.coffee to cable.js
|
| | |
| | |
| | |
| | | |
In order to eliminate the dependecy of CoffeeScript.
|
| |/
|/| |
|
|\ \
| |/
|/| |
Ensure actioncable behaves as expected with non-string queues
|
| |
| |
| |
| |
| |
| | |
Similar to the channel streaming side, these values must be strings for
ActionCable to behave as expected. The conversion will allow users to
send string-convertible values and get the expected behavior.
|
| |
| |
| |
| |
| |
| |
| | |
ActionCable does some things behind the scenes that expects these
"broadcasting"s or "channel"s to be strings. However it's not
immediately obvious that the value must be a string. So adding this
conversion ensures things work as expected.
|
| |
| |
| |
| |
| | |
* Fix typos/grammar errors
* Make capitalization/naming consistent
|
|\ \
| | |
| | |
| | |
| | | |
lifo/same-redis-connection-for-subscription-and-broadcast
Always use redis_connector to create redis connections
|
| | |
| | |
| | |
| | | |
broadcasts
|
| | |
| | |
| | |
| | | |
If we're deferring one, we should defer the other too.
|
|\ \ \
| | | |
| | | | |
Only hijack Rack socket when first needed
|
| | |/
| |/|
| | |
| | | |
Fixes #23471
|
|/ /
| |
| |
| | |
This also marks Action Cable routes as internal to Rails.
|
| | |
|
|\ \
| | |
| | | |
Improve Action Cable reconnection reliability
|
| |/ |
|
|\ \
| | |
| | | |
Full Action Cable documentation read through
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This PR checks all active Action Cable documentation for typos and other
fixes. It aims to make sure that when Rails 5 is released, that the
Action Cable docs are up to snuff with the other documentation included
with Rails.
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Once RubyGems 2.5.0 is required, then the duplicated files can be
removed, and symlinks can be used instead.
[ci skip]
|
| |/
|/| |
|
| | |
|
|\ \
| | |
| | | |
Make ActionCable logging less verbose in development
|
| |/
| |
| |
| |
| |
| | |
When running the ActionCable server in development I get a lot of output
in my logs, this commit sets a maximum length of 300 characters for a
broadcast log message.
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Before this commit, the `unsubscribed` callbacks in Action Cable server
side channels were never called. This is because when a WebSocket
"goodbye" message was sent from the client, the Action Cable server
didn't properly clean up after the now closed WebSocket. This means that
memory could possibly skyrocket with this behavior, since part of this
commit is to properly remove closed subscriptions from the global
subscriptions hash. Say you have 10,000 users currently connected, and
then all 10,000 disconnect -- before this patch, Action Cable would
still hold onto information (and Ruby objects!) for all of these now
dead connections.
|
|\
| |
| | |
Inject Rails related configuration through Railtie
|
| |
| |
| |
| |
| |
| |
| | |
Instead of depending on ApplicationCable::Connection being defined at initialize
we should inject it in the Railtie.
Thus we can kill more setup in the tests too.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize,
thereby coupling ourselves to Rails.
Instead add `app/channels` to Rails' app paths and assign the existent files
to `channel_paths`.
Users can still append to those load paths with `<<` and `push` in `config/application.rb`.
This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails
and root definitions in the tests.
|