Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use the correct reference to the redis connection | Brit Gardner | 2016-01-22 | 1 | -1/+1 |
| | | | | | Fixes #23193 This was throwing `There was an exception - NameError(undefined local variable or method `hi_redis_conn' for #<ActionCable::SubscriptionAdapter::Redis:0x007fb1449e2b70>)` on unsubscribe. | ||||
* | Merge pull request #22950 from maclover7/adapterize-storage-actioncable | Matthew Draper | 2016-01-20 | 14 | -42/+205 |
|\ | | | | | | | Adapterize storage for ActionCable | ||||
| * | Fix code review comments | Jon Moss | 2016-01-18 | 9 | -46/+42 |
| | | | | | | | | | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters | ||||
| * | Small PostgreSQL adapter refactors / cleanup | Jon Moss | 2016-01-18 | 2 | -15/+16 |
| | | | | | | | | | | - Escape the channel name when subscribing in PG - Refactor popping the queue to make it easier to read | ||||
| * | ActionCable::StorageAdapter ==> ActionCable::SubscriptionAdapter | Jon Moss | 2016-01-18 | 8 | -15/+17 |
| | | |||||
| * | All Redis deps are now optional, Postgres --> PostgreSQL adapter | Jon Moss | 2016-01-18 | 3 | -4/+14 |
| | | |||||
| * | config_opts => cable, per @kaspth | Jon Moss | 2016-01-18 | 3 | -6/+7 |
| | | |||||
| * | Listener no longer needs to be a singleton | Matthew Draper | 2016-01-18 | 1 | -52/+58 |
| | | | | | | | | | | | | | | We now only create one adapter instance for the server, so it can hold the listener. This in turn allows the listener to get the PG connection from the adapter, which will be a good place to allow more flexible configuration. | ||||
| * | Tests passing and small refactoring | Jon Moss | 2016-01-18 | 1 | -1/+1 |
| | | |||||
| * | Blanket unsubscribe doesn't appear to be used | Matthew Draper | 2016-01-18 | 1 | -6/+2 |
| | | |||||
| * | Don't execute callbacks on our main listener thread | Matthew Draper | 2016-01-18 | 1 | -1/+1 |
| | | |||||
| * | Pull the action methods directly onto the adapter | Matthew Draper | 2016-01-18 | 8 | -56/+51 |
| | | |||||
| * | Add Postgres adapter | Jon Moss | 2016-01-18 | 2 | -0/+110 |
| | | |||||
| * | Refactor storage_adapter | Jon Moss | 2016-01-18 | 1 | -11/+3 |
| | | |||||
| * | Adapterize ActionCable storage and extract behavior | Jon Moss | 2016-01-18 | 12 | -38/+94 |
|/ | |||||
* | Fix the updated API (this sorts the concurrent-ruby switch with Basecamp) | David Heinemeier Hansson | 2016-01-16 | 1 | -1/+1 |
| | |||||
* | Revert "Merge pull request #22977 from rails/revert-22934-master" | David Heinemeier Hansson | 2016-01-16 | 5 | -21/+44 |
| | | | | | This reverts commit d0393fccffc118a5de37654aa222774b66123393, reversing changes made to 3b7ccadfc1c8dfec61af898167e1300b17f5cf25. | ||||
* | [ci skip] Fix typo in docs | DAVID MOORE | 2016-01-15 | 1 | -1/+1 |
| | | | | | Found this small omission while reviewing the ActionCable docs. [Dave Moore] | ||||
* | Revert "Move async execution from celluloid to concurrent-ruby" | David Heinemeier Hansson | 2016-01-08 | 5 | -44/+21 |
| | |||||
* | don't need explicit dep and a pretty neat pick | Mike Perham | 2016-01-05 | 1 | -1/+1 |
| | |||||
* | Use Module#thread_mattr_accessor | Mike Perham | 2016-01-05 | 1 | -8/+6 |
| | |||||
* | Move async execution from celluloid to concurrent-ruby | Mike Perham | 2016-01-05 | 5 | -21/+46 |
| | | | | | | | | | | | | | | This removes 8 runtime gem dependencies from Rails: ``` Using hitimes 1.2.3 Using timers 4.1.1 Using celluloid-essentials 0.20.5 Using celluloid-extras 0.20.5 Using celluloid-fsm 0.20.5 Using celluloid-pool 0.20.5 Using celluloid-supervision 0.20.5 Using celluloid 0.17.2 ``` | ||||
* | Update copyright notices to 2016 [ci skip] | Rashmi Yadav | 2015-12-31 | 1 | -1/+1 |
| | |||||
* | Remove client-side Action Cable debugging code | Javan Makhmali | 2015-12-31 | 4 | -28/+0 |
| | | | | Added to aid in developing Action Cable, but isn't neccessary for production operation. | ||||
* | [ActionCable] remove not needed protected call and newlines | Jan Habermann | 2015-12-25 | 2 | -9/+1 |
| | |||||
* | Use the generators options to not generate channel assets | Rafael Mendonça França | 2015-12-21 | 1 | -1/+4 |
| | |||||
* | Action Cable channel generator should not create JS assets in --api mode | Ryo Hashimoto | 2015-12-19 | 1 | -1/+3 |
| | |||||
* | Change `alpha` to `beta1` to prep for release of Rails 5 | eileencodes | 2015-12-18 | 1 | -1/+1 |
| | | | | :tada: :beers: | ||||
* | Merge pull request #22660 from y-yagi/add_line_break_between_methods | Rafael França | 2015-12-18 | 1 | -1/+1 |
|\ | | | | | add line break between method of generated channel js | ||||
| * | add line break between method of generated channel js | yuuji.yaginuma | 2015-12-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` ``` # after App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` | ||||
* | | [ci skip] Fix grammar | Akshay Vishnoi | 2015-12-18 | 2 | -2/+2 |
|/ | |||||
* | [ci skip] Fix typo | Akshay Vishnoi | 2015-12-18 | 1 | -1/+1 |
| | |||||
* | Merge pull request #22639 from arunagw/aa-remove-few-warnings-actioncable | Guillermo Iguaran | 2015-12-17 | 5 | -4/+11 |
|\ | | | | | Remove warnings from actioncable test | ||||
| * | Remove warnings from actioncable | Arun Agrawal | 2015-12-17 | 5 | -4/+11 |
| | | | | | | | | Warnings coming from code and test are removed | ||||
* | | Should also stub the received callback | David Heinemeier Hansson | 2015-12-17 | 1 | -0/+3 |
| | | |||||
* | | Don't log Action Cable to STDOUT in development | eileencodes | 2015-12-17 | 2 | -10/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Logging Action Cable to STDOUT caused the development log to see double messages like this: ``` Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500 Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500 Processing by Rails::WelcomeController#index as HTML Processing by Rails::WelcomeController#index as HTML Rendered /welcome/index.html.erb (0.0ms) Rendered /welcome/index.html.erb (0.0ms) Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms) Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms) ``` Now that Action Cable is part of Rails it doesn't need it's own logger and will log to STDOUT via the local dev server here: https://github.com/rails/rails/blob/master/railties/lib/rails/commands/server.rb | ||||
* | | traditional make sense with `<tt>ActiveSupport::TaggedLogging</tt>` | Gaurav Sharma | 2015-12-18 | 1 | -2/+2 |
|/ | |||||
* | Update USAGE | Paul Montero | 2015-12-17 | 1 | -1/+1 |
| | | | Fix typo | ||||
* | Clarify | David Heinemeier Hansson | 2015-12-16 | 1 | -3/+3 |
| | |||||
* | Generate all the ApplicationCable stubs by default, like all other ↵ | David Heinemeier Hansson | 2015-12-16 | 4 | -41/+0 |
| | | | | Application* stubs | ||||
* | Comment out the user handling so default setup connects directly | David Heinemeier Hansson | 2015-12-16 | 1 | -18/+18 |
| | |||||
* | Cargo cult fix to make Celluloid behave | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+3 |
| | |||||
* | Require tree | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Simpler directory structure | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 |
| | |||||
* | Note that changes to the cable setup requires restarting the server | David Heinemeier Hansson | 2015-12-16 | 3 | -0/+3 |
| | |||||
* | @App could have been set elsewhere | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Another stab at only mounting redis if the config is there | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+2 |
| | |||||
* | Assume that the cable server is running in-process by default, offer option ↵ | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+2 |
| | | | | to change that in config/environments/production.rb | ||||
* | Fix parent class | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | |||||
* | Doh, should have read ff370ee61754b00f864f3ddd0af62be4dfa0de67 | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 |
| | | | | Indeed we need this to be an engine for the internal assets to work |