aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib
Commit message (Collapse)AuthorAgeFilesLines
* Use the correct reference to the redis connectionBrit Gardner2016-01-221-1/+1
| | | | | Fixes #23193 This was throwing `There was an exception - NameError(undefined local variable or method `hi_redis_conn' for #<ActionCable::SubscriptionAdapter::Redis:0x007fb1449e2b70>)` on unsubscribe.
* Merge pull request #22950 from maclover7/adapterize-storage-actioncableMatthew Draper2016-01-2014-42/+205
|\ | | | | | | Adapterize storage for ActionCable
| * Fix code review commentsJon Moss2016-01-189-46/+42
| | | | | | | | | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters
| * Small PostgreSQL adapter refactors / cleanupJon Moss2016-01-182-15/+16
| | | | | | | | | | - Escape the channel name when subscribing in PG - Refactor popping the queue to make it easier to read
| * ActionCable::StorageAdapter ==> ActionCable::SubscriptionAdapterJon Moss2016-01-188-15/+17
| |
| * All Redis deps are now optional, Postgres --> PostgreSQL adapterJon Moss2016-01-183-4/+14
| |
| * config_opts => cable, per @kaspthJon Moss2016-01-183-6/+7
| |
| * Listener no longer needs to be a singletonMatthew Draper2016-01-181-52/+58
| | | | | | | | | | | | | | We now only create one adapter instance for the server, so it can hold the listener. This in turn allows the listener to get the PG connection from the adapter, which will be a good place to allow more flexible configuration.
| * Tests passing and small refactoringJon Moss2016-01-181-1/+1
| |
| * Blanket unsubscribe doesn't appear to be usedMatthew Draper2016-01-181-6/+2
| |
| * Don't execute callbacks on our main listener threadMatthew Draper2016-01-181-1/+1
| |
| * Pull the action methods directly onto the adapterMatthew Draper2016-01-188-56/+51
| |
| * Add Postgres adapterJon Moss2016-01-182-0/+110
| |
| * Refactor storage_adapterJon Moss2016-01-181-11/+3
| |
| * Adapterize ActionCable storage and extract behaviorJon Moss2016-01-1812-38/+94
|/
* Fix the updated API (this sorts the concurrent-ruby switch with Basecamp)David Heinemeier Hansson2016-01-161-1/+1
|
* Revert "Merge pull request #22977 from rails/revert-22934-master"David Heinemeier Hansson2016-01-165-21/+44
| | | | | This reverts commit d0393fccffc118a5de37654aa222774b66123393, reversing changes made to 3b7ccadfc1c8dfec61af898167e1300b17f5cf25.
* [ci skip] Fix typo in docsDAVID MOORE2016-01-151-1/+1
| | | | | Found this small omission while reviewing the ActionCable docs. [Dave Moore]
* Revert "Move async execution from celluloid to concurrent-ruby"David Heinemeier Hansson2016-01-085-44/+21
|
* don't need explicit dep and a pretty neat pickMike Perham2016-01-051-1/+1
|
* Use Module#thread_mattr_accessorMike Perham2016-01-051-8/+6
|
* Move async execution from celluloid to concurrent-rubyMike Perham2016-01-055-21/+46
| | | | | | | | | | | | | | This removes 8 runtime gem dependencies from Rails: ``` Using hitimes 1.2.3 Using timers 4.1.1 Using celluloid-essentials 0.20.5 Using celluloid-extras 0.20.5 Using celluloid-fsm 0.20.5 Using celluloid-pool 0.20.5 Using celluloid-supervision 0.20.5 Using celluloid 0.17.2 ```
* Update copyright notices to 2016 [ci skip]Rashmi Yadav2015-12-311-1/+1
|
* Remove client-side Action Cable debugging codeJavan Makhmali2015-12-314-28/+0
| | | | Added to aid in developing Action Cable, but isn't neccessary for production operation.
* [ActionCable] remove not needed protected call and newlinesJan Habermann2015-12-252-9/+1
|
* Use the generators options to not generate channel assetsRafael Mendonça França2015-12-211-1/+4
|
* Action Cable channel generator should not create JS assets in --api modeRyo Hashimoto2015-12-191-1/+3
|
* Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | :tada: :beers:
* Merge pull request #22660 from y-yagi/add_line_break_between_methodsRafael França2015-12-181-1/+1
|\ | | | | add line break between method of generated channel js
| * add line break between method of generated channel jsyuuji.yaginuma2015-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` ``` # after App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ```
* | [ci skip] Fix grammarAkshay Vishnoi2015-12-182-2/+2
|/
* [ci skip] Fix typoAkshay Vishnoi2015-12-181-1/+1
|
* Merge pull request #22639 from arunagw/aa-remove-few-warnings-actioncableGuillermo Iguaran2015-12-175-4/+11
|\ | | | | Remove warnings from actioncable test
| * Remove warnings from actioncableArun Agrawal2015-12-175-4/+11
| | | | | | | | Warnings coming from code and test are removed
* | Should also stub the received callbackDavid Heinemeier Hansson2015-12-171-0/+3
| |
* | Don't log Action Cable to STDOUT in developmenteileencodes2015-12-172-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Logging Action Cable to STDOUT caused the development log to see double messages like this: ``` Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500 Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500 Processing by Rails::WelcomeController#index as HTML Processing by Rails::WelcomeController#index as HTML Rendered /welcome/index.html.erb (0.0ms) Rendered /welcome/index.html.erb (0.0ms) Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms) Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms) ``` Now that Action Cable is part of Rails it doesn't need it's own logger and will log to STDOUT via the local dev server here: https://github.com/rails/rails/blob/master/railties/lib/rails/commands/server.rb
* | traditional make sense with `<tt>ActiveSupport::TaggedLogging</tt>`Gaurav Sharma2015-12-181-2/+2
|/
* Update USAGEPaul Montero2015-12-171-1/+1
| | | Fix typo
* ClarifyDavid Heinemeier Hansson2015-12-161-3/+3
|
* Generate all the ApplicationCable stubs by default, like all other ↵David Heinemeier Hansson2015-12-164-41/+0
| | | | Application* stubs
* Comment out the user handling so default setup connects directlyDavid Heinemeier Hansson2015-12-161-18/+18
|
* Cargo cult fix to make Celluloid behaveDavid Heinemeier Hansson2015-12-161-0/+3
|
* Require treeDavid Heinemeier Hansson2015-12-161-1/+1
|
* Simpler directory structureDavid Heinemeier Hansson2015-12-161-2/+2
|
* Note that changes to the cable setup requires restarting the serverDavid Heinemeier Hansson2015-12-163-0/+3
|
* @App could have been set elsewhereDavid Heinemeier Hansson2015-12-161-1/+1
|
* Another stab at only mounting redis if the config is thereDavid Heinemeier Hansson2015-12-161-2/+2
|
* Assume that the cable server is running in-process by default, offer option ↵David Heinemeier Hansson2015-12-161-0/+2
| | | | to change that in config/environments/production.rb
* Fix parent classDavid Heinemeier Hansson2015-12-161-1/+1
|
* Doh, should have read ff370ee61754b00f864f3ddd0af62be4dfa0de67David Heinemeier Hansson2015-12-161-1/+1
| | | | Indeed we need this to be an engine for the internal assets to work