aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Add notes for future selvesJon Moss2016-02-221-0/+1
| | | | | | | | | | | | | | | | | | | | | Once RubyGems 2.5.0 is required, then the duplicated files can be removed, and symlinks can be used instead. [ci skip]
* | | Generate ApplicationCable files if they do not already existJon Moss2016-02-223-0/+26
| |/ |/|
* | Fixed typoChashmeet Singh2016-02-211-1/+1
| |
* | Merge pull request #23709 from jankeesvw/set-action-cable-logging-to-debugDavid Heinemeier Hansson2016-02-191-1/+1
|\ \ | | | | | | Make ActionCable logging less verbose in development
| * | Truncate ActionCable broadcast message to 300 charsJankees van Woezik2016-02-181-1/+1
| |/ | | | | | | | | | | When running the ActionCable server in development I get a lot of output in my logs, this commit sets a maximum length of 300 characters for a broadcast log message.
* / Fix `unsubscribed` server side behaviorJon Moss2016-02-182-6/+3
|/ | | | | | | | | | | | | Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
* Merge pull request #23505 from kaspth/inject-rails-config-through-railtieKasper Timm Hansen2016-02-142-11/+10
|\ | | | | Inject Rails related configuration through Railtie
| * Default connection class to ActionCable::Connection::Base.Kasper Timm Hansen2016-02-142-2/+6
| | | | | | | | | | | | | | Instead of depending on ApplicationCable::Connection being defined at initialize we should inject it in the Railtie. Thus we can kill more setup in the tests too.
| * Inject Rails' channel paths in engine.Kasper Timm Hansen2016-02-142-9/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize, thereby coupling ourselves to Rails. Instead add `app/channels` to Rails' app paths and assign the existent files to `channel_paths`. Users can still append to those load paths with `<<` and `push` in `config/application.rb`. This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails and root definitions in the tests.
* | Fix grammar `a` to `an` [ci skip]Ryuta Kamizono2016-02-132-2/+2
| |
* | Merge remote-tracking branch 'origin/master' into actioncable_loggingkp2016-02-1021-446/+350
|\|
| * don’t explicitly mention EventMachine [ci skip]yuuji.yaginuma2016-02-051-1/+1
| | | | | | | | Follow up to 6accef4e11b0c793e1c085536b5ed27f32b6a0c3
| * Allow for non-standard redis connectorsDavid Heinemeier Hansson2016-02-042-3/+15
| |
| * [ci skip] Several ActionCable documentation updates:Nick Quaranto2016-02-024-40/+53
| | | | | | | | | | | | | | | | * Properly indent code sample in ActionCable::Channel::Streams * Add a doc comment for #stop_all_streams * Reformat + add <tt> blocks around code references in ActionCable::Base docs * Clarify and a little better grammar on ActionCable::RemoteConnections * Correct indentation and clean up ActionCable::Server::Broadcasting code sample
| * Preparing for Rails 5.0.0.beta2Sean Griffin2016-02-011-1/+1
| |
| * Merge pull request #23381 from matthewd/uneventful-redisMatthew Draper2016-02-022-30/+193
| |\ | | | | | | Redis sans EventMachine
| | * Switch the default redis adapter to a single-stream modelMatthew Draper2016-02-012-30/+193
| | | | | | | | | | | | | | | | | | This new adapter does get a little more intimate with the redis-rb gem's implementation than I would like, but it's the least bad of the approaches I've come up with.
| * | Improvements and reorganization of assetsJon Moss2016-01-307-341/+0
| | |
| * | Add task to create precompiled action_cable.js and reorganize to accommodateJavan Makhmali2016-01-307-5/+6
| |/
| * Handle more IO errors (especially, ECONNRESET)Matthew Draper2016-01-301-21/+47
| | | | | | | | | | | | Also, address the possibility of the listen thread dying and needing to be respawned. As a bonus, we now defer construction of the thread until we are first given something to monitor.
| * Synchronize the lazy setters in ServerMatthew Draper2016-01-305-15/+47
| | | | | | | | They're all at risk of races on the first requests.
| * Fix arguments to on_closeMatthew Draper2016-01-302-5/+3
| |
| * Revert "Revert "Eliminate the EventMachine dependency""Matthew Draper2016-01-3016-46/+349
| |
| * Revert "Eliminate the EventMachine dependency"David Heinemeier Hansson2016-01-2716-349/+46
| |
* | Logs successful and invalid connections separatelykp2016-02-101-8/+12
| |
* | adds debug logging to actioncable connectkp2016-01-261-2/+12
|/
* Merge branch '5-0-beta-sec'Aaron Patterson2016-01-251-1/+1
|\ | | | | | | | | | | | | | | | | | | | | * 5-0-beta-sec: bumping version fix version update task to deal with .beta1.1 Eliminate instance level writers for class accessors allow :file to be outside rails root, but anything else must be inside the rails view directory Don't short-circuit reject_if proc stop caching mime types globally use secure string comparisons for basic auth username / password
| * bumping versionAaron Patterson2016-01-251-1/+1
| |
* | Merge pull request #23185 from droptheplot/actioncable-custom-channelsKasper Timm Hansen2016-01-241-3/+5
|\ \ | | | | | | ActionCable: Allow adding custom paths for channels
| * | Rename channels_path var and fix channel_paths method for ActionCable configSergey Novikov2016-01-231-5/+5
| | |
| * | Allow adding custom paths for action_cable channelsSergey Novikov2016-01-221-2/+4
| | |
* | | Ditch the EM error logging helperMatthew Draper2016-01-241-8/+0
| | | | | | | | | | | | | | | | | | We're no longer doing our work in the EM event loop, so errors are quite unlikely, and if they do occur, they're not really our responsibility to handle.
* | | Import the relevant portions of faye-websocketMatthew Draper2016-01-247-21/+321
| | | | | | | | | | | | (as adapted to use concurrent-ruby / nio4r instead of eventmachine)
* | | Using a hacked faye-websocket, drop EventMachineMatthew Draper2016-01-249-22/+33
| | |
* | | Allow subscription adapters to be shut downMatthew Draper2016-01-244-14/+40
| | |
* | | Add Async and Inline adaptersMatthew Draper2016-01-242-0/+44
| | | | | | | | | | | | | | | Just like their ActiveJob equivalents, these only work within the current process.
* | | Normalize on no arguments for the success callbackMatthew Draper2016-01-242-2/+2
| | |
* | | Split internal subscriber tracking from Postgres adapterMatthew Draper2016-01-243-24/+70
| | |
* | | Use the correct reference to the redis connectionBrit Gardner2016-01-221-1/+1
|/ / | | | | | | | | Fixes #23193 This was throwing `There was an exception - NameError(undefined local variable or method `hi_redis_conn' for #<ActionCable::SubscriptionAdapter::Redis:0x007fb1449e2b70>)` on unsubscribe.
* | Merge pull request #22950 from maclover7/adapterize-storage-actioncableMatthew Draper2016-01-2014-42/+205
|\ \ | | | | | | | | | Adapterize storage for ActionCable
| * | Fix code review commentsJon Moss2016-01-189-46/+42
| | | | | | | | | | | | | | | | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters
| * | Small PostgreSQL adapter refactors / cleanupJon Moss2016-01-182-15/+16
| | | | | | | | | | | | | | | - Escape the channel name when subscribing in PG - Refactor popping the queue to make it easier to read
| * | ActionCable::StorageAdapter ==> ActionCable::SubscriptionAdapterJon Moss2016-01-188-15/+17
| | |
| * | All Redis deps are now optional, Postgres --> PostgreSQL adapterJon Moss2016-01-183-4/+14
| | |
| * | config_opts => cable, per @kaspthJon Moss2016-01-183-6/+7
| | |
| * | Listener no longer needs to be a singletonMatthew Draper2016-01-181-52/+58
| | | | | | | | | | | | | | | | | | | | | We now only create one adapter instance for the server, so it can hold the listener. This in turn allows the listener to get the PG connection from the adapter, which will be a good place to allow more flexible configuration.
| * | Tests passing and small refactoringJon Moss2016-01-181-1/+1
| | |
| * | Blanket unsubscribe doesn't appear to be usedMatthew Draper2016-01-181-6/+2
| | |
| * | Don't execute callbacks on our main listener threadMatthew Draper2016-01-181-1/+1
| | |
| * | Pull the action methods directly onto the adapterMatthew Draper2016-01-188-56/+51
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 05:28:01 +0000