aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib/rails
Commit message (Collapse)AuthorAgeFilesLines
* Define path with __dir__bogdanvlviv2017-05-231-1/+1
| | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-051-2/+2
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* Privatize unneededly protected methods in Action CableAkira Matsuda2016-12-241-1/+1
|
* Fix typo in channel generator usage messageCarlos Eduardo Monti2016-12-191-2/+2
|
* applies new string literal convention in actioncable/libXavier Noria2016-08-061-6/+6
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Give importance to rails command in the comment section.Santosh Wadghule2016-07-131-1/+1
|
* remove needless commentsyuuji.yaginuma2016-06-063-5/+0
| | | | Follow up to #25240.
* Merge pull request #25076 from jeroenvisser101/keep-to-max-lengthSean Griffin2016-05-212-2/+4
|\ | | | | Change comments to not exceed 80 characters
| * Change comments to not exceed 80 charactersJeroen Visser2016-05-192-2/+4
| | | | | | | | Other generated files do keep to this, but action cable doesn't.
* | Cable: Generate .js or .coffee files while generating channel as per the ↵Prathamesh Sonpatki2016-05-172-1/+20
|/ | | | | | | | | | | | | | | | | | | | | javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper]
* don't remove `cable.js`yuuji.yaginuma2016-04-161-1/+3
| | | | `cable.js` is required for other Channels.
* Generate `cable.js` file if does not exist when generating channelPrathamesh Sonpatki2016-04-122-0/+14
| | | | | | | | | - Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4. - Based on the comment - https://github.com/rails/rails/issues/24418#issuecomment-205421995.
* Remove redundant regexp escapes in generatorsGadzhi Gadzhiev2016-03-081-1/+1
|
* convert cable.coffee to cable.jsyuuji.yaginuma2016-02-281-1/+1
| | | | In order to eliminate the dependecy of CoffeeScript.
* Add notes for future selvesJon Moss2016-02-221-0/+1
| | | | | | | Once RubyGems 2.5.0 is required, then the duplicated files can be removed, and symlinks can be used instead. [ci skip]
* Generate ApplicationCable files if they do not already existJon Moss2016-02-223-0/+26
|
* don’t explicitly mention EventMachine [ci skip]yuuji.yaginuma2016-02-051-1/+1
| | | | Follow up to 6accef4e11b0c793e1c085536b5ed27f32b6a0c3
* Use the generators options to not generate channel assetsRafael Mendonça França2015-12-211-1/+4
|
* Action Cable channel generator should not create JS assets in --api modeRyo Hashimoto2015-12-191-1/+3
|
* add line break between method of generated channel jsyuuji.yaginuma2015-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ``` ``` # after App.appearance = App.cable.subscriptions.create "AppearanceChannel", connected: -> # Called when the subscription is ready for use on the server disconnected: -> # Called when the subscription has been terminated by the server received: (data) -> # Called when there's incoming data on the websocket for this channel appear: -> @perform 'appear' away: -> @perform 'away' ```
* Should also stub the received callbackDavid Heinemeier Hansson2015-12-171-0/+3
|
* Update USAGEPaul Montero2015-12-171-1/+1
| | | Fix typo
* ClarifyDavid Heinemeier Hansson2015-12-161-3/+3
|
* Generate all the ApplicationCable stubs by default, like all other ↵David Heinemeier Hansson2015-12-164-41/+0
| | | | Application* stubs
* Comment out the user handling so default setup connects directlyDavid Heinemeier Hansson2015-12-161-18/+18
|
* Require treeDavid Heinemeier Hansson2015-12-161-1/+1
|
* Simpler directory structureDavid Heinemeier Hansson2015-12-161-2/+2
|
* Note that changes to the cable setup requires restarting the serverDavid Heinemeier Hansson2015-12-163-0/+3
|
* @App could have been set elsewhereDavid Heinemeier Hansson2015-12-161-1/+1
|
* Fix parent classDavid Heinemeier Hansson2015-12-161-1/+1
|
* Move Cable to ActionCable for client-side constant to avoid conflictsDavid Heinemeier Hansson2015-12-161-2/+2
|
* Basic channel generatorDavid Heinemeier Hansson2015-12-157-0/+101
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 22:35:53 +0000