aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib/action_cable
Commit message (Collapse)AuthorAgeFilesLines
...
* Prevent invocation of channel action if rejected connectionJon Moss2016-08-191-1/+1
| | | | | | | | | Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel.
* copy-edits an exception messageXavier Noria2016-08-071-1/+1
| | | | | | | | | | | | | | Inserted spaces in the name of Rails components. Since I was on it, also used PostgreSQL instead of Postgres because albeit Postgres is an accepted alias, PostgreSQL is the official name and the actual name of the adapter. See https://wiki.postgresql.org/wiki/ProjectName with regard to PostgreSQL vs Postgres.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
|
* applies remaining conventions across the projectXavier Noria2016-08-061-3/+3
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-1/+1
|
* applies new string literal convention in actioncable/libXavier Noria2016-08-0626-76/+76
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Merge pull request #25624 from tinco/actioncable_write_raceMatthew Draper2016-07-091-2/+7
|\ | | | | | | Fix race condition in websocket stream write
| * fix race condition in websocket stream writeTinco Andringa2016-07-011-0/+4
| |
* | Merge pull request #24988 from mwear/action_cable_broadcast_notificationsMatthew Draper2016-07-041-2/+6
|\ \ | | | | | | Add ActiveSupport::Notifications hook to ActionCable::Server.broadcast
| * | Add ActiveSupport::Notifications hook to Broadcaster#broadcastMatthew Wear2016-05-121-2/+6
| | | | | | | | | | | | | | | This addition of this notification hook will give users better visibility into the messages being sent over the PubSub adapter.
* | | Merge pull request #25030 from mmmpa/pull_requestMatthew Draper2016-07-041-1/+5
|\ \ \ | | | | | | | | ActionCable, sometimes add_channel is not called.
| * | | Add guard to broadcast.mmmpa2016-05-261-1/+5
| | | |
* | | | close hijacked i/o socket after use (fixes #25613)Tinco Andringa2016-07-011-0/+1
| |_|/ |/| |
* | | Periodic timers: delegate async instance_exec to the worker poolJeremy Daer2016-06-292-7/+9
| | |
* | | Allow actioncable connections from any port in developmentMichael Dever2016-06-161-1/+1
| | |
* | | Properly support reloading for Action Cable channelsMatthew Draper2016-06-024-30/+9
| | |
* | | fix grammarRajat Bansal2016-05-311-1/+1
|/ /
* | Pass over Action Cable docsJon Moss2016-05-212-4/+4
| | | | | | | | [ci skip]
* | Improve method descriptionRoman Pushkin2016-05-181-0/+1
| | | | | | Method description improved to reflect little bit more complicated scenario when names are camel-cased.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-05-141-2/+2
|\ \ | |/ |/| | | | | Conflicts: guides/source/configuring.md
| * Fix code formatting in docsJay Hayes2016-05-031-2/+2
| |
* | Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-101-2/+2
| |
* | Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-061-1/+1
| |
* | renames ActionCable::Railtie to ActionCable::EngineXavier Noria2016-05-041-1/+1
|/ | | | | | | | This is an engine living in action_cable/engine.rb, convention is to call these things *::Engine. Looking at thi git history looks like the current *::Railtie was just an accident.
* Prep Rails 5 beta 4eileencodes2016-04-271-1/+1
|
* Merge pull request #24669 from tomkadwill/action_pack_typosVipul A M2016-04-221-1/+1
|\ | | | | Actioncable and Actionpack documentation typos [ci skip]
| * Actioncable and Actionpack documentation typos [ci skip]Tom Kadwill2016-04-211-1/+1
| |
* | Log if redis connection is in stale/failed state.Vipul A M2016-04-211-0/+4
|/
* Cable: Extract stream handler constructionJeremy Daer2016-04-182-18/+62
| | | | | | | | * Use separate stream handler builders for easy override and testing. * Fix worker pool execution that was silently failing since it only expected connection receivers. Sparked by code in #24162.
* Cable: Periodic timers refreshJeremy Daer2016-04-182-19/+45
| | | | | | | | | * Rewrite docs * Support blocks in addition to method names and Proc args * Check for valid arguments * Convert `periodically :method_name` to Proc callbacks * Drop periodic runner methods from the worker pool * Ensure we clear active periodic timers after shutdown
* Merge pull request #24600 from tomkadwill/action-cabel-channel-typosVipul A M2016-04-183-4/+4
|\ | | | | Fix typos in ActionCable Channel [ci skip]
| * Fix typos in ActionCable Channel [ci skip]Tom Kadwill2016-04-183-4/+4
| |
* | Run Action Cable callbacks through the worker poolSean Griffin2016-04-131-2/+5
|/ | | | | | | | | | Alternate implementation of #24162 with tests. The code had diverged too far on master to pull that implemenation directly. Fixes #23778 Close #24162 [Mattew Draper & Sean Griffin]
* Merge pull request #24224 from danielrhodes/actioncable-websocket-protocolsJeremy Daer2016-04-054-7/+21
|\ | | | | | | ActionCable protocol negotiation
| * Added protocol negotiationDaniel Rhodes2016-04-054-7/+21
| | | | | | | | | | | | | | | | | | This is primarily for backwards compatibility for when or if the protocol is changed in future versions. If the server fails to respond with an acceptable protocol, the client disconnects and disables the monitor.
* | Cable message encodingJeremy Daer2016-03-317-61/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
* | Cable: reconcile default worker pool size with low db conn pool sizeJeremy Daer2016-03-302-2/+12
| | | | | | | | | | | | | | | | | | | | | | Whack it down from 100 to 4. Large worker pools means large db connection counts. We aren't set up for that by default and most apps won't need it out of the box. We're better off tuning the default worker pool for low traffic, low resource consumption apps. Those who have higher traffic will scale up to meet demand.
* | Keep logging in the ActionCable::Channel::BaseRafael Mendonça França2016-03-302-41/+6
| | | | | | | | | | | | To move Action Cable logging to a LoggingSubscriber we need to pass the log tags in the notification payload since Action Cable logging use the Channel instance to tag the logs.
* | Merge pull request #23723 from mwear/action_cable_notificationsRafael Mendonça França2016-03-292-8/+56
|\ \ | | | | | | | | | Add ActiveSupport::Notification to Channel::Base#perform_action
| * | Add AS::Notifications and LogSubscriber to ActionCable::ChannelMatthew Wear2016-03-042-8/+56
| |/ | | | | | | | | This commit adds ActiveSupport::Notifications instrumentation hooks and a LogSuscriber to ActionCable::Channel::Base.
* | Cable: fix Faye periodic timer shutdown typoJeremy Daer2016-03-241-1/+1
| |
* | Gracefully handle disconnected clientsJeremy Daer2016-03-203-1/+4
| | | | | | | | | | | | | | | | We'll get `Errno::ECONNRESET` if the client forcibly disconnected. Just close the socket rather than raising the exception. Handle other errors in `ClientSocket#write`, too, mirroring the Faye error handling which swallows all `StandardError` on write.
* | Evented Redis adapter: log reconnect failures as errors, not just infoJeremy Daer2016-03-171-1/+1
|/ | | | [ci skip]
* Share default mount path with client side .jsJavan Makhmali2016-03-031-1/+1
|
* Merge pull request #23992 from matthewd/em-optionMatthew Draper2016-03-0416-34/+154
|\ | | | | Support faye-websocket + EventMachine as an option
| * Support faye-websocket + EventMachine as an optionMatthew Draper2016-03-0216-34/+154
| |
* | Accept JSON with no backslashes/escapingJon Moss2016-03-021-6/+19
| | | | | | | | | | | | | | Fixes #22675 Allow channel identifiers and also data with no backslahes/escaping to be accepted by the subscription storer.
* | Merge pull request #23976 from danielrhodes/enhancement/ac-ping-to-message-typeMatthew Draper2016-03-021-5/+5
|\ \ | |/ |/| | | ActionCable: Add a "welcome" and "ping" message type
| * Make ping into a message typeDaniel Rhodes2016-03-011-1/+1
| | | | | | | | | | | | | | | | This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work.
| * Added welcome message type and fix test hacksDaniel Rhodes2016-03-011-4/+4
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 04:42:32 +0000