Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Support faye-websocket + EventMachine as an option | Matthew Draper | 2016-03-02 | 7 | -12/+107 | |
| | | ||||||
* | | Accept JSON with no backslashes/escaping | Jon Moss | 2016-03-02 | 1 | -6/+19 | |
| | | | | | | | | | | | | | | Fixes #22675 Allow channel identifiers and also data with no backslahes/escaping to be accepted by the subscription storer. | |||||
* | | Merge pull request #23976 from danielrhodes/enhancement/ac-ping-to-message-type | Matthew Draper | 2016-03-02 | 1 | -5/+5 | |
|\ \ | |/ |/| | | | ActionCable: Add a "welcome" and "ping" message type | |||||
| * | Make ping into a message type | Daniel Rhodes | 2016-03-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work. | |||||
| * | Added welcome message type and fix test hacks | Daniel Rhodes | 2016-03-01 | 1 | -4/+4 | |
| | | ||||||
* | | Use AS::Executor / AS::Reloader to support reloading in ActionCable | Matthew Draper | 2016-03-02 | 1 | -2/+3 | |
|/ | ||||||
* | The async.callback call should live with the hijack | Matthew Draper | 2016-02-26 | 1 | -4/+5 | |
| | | | | If we're deferring one, we should defer the other too. | |||||
* | Only hijack Rack socket when first needed | Jon Moss | 2016-02-24 | 2 | -10/+9 | |
| | | | | Fixes #23471 | |||||
* | Merge pull request #23813 from lifo/faye-websocket | David Heinemeier Hansson | 2016-02-23 | 1 | -1/+8 | |
|\ | | | | | Improve Action Cable reconnection reliability | |||||
| * | Confirm connection monitor subscription on open | Pratik Naik | 2016-02-23 | 1 | -1/+8 | |
| | | ||||||
* | | Merge pull request #23668 from maclover7/cable-docs | Rafael França | 2016-02-22 | 4 | -15/+14 | |
|\ \ | |/ |/| | Full Action Cable documentation read through | |||||
| * | Full Action Cable documentation read through | Jon Moss | 2016-02-17 | 4 | -15/+14 | |
| | | | | | | | | | | | | | | | | | | This PR checks all active Action Cable documentation for typos and other fixes. It aims to make sure that when Rails 5 is released, that the Action Cable docs are up to snuff with the other documentation included with Rails. [ci skip] | |||||
* | | Fix `unsubscribed` server side behavior | Jon Moss | 2016-02-18 | 2 | -6/+3 | |
|/ | | | | | | | | | | | | | Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections. | |||||
* | Fix grammar `a` to `an` [ci skip] | Ryuta Kamizono | 2016-02-13 | 1 | -1/+1 | |
| | ||||||
* | Merge remote-tracking branch 'origin/master' into actioncable_logging | kp | 2016-02-10 | 3 | -26/+50 | |
|\ | ||||||
| * | Handle more IO errors (especially, ECONNRESET) | Matthew Draper | 2016-01-30 | 1 | -21/+47 | |
| | | | | | | | | | | | | Also, address the possibility of the listen thread dying and needing to be respawned. As a bonus, we now defer construction of the thread until we are first given something to monitor. | |||||
| * | Fix arguments to on_close | Matthew Draper | 2016-01-30 | 2 | -5/+3 | |
| | | ||||||
| * | Revert "Revert "Eliminate the EventMachine dependency"" | Matthew Draper | 2016-01-30 | 6 | -22/+315 | |
| | | ||||||
| * | Revert "Eliminate the EventMachine dependency" | David Heinemeier Hansson | 2016-01-27 | 6 | -315/+22 | |
| | | ||||||
* | | Logs successful and invalid connections separately | kp | 2016-02-10 | 1 | -8/+12 | |
| | | ||||||
* | | adds debug logging to actioncable connect | kp | 2016-01-26 | 1 | -2/+12 | |
|/ | ||||||
* | Import the relevant portions of faye-websocket | Matthew Draper | 2016-01-24 | 5 | -20/+313 | |
| | | | | (as adapted to use concurrent-ruby / nio4r instead of eventmachine) | |||||
* | Using a hacked faye-websocket, drop EventMachine | Matthew Draper | 2016-01-24 | 1 | -2/+2 | |
| | ||||||
* | Fix code review comments | Jon Moss | 2016-01-18 | 2 | -3/+3 | |
| | | | | | | | - adapter -> pubsub (re)rename internally - Change variable names to match method names - Add EventMachine `~> 1.0` as a runtime dependency of ActionCable - Refactor dependency loading for adapters | |||||
* | Pull the action methods directly onto the adapter | Matthew Draper | 2016-01-18 | 2 | -3/+3 | |
| | ||||||
* | Adapterize ActionCable storage and extract behavior | Jon Moss | 2016-01-18 | 2 | -7/+7 | |
| | ||||||
* | Revert "Merge pull request #22977 from rails/revert-22934-master" | David Heinemeier Hansson | 2016-01-16 | 1 | -1/+1 | |
| | | | | | This reverts commit d0393fccffc118a5de37654aa222774b66123393, reversing changes made to 3b7ccadfc1c8dfec61af898167e1300b17f5cf25. | |||||
* | [ci skip] Fix typo in docs | DAVID MOORE | 2016-01-15 | 1 | -1/+1 | |
| | | | | | Found this small omission while reviewing the ActionCable docs. [Dave Moore] | |||||
* | Revert "Move async execution from celluloid to concurrent-ruby" | David Heinemeier Hansson | 2016-01-08 | 1 | -1/+1 | |
| | ||||||
* | Move async execution from celluloid to concurrent-ruby | Mike Perham | 2016-01-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | This removes 8 runtime gem dependencies from Rails: ``` Using hitimes 1.2.3 Using timers 4.1.1 Using celluloid-essentials 0.20.5 Using celluloid-extras 0.20.5 Using celluloid-fsm 0.20.5 Using celluloid-pool 0.20.5 Using celluloid-supervision 0.20.5 Using celluloid 0.17.2 ``` | |||||
* | [ActionCable] remove not needed protected call and newlines | Jan Habermann | 2015-12-25 | 2 | -9/+1 | |
| | ||||||
* | Merge pull request #22639 from arunagw/aa-remove-few-warnings-actioncable | Guillermo Iguaran | 2015-12-17 | 4 | -4/+8 | |
|\ | | | | | Remove warnings from actioncable test | |||||
| * | Remove warnings from actioncable | Arun Agrawal | 2015-12-17 | 4 | -4/+8 | |
| | | | | | | | | Warnings coming from code and test are removed | |||||
* | | traditional make sense with `<tt>ActiveSupport::TaggedLogging</tt>` | Gaurav Sharma | 2015-12-18 | 1 | -2/+2 | |
|/ | ||||||
* | Get ready to merge into Rails | David Heinemeier Hansson | 2015-12-14 | 8 | -0/+520 | |