aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib/action_cable/connection/subscriptions.rb
Commit message (Collapse)AuthorAgeFilesLines
* Accept JSON with no backslashes/escapingJon Moss2016-03-021-6/+19
| | | | | | | Fixes #22675 Allow channel identifiers and also data with no backslahes/escaping to be accepted by the subscription storer.
* Merge pull request #23668 from maclover7/cable-docsRafael França2016-02-221-2/+2
|\ | | | | Full Action Cable documentation read through
| * Full Action Cable documentation read throughJon Moss2016-02-171-2/+2
| | | | | | | | | | | | | | | | | | This PR checks all active Action Cable documentation for typos and other fixes. It aims to make sure that when Rails 5 is released, that the Action Cable docs are up to snuff with the other documentation included with Rails. [ci skip]
* | Fix `unsubscribed` server side behaviorJon Moss2016-02-181-1/+1
|/ | | | | | | | | | | | | Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
* [ActionCable] remove not needed protected call and newlinesJan Habermann2015-12-251-1/+0
|
* Remove warnings from actioncableArun Agrawal2015-12-171-1/+2
| | | | Warnings coming from code and test are removed
* Get ready to merge into RailsDavid Heinemeier Hansson2015-12-141-0/+75