aboutsummaryrefslogtreecommitdiffstats
path: root/actioncable/lib/action_cable/channel/base.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use frozen string literal in actioncable/Kir Shatrov2017-07-231-1/+1
|
* Make actioncable ready for frozen stringsKir Shatrov2017-07-231-1/+5
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Move some ActionCable logs to debug levelMartijn Storck2017-02-061-1/+1
|
* Privatize unneededly protected methods in Action CableAkira Matsuda2016-12-241-14/+13
|
* Add Channel#ensure_confirmation_sent; call #subscribe_to_channel after ↵palkan2016-09-221-23/+19
| | | | initializing
* [Fix #25381] Avoid race condition on subscription confirmationpalkan2016-09-201-8/+18
|
* Prevent invocation of channel action if rejected connectionJon Moss2016-08-191-1/+1
| | | | | | | | | Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
|
* applies new string literal convention in actioncable/libXavier Noria2016-08-061-3/+3
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Cable message encodingJeremy Daer2016-03-311-3/+3
| | | | | | | | | | | | | | | | | | | * Introduce a connection coder responsible for encoding Cable messages as WebSocket messages, defaulting to `ActiveSupport::JSON` and duck- typing to any object responding to `#encode` and `#decode`. * Consolidate encoding responsibility to the connection. No longer explicitly JSON-encode from channels or other sources. Pass Cable messages as Hashes to `#transmit` and rely on it to encode. * Introduce stream encoders responsible for decoding pubsub messages. Preserve the currently raw encoding, but make it easy to use JSON. Same duck type as the connection encoder. * Revert recent data normalization/quoting (#23649) which treated `identifier` and `data` values as nested JSON objects rather than as opaque JSON-encoded strings. That dealt us an awkward hand where we'd decode JSON strings… or not, but always encode as JSON. Embedding JSON object values directly is preferably, no extra JSON encoding, but that should be a purposeful protocol version change rather than ambiguously, inadvertently supporting multiple message formats.
* Keep logging in the ActionCable::Channel::BaseRafael Mendonça França2016-03-301-1/+6
| | | | | | To move Action Cable logging to a LoggingSubscriber we need to pass the log tags in the notification payload since Action Cable logging use the Channel instance to tag the logs.
* Add AS::Notifications and LogSubscriber to ActionCable::ChannelMatthew Wear2016-03-041-8/+16
| | | | | This commit adds ActiveSupport::Notifications instrumentation hooks and a LogSuscriber to ActionCable::Channel::Base.
* Add small Action Cable documentation fixesHayley Anderson2016-02-271-1/+1
| | | | | * Fix typos/grammar errors * Make capitalization/naming consistent
* Merge pull request #23668 from maclover7/cable-docsRafael França2016-02-221-10/+8
|\ | | | | Full Action Cable documentation read through
| * Full Action Cable documentation read throughJon Moss2016-02-171-10/+8
| | | | | | | | | | | | | | | | | | This PR checks all active Action Cable documentation for typos and other fixes. It aims to make sure that when Rails 5 is released, that the Action Cable docs are up to snuff with the other documentation included with Rails. [ci skip]
* | Truncate ActionCable broadcast message to 300 charsJankees van Woezik2016-02-181-1/+1
|/ | | | | | When running the ActionCable server in development I get a lot of output in my logs, this commit sets a maximum length of 300 characters for a broadcast log message.
* [ci skip] Several ActionCable documentation updates:Nick Quaranto2016-02-021-12/+21
| | | | | | | | * Properly indent code sample in ActionCable::Channel::Streams * Add a doc comment for #stop_all_streams * Reformat + add <tt> blocks around code references in ActionCable::Base docs * Clarify and a little better grammar on ActionCable::RemoteConnections * Correct indentation and clean up ActionCable::Server::Broadcasting code sample
* Adapterize ActionCable storage and extract behaviorJon Moss2016-01-181-2/+2
|
* [ci skip] Fix typoAkshay Vishnoi2015-12-181-1/+1
|
* Remove warnings from actioncableArun Agrawal2015-12-171-0/+3
| | | | Warnings coming from code and test are removed
* Get ready to merge into RailsDavid Heinemeier Hansson2015-12-141-0/+274
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 06:01:18 +0000