Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | ActionCable should not raise when a connection is already open | Duncan Grazier | 2017-01-06 | 1 | -1/+1 |
| | | | | | | | | | | | ActionCable was throwing a "Existing connection must be closed before opening" exception which was being picked up as a production issue in our error monitoring software. Since this happens pretty often on any device that allows the browser to sleep (mobile) this error was getting triggered often. This change removes the exception, but keeps logging the occurrence. We now return `false` to let the caller now that `open` failed. | ||||
* | Add configuration for `WebSocket` and `logger` | Jon Moss | 2016-05-31 | 1 | -1/+1 |
| | | | | [Javan Makhmali, Jon Moss] | ||||
* | Cable typo: isSupportedProtocol -> isProtocolSupported | Jeremy Daer | 2016-04-05 | 1 | -1/+1 |
| | |||||
* | Merge pull request #24224 from danielrhodes/actioncable-websocket-protocols | Jeremy Daer | 2016-04-05 | 3 | -16/+50 |
|\ | | | | | | | ActionCable protocol negotiation | ||||
| * | Added protocol negotiation | Daniel Rhodes | 2016-04-05 | 3 | -16/+50 |
| | | | | | | | | | | | | | | | | | | This is primarily for backwards compatibility for when or if the protocol is changed in future versions. If the server fails to respond with an acceptable protocol, the client disconnects and disables the monitor. | ||||
* | | Fix WebSocket already open log message typo | Jon Evans | 2016-03-22 | 1 | -1/+1 |
|/ | |||||
* | Return subscription object(s) when updating the collection | Javan Makhmali | 2016-03-04 | 1 | -3/+4 |
| | |||||
* | Make sure ActionCable.Subscriptions#create always returns the newly created ↵ | Pratik Naik | 2016-03-04 | 1 | -0/+2 |
| | | | | subscription object | ||||
* | Store reference to Subscriptions instance for convenience | Javan Makhmali | 2016-03-03 | 1 | -5/+6 |
| | |||||
* | Implicity add Subscription instance to subscriptions collection | Javan Makhmali | 2016-03-03 | 2 | -13/+12 |
| | |||||
* | Defer starting connection monitor until a connection is opened | Javan Makhmali | 2016-03-03 | 3 | -41/+52 |
| | |||||
* | Establish WebSocket connection when first subscription is created. Fixes #24026 | Javan Makhmali | 2016-03-03 | 3 | -9/+10 |
| | | | | | * More intention revealing than connecting on the first call to Connection#send * Fixes that calls to Connection#send would attempt to open a connection when the WebSocket's state is CONNECTING | ||||
* | ConnectionMonitor is once again notified of disconnect | Daniel Rhodes | 2016-03-03 | 2 | -0/+2 |
| | |||||
* | Make ping into a message type | Daniel Rhodes | 2016-03-01 | 3 | -10/+7 |
| | | | | | | | | This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work. | ||||
* | Added welcome message type and fix test hacks | Daniel Rhodes | 2016-03-01 | 1 | -0/+2 |
| | |||||
* | Only open Action Cable connection if data is being sent | Jon Moss | 2016-02-24 | 1 | -1/+3 |
| | |||||
* | Fix isAlive condition and add more logging | Javan Makhmali | 2016-02-23 | 1 | -5/+7 |
| | |||||
* | ActionCable.log | Javan Makhmali | 2016-02-23 | 2 | -14/+14 |
| | |||||
* | Uninstall event handlers when replacing WebSocket instance | Javan Makhmali | 2016-02-23 | 1 | -0/+6 |
| | | | | Ensures we don't get "onclose" events from a previous WebSocket that was in the "closing" state | ||||
* | Connection#isAlive | Javan Makhmali | 2016-02-23 | 1 | -3/+3 |
| | |||||
* | Log ConnectionMonitor connect | Pratik Naik | 2016-02-23 | 1 | -0/+1 |
| | |||||
* | Treat 'closing' state as closed. | Pratik Naik | 2016-02-23 | 1 | -3/+6 |
| | | | | | | We are seeing cases where the websockets get stuck in the 'closing' state after a tab has been in background for a while. So lets treat those websockets as closed. | ||||
* | Add client-side console logging to help debug reconnect issues | Javan Makhmali | 2016-02-23 | 2 | -1/+15 |
| | |||||
* | Wrangle the asset build into something that sounds more general | Matthew Draper | 2016-02-01 | 7 | -24/+0 |
| | |||||
* | Improvements and reorganization of assets | Jon Moss | 2016-01-30 | 7 | -0/+341 |