| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Use the methods rack provides so we don't have to worry about the exact
header key.
|
|
|
|
|
| |
Rack implements the Etag header manipulation methods, so we can use
those instead of ours.
|
|
|
|
|
|
|
| |
* Introduce `ActionDispatch::Http::Headers#add` to add a value to
a multivalued header.
* Move `Response#add_header` upstream: https://github.com/rack/rack/pull/957
* Match upstream `Response#have_header?` -> `#has_header?` name change.
|
|
|
|
| |
fixes for warnings and circular require
|
| |
|
|
|
|
|
| |
Bumped version of concurrent-ruby to 1.0.0.pre3, which fixes all
interpreter warnings.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* Move `app/assets/manifest.js` to `app/assets/config/manifest.js`.
Avoid the suggestion that you can/should deep-link `stylesheets/foo`.
* Pull in all toplevel stylesheets and JavaScripts, not just
`application.js` and `.css`. Demonstrate how to use `link_directory`
with a specified `.js`/`.css` type.
* Fix RAILS_ENV handling in assets tests.
* Shush warnings spam from third-party libs that distract from tests.
|
| |
|
|
|
|
|
| |
Since `alias_method_chain` is deprecated we need to use the master version
of the Turbolinks gem as it has support for using `Module#prepend`.
|
|
|
|
|
|
|
| |
The thread_safe gem is being deprecated and all its code has been merged
into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly
the same as its predecessor except for fixes to two bugs discovered
during the merge.
|
|
|
|
| |
This will make the Gemfile.lock be dirty in some environments
|
|
|
|
| |
having correct pre-compiled so
|
| |
|
|
|
|
| |
Known failure on Ruby 2.3/trunk: brianmario/mysql2#671
|
| |
|
|
|
|
|
|
| |
Just include the modules necessary in the Request object to implement
the things we need. This should make it easier to build delegate
request objects because the API is smaller
|
|
|
|
|
|
| |
Escaping and unescaping paths is different than query parameters, and we
need to respect that. This commit uses the new method in Rack to escape
and unescape paths. Fixes #11816
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/rails/rails/commit/4d157ea8c15186c4903fa83f2dc51a5f78d13a37
Without any specification about the version of sprockets-rails, running a
`bundle install` on a brand new app might result in sprockets 0.0.1 being
installed.
However, the minimum requirement is sprockets-rails 2 (see https://github.com/rails/rails/pull/17752/files)
|
| |
|
| |
|
|
|
|
| |
eventually we will refactor this to not know about header hashes
|
| |
|
|
|
|
|
| |
This commit allows us to use one request object rather than allocating
multiple request objects to deal with the session.
|
|
|
|
| |
duping the request will dup it's underlying env hash.
|
| |
|
| |
|
|\
| |
| | |
Add method_source dependency to activesupport
|
| | |
|
| |
| |
| |
| |
| |
| | |
The latest, currently unreleased, version of queue_classic is required
for this to work. See
https://github.com/QueueClassic/queue_classic/pull/262 for more details.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The concurrent-ruby gem is a toolset containing many concurrency
utilities. Many of these utilities include runtime-specific
optimizations when possible. Rather than clutter the Rails codebase with
concurrency utilities separate from the core task, such tools can be
superseded by similar tools in the more specialized gem. This commit
replaces `ActiveSupport::Concurrency::Latch` with
`Concurrent::CountDownLatch`, which is functionally equivalent.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our general contract in Active Record is that strings are assumed to be
SQL literals, and symbols are assumed to reference a column. If a from
clause is given, we shouldn't include the table name, but we should
still quote the value as if it were a column.
Upon fixing this, the tests were still failing on SQLite. This was
because the column name being returned by the query was `"\"join\""`
instead of `"join"`. This is actually a bug in SQLite that was fixed a
long time ago, but I was using the version of SQLite included by OS X
which has this bug. Since I'm guessing this will be a common case for
contributors, I also added an explicit check with a more helpful error
message.
Fixes #20360
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
History:
1. `debugger` was there until d2ed433b where it was commented out, and I
couldn't figure out why
2. Since then we inherited that when switching to `byebug` in 93559da4
Reasons:
1. It's nice to have a debugger when working on framework bugs
2. It's an uncommented dependency in app Gemfiles since Rails 4.2 (see fbe38c9e)
|
|
|
|
|
|
|
| |
Related: #19617, #19187, #19533, #19689, #19675.
This is POC (Proof Of Concept) which bundler does not remove mingw lines.
https://github.com/rails/rails/pull/19617#issuecomment-90293795
|
|
|
|
| |
see: http://www.openwall.com/lists/oss-security/2015/04/07/11
|
|
|
|
|
|
|
|
|
|
| |
Since we now only support Ruby 2.2+, we can safely remove the old mri
entries from the Gemfile.
This also allows us not to lock to a specific bundler version, since
:mri_22 was defined only on 1.7.11.
Closes #19611.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Prevents double escaping errors, such as "&" becoming "&".
|