| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
For test with latest thor.
|
|
|
|
| |
thor 0.20.0 was released so we can test with the released version.
|
|
|
|
|
| |
No need to depend on my fork anymore, they've just release fix
officially.
|
|
|
|
|
|
|
|
|
|
|
|
| |
```
% be rubocop -a --only Style/StringLiterals activestorage
Inspecting 74 files
........................................CCCCCCCCCC.C........CC.......C.C..
(snip)
74 files inspected, 31 offenses detected, 31 offenses corrected
```
|
|\ |
|
| |\ |
|
| | | |
|
| |\ \ |
|
| |\ \ \ |
|
| |\ \ \ \ |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
"httparty" is only added in #30020 to write two tests to make PUT requests
against S3 and GCS.
The same requests can be made with net/http, removing a dependency from the Gemfile.
|
| |_|_|_|/
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update Gemfile.lock to reflect arel 9.0.0.alpha
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Follow up to 089ca52.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Suppress deprecated warning in Action Cable
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
`bind_values` was removed from Arel
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Update rack-test dependency constraint
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix warnings in railties tests
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
This warning has been fixed in sass-rails. This change picks up the fix.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A common source of bugs and code bloat within Active Record has been the
need for us to maintain the list of bind values separately from the AST
they're associated with. This makes any sort of AST manipulation
incredibly difficult, as any time we want to potentially insert or
remove an AST node, we need to traverse the entire tree to find where
the associated bind parameters are.
With this change, the bind parameters now live on the AST directly.
Active Record does not need to know or care about them until the final
AST traversal for SQL construction. Rather than returning just the SQL,
the Arel collector will now return both the SQL and the bind parameters.
At this point the connection adapter will have all the values that it
had before.
A bit of this code is janky and something I'd like to refactor later. In
particular, I don't like how we're handling associations in the
predicate builder, the special casing of `StatementCache::Substitute` in
`QueryAttribute`, or generally how we're handling bind value replacement
in the statement cache when prepared statements are disabled.
This also mostly reverts #26378, as it moved all the code into a
location that I wanted to delete.
/cc @metaskills @yahonda, this change will affect the adapters
Fixes #29766.
Fixes #29804.
Fixes #26541.
Close #28539.
Close #24769.
Close #26468.
Close #26202.
There are probably other issues/PRs that can be closed because of this
commit, but that's all I could find on the first few pages.
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
Bootsnap precomputes load path resolution and caches ruby ISeq
and YAML parsing/compilation, reducing application boot time by
approximately 50% on supported configurations.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Improves the performance from O(n) to O(1).
Previously it would require 50 queries to
insert 50 fixtures. Now it takes only one query.
Disabled on sqlite which doesn't support multiple inserts.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Fixes FIXME: rb-inotify 0.99 has been released
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | | |
Ref: https://github.com/teamcapybara/capybara/pull/1868
|
| |_|/
|/| | |
|
|\ \ \
| | | |
| | | | |
Remove requirement on mathn
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The test using mathn was first introduced in f1d9179 to check that the
`distance_of_time_in_words` properly doesn't use the `Fixnum#/` method
by explicitly requiring this library as it redefines this method.
Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since
version 2.2, we can certainly safely assume that people will most-likely
not require this library in their application.
However, to make sure that we don't regress, let's add a test similar to
the one before f1d9179.
|
| |_|/
|/| | |
|
| | | |
|
| | |
| | |
| | |
| | | |
https://github.com/guard/rb-inotify/pull/49 has been merged.
|
|/ / |
|
| |
| |
| |
| | |
see: https://github.com/mperham/sidekiq/blob/master/5.0-Upgrade.md
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Capybara 2.14.0 was released. Loosen the tight constraint in the
generated Gemfile, so that Rails applications can take advantage of the
new version
|
| |
| |
| |
| |
| |
| | |
The argument of `Arel::SelectManager.new` is `table`, not `engine`.
https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
|
|/
|
|
| |
Follow up #28733 and brianmario/mysql2#840
|
|
|
|
|
| |
This will allow me to push a release, including bug fixes,
without having to update Rails everytime.
|
|
|
|
|
| |
Closes #28382
Closes #28651
|
| |
|