| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ /
| |
| |
| |
| | |
The comment was describing a previous version of the method with
a different signature. This is outdated since e76c38e
|
|\ \
| | |
| | | |
`module ActiveStorage`, not `ActiveStorage::Class`
|
| |\ \
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Use `content_type.start_with?("...")` than `content_type =~ /^.../`
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`start_with?` is a little faster than regexp for prefix matching by a
fixed string.
|
|\ \ \ \
| | | | |
| | | | | |
Fix ruby warnings
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This fixes following warnings:
```
test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator
lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized
lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized
```
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
By default, apps only have the former set.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add missing blank line between `config.active_storage` and `config.action_cable`
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
koic/change_gem_version_of_active_storage_to_5_2_0
Change gem version of Active Storage to 5.2.0.alpha
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove unnecessary variable
|
|/ / / / / |
|
|/ / / /
| | | |
| | | |
| | | | |
It was right as originally written in #15440.
|
|\ \ \ \
| |/ / /
|/| | | |
Fix repository URL [ci skip]
|
|/ / /
| | |
| | |
| | | |
changed `rails/activestorage` to `rails/rails`.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The reasons for this commit are:
- uniformity with the other Rails libraries
- (possibly) behave better with respect to autoloading
- fix the index in the generated documentation
Before this commit, run `rake rdoc` generates this left sidebar
(ActiveStorage entries are indexed twice, both inside and outside the module):
<img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png">
After this commit, run `rake rdoc` generates this left sidebar:
(ActiveStorage entries are only indexed inside the module):
<img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
|
|\ \
| | |
| | | |
Add Active Storage to Rails
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical
URL for an object will start with "https://s3.amazonaws.com/bucket.name/"
and not with "https://bucket.name.s3.amazonaws.com/".
The URL tests have now been separated into two separate asserts, to ensure
that both the "s3.amazonaws.com" and the "bucket.name" components are included,
but not specifically in that order.
|
| | |
| | |
| | | |
Before we forget...
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The test was passing before because it was not being testes correctly.
Now we create a different engine that is loaded before the already
exising and we make sure that the first call for isolate_namespace is
what takes effect.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
What we want to test is that two different calls to isolate_namespace
with the same module doesn't change the original railtie. We can do that
defining two different railties.
We can't call in the application because this method is not supposed to
be called in an Application class.
|
| | |
| | |
| | |
| | | |
And deal with a temporary test fix until we allow you to skip active storage.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
We are already removing the braces around hash parameters in the last
argument in other places so we should not change the entire codebase
because of two places.
|
| |\ \
| | | |
| | | | |
Change azure core dependency
|
| | | |
| | | |
| | | |
| | | |
| | | | |
No need to depend on my fork anymore, they've just release fix
officially.
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
Make Rubocop happy about ActiveStorage
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Running `rubocop activestorage` before this commit resulted in 20 offenses.
This commit only fixes:
- Trailing whitespace detected
- Space inside } missing
- Put one space between the method name and the first argument.
The other offenses are left since they are intentional according to
@georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | | |
active-storage-import
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
FormHelper includes FormTagHelper so we don't need to define two methods
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Also make sure file_field doesn't mutate the original options passed in.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When Active Storage is not loaded and direct_upload is used on
file_field_tag we should not raise an exception.
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
|
| | | | |
| | | | |
| | | | |
| | | | | |
cc @rafaelfranca
|
| | | | | |
|
| | | | | |
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
I know those methods are unlikely to change but having one line method
is hard to read and also hard to modify.
|
| | | | |
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| | |
Add Azure gems to README
|
| | | |
| | | |
| | | | |
Omit azure-core (it's required by azure-storage), remove require:false to match other points.
|
| | | | |
|