rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| \| * \| \| \| \|	Renamed: HTMLSelector css_selector to selector.	Timm	2014-06-16	1	-7/+7
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Removed unnecessary lines from HTMLSelector initialize.	Timm	2014-06-16	1	-3/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Changed: put selector extraction into selector_from, which is renamed to ↵	Timm	2014-06-16	1	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	extract_selector.
\| \| * \| \| \| \|	Changed: HTMLSelector comparisons renamed to equality_tests.	Timm	2014-06-16	1	-9/+6
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Changed: removed @selected and @page variables from HTMLSelector since one ↵	Timm	2014-06-16	1	-10/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	method used them. Passed the values directly to there instead.
\| \| * \| \| \| \|	Changed: return early from compare_doms if the two doms don't have the same ↵	Timm	2014-06-16	1	-0/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	number of children.
\| \| * \| \| \| \|	Renamed: remove_xpaths tests no longer prefixed with sanitizer.	Timm	2014-06-16	1	-6/+6
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Changed: remove_xpaths called with String returns String, while called with ↵	Timm	2014-06-16	2	-2/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Loofah fragment returns Loofah fragment. Added tests for this.
\| \| * \| \| \| \|	Fixed: spelling mistake in SanitizeHelperTest.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Removed duplication in assert_dom_equal and assert_dom_not_equal.	Timm	2014-06-16	1	-9/+6
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Changed wording of missing selector argument exception message in css_select.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Reworked root and selector conditional assignment in css_select.	Timm	2014-06-16	1	-5/+2
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Added related Nokogiri issue link to tests that fail with unknown encoding ↵	Timm	2014-06-16	2	-6/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ASCII-8BIT.
\| \| * \| \| \| \|	Moved Action Pack changelog message to Action View. Clarified Dom and ↵	Timm	2014-06-16	1	-0/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Selector assertions changes in there.
\| \| * \| \| \| \|	Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Removed :nodoc: from PermitScrubber.	Timm	2014-06-16	1	-1/+0
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Reworked documentation for PermitScrubber and TargetScrubber.	Timm	2014-06-16	1	-2/+33
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Fixed: spelling error.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Initialized tags and attributes to nil.	Timm	2014-06-16	1	-0/+4
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Refactored scrub to keep_node? instead of scrub_node calling it. Also added ↵	Timm	2014-06-16	1	-6/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ability to stop traversing by returning STOP from scrub_node.
\| \| * \| \| \| \|	Changed PermitScrubber to be even more extensible. Updated TargetScrubber to ↵	Timm	2014-06-16	1	-39/+40
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	be compliant. Updated documentation for PermitScrubber and TargetScrubber for clarity.
\| \| * \| \| \| \|	Changed PermitScrubbers documentation to list override points for ↵	Timm	2014-06-16	1	-12/+15
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	subclasses. Renamed should_remove_attributes? to should_scrub_attributes?.
\| \| * \| \| \| \|	Already killed off LinkScrubber. Changed it instead to be TargetScrubber, ↵	Timm	2014-06-16	2	-9/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	which is more general, while still allowing maximum code reuse.
\| \| * \| \| \| \|	Added LinkScrubber to remove duplication in LinkSanitizer. As such made ↵	Timm	2014-06-16	2	-11/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	PermitScrubber easier to subclass.
\| \| * \| \| \| \|	Changed FullSanitizer sanitize to use tap method instead of temporary variable.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Extracted the common xpaths to remove into XPATHS_TO_REMOVE.	Timm	2014-06-16	1	-2/+4
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Refactored remove_xpaths to use duck typing and read better.	Timm	2014-06-16	1	-4/+5
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Changed explanation for no duck typing of custom scrubbers.	Timm	2014-06-16	1	-1/+2
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Added correct requires in html-scanner tests. Sanitizers are not based on ↵	Timm	2014-06-16	7	-330/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	html-scanner anymore, so sanitizer_test.rb is removed.
\| \| * \| \| \| \|	Require ActionView::Assertions in ActionController test_case.rb.	Timm	2014-06-16	1	-0/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Marked test_feed_xhtml as pending. See description in the test.	Timm	2014-06-16	1	-0/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Removed copyright notice since we aren't relying on html-scanner anymore.	Timm	2014-06-16	1	-5/+0
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Removed require for active_support/core_ext/object/inclusion since in? isn't ↵	Timm	2014-06-16	1	-2/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	used anywhere.
\| \| * \| \| \| \|	Moved Dom and Selector assertions from ActionDispatch to ActionView.	Timm	2014-06-16	11	-545/+557
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Fixed: assert_select_encoded finds the right content. No longer uses a ↵	Timm	2014-06-16	2	-14/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	<encoded> wrapper. Updated tests to reflect this.
\| \| * \| \| \| \|	Removed mention of css_select supporting substitution values. It is not ↵	Timm	2014-06-16	1	-7/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tested anywhere.
\| \| * \| \| \| \|	Updated documentation to state more things about css selectors with ↵	Timm	2014-06-16	1	-3/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	substitution values.
\| \| * \| \| \| \|	Reworked the wrapping root in NodeSet implementation in css_select.	Timm	2014-06-16	1	-3/+5
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Wrapped element to search in NodeSet. Changed selectors to selector.	Timm	2014-06-16	1	-3/+5
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Moved around alias line.	Timm	2014-06-16	1	-2/+2
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Returning from filter if matches are empty.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Fixed: no longer wrapped @selected in fragment, since .css works fine ↵	Timm	2014-06-16	1	-2/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	without it.
\| \| * \| \| \| \|	Reverted to using documents instead of document fragments, since searching ↵	Timm	2014-06-16	1	-3/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	via default xml namespaces didn't work.
\| \| * \| \| \| \|	add_regex returns inspected value for non Regexp objects. Workaround, so ↵	Timm	2014-06-16	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	users don't have to care about enclosing values in double quotes.
\| \| * \| \| \| \|	Added test case for non-comment. Removed pending assertion that passed.	Timm	2014-06-16	1	-3/+3
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Fixed: test_nested_assert_select selects from elements instead of ↵	Timm	2014-06-16	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	elements[0] and elements[1].
\| \| * \| \| \| \|	Fixed: inadvertently called message method in MiniTest instead of ↵	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	selector.message.
\| \| * \| \| \| \|	Cleaned up SubstitutionContext class.	Timm	2014-06-16	1	-10/+8
\| \| \| \| \| \| \|
\| \| * \| \| \| \|	Simplified assert_select further by moving match filtering into HTMLSelector ↵	Timm	2014-06-16	1	-32/+29
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	select.
\| \| * \| \| \| \|	Fixed: now only compares html of children in filter_matches.	Timm	2014-06-16	1	-1/+1
\| \| \| \| \| \| \|