aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [ci skip] Add ImageMagick to BrewfileMr. Outis2018-08-211-0/+1
| | | | In order to run ActiveStorage's tests successfully, you need imagemagick
* Show the `ENV` value correctly in the doc of `combined_fragment_cache_key` ↵yuuji.yaginuma2018-08-221-1/+1
| | | | | | | [ci skip] It seems to need an escape for the showing `ENV`. https://api.rubyonrails.org/classes/AbstractController/Caching/Fragments.html#method-i-combined_fragment_cache_key
* Add missing newline [ci skip]George Claghorn2018-08-211-0/+1
|
* Merge pull request #33680 from mroutis/update-guides-activestorage-dependenciesGeorge Claghorn2018-08-211-1/+13
|\ | | | | [ci skip] Add ImageMagick to ActiveStorage dependencies
| * [ci skip] Add ImageMagick to ActiveStorage dependenciesMr. Outis2018-08-211-1/+13
|/ | | | | In order to run ActiveStorage's tests successfully, you need imagemagick.
* Merge pull request #29838 from fschwahn/patch-1Rafael França2018-08-212-0/+16
|\ | | | | Add usage of procs without arguments to callbacks guide
| * Improve documentation of Procs as :if / :unless options for callbacksFabian Schwahn2018-08-202-0/+16
| |
* | Merge pull request #33660 from y-yagi/follow_up_32121Richard Schneeman2018-08-214-0/+58
|\ \ | | | | | | Make `rake routes` deprecate before deleting
| * | Make `rake routes` deprecate before deletingyuuji.yaginuma2018-08-204-0/+58
| | | | | | | | | | | | | | | | | | | | | `rake routes` was a public task. Therefore, I think that we should deprecate it before deleting it. Related to #32121.
* | | Merge pull request #33635 from bogdanvlviv/improve-active_job-test_helpersJeremy Daer2018-08-204-61/+726
|\ \ \ | | | | | | | | Improve Active Job test helpers
| * | | DRY in `assert_enqueued_jobs`bogdanvlviv2018-08-201-2/+6
| | | |
| * | | Fix formatting of `ActiveJob::TestHelper` api docsbogdanvlviv2018-08-201-4/+4
| | | |
| * | | Allow `assert_performed_with` to be called without a block.bogdanvlviv2018-08-203-14/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: ``` def test_assert_performed_with MyJob.perform_later(1,2,3) perform_enqueued_jobs assert_performed_with(job: MyJob, args: [1,2,3], queue: 'high') end ``` Follow up #33626.
| * | | Fix `assert_performed_jobs` and `assert_no_performed_jobs`bogdanvlviv2018-08-203-24/+289
| | | | | | | | | | | | | | | | | | | | Execution of `assert_performed_jobs`, and `assert_no_performed_jobs` without a block should respect passed `:except`, `:only`, and `:queue` options.
| * | | Add changelog entry about adding `:queue` option to job assertions and helpersbogdanvlviv2018-08-201-13/+4
| | | | | | | | | | | | | | | | | | | | Note that it removes changelog entry of #33265 since the entry in this commits includes that too.
| * | | Allow `:queue` option to `assert_no_performed_jobs`.bogdanvlviv2018-08-202-2/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `:queue` option is specified, then only the job(s) enqueued to a specific queue will not be performed. Example: ``` def test_assert_no_performed_jobs_with_queue_option assert_no_performed_jobs queue: :some_queue do HelloJob.set(queue: :other_queue).perform_later("jeremy") end end ```
| * | | Allow `:queue` option to `assert_performed_jobs`.bogdanvlviv2018-08-202-2/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `:queue` option is specified, then only the job(s) enqueued to a specific queue will be performed. Example: ``` def test_assert_performed_jobs_with_queue_option assert_performed_jobs 1, queue: :some_queue do HelloJob.set(queue: :some_queue).perform_later("jeremy") HelloJob.set(queue: :other_queue).perform_later("bogdan") end end ```
| * | | Fix `perform_enqueued_jobs`bogdanvlviv2018-08-201-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set ```` queue_adapter.perform_enqueued_jobs = true queue_adapter.perform_enqueued_at_jobs = true queue_adapter.filter = only queue_adapter.reject = except queue_adapter.queue = queue ``` if block given. Execution of `flush_enqueued_jobs` doesn't require that.
| * | | Allow `:queue` option to `perform_enqueued_jobs`.bogdanvlviv2018-08-203-12/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `:queue` option is specified, then only the job(s) enqueued to a specific queue will be performed. Example: ``` def test_perform_enqueued_jobs_with_queue perform_enqueued_jobs queue: :some_queue do MyJob.set(queue: :some_queue).perform_later(1, 2, 3) # will be performed HelloJob.set(queue: :other_queue).perform_later(1, 2, 3) # will not be performed end assert_performed_jobs 1 end ``` Follow up #33265 [bogdanvlviv & Jeremy Daer]
* | | | Fix merging relation that order including `?`Ryuta Kamizono2018-08-212-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `Relation::Merger` has a problem that order values would be merged as nested array. That was caused an issue #33664 since if array value is passed to `order` and first element in the array includes `?`, the array is regarded as a prepared statement and bind variables. https://api.rubyonrails.org/classes/ActiveRecord/Sanitization/ClassMethods.html#method-i-sanitize_sql_for_order Just merging that as splat args like other values would fix the issue. Fixes #33664.
* | | | Merge pull request #33662 from yskkin/multi_word_routeRyuta Kamizono2018-08-202-23/+65
|\ \ \ \ | | | | | | | | | | Fix `rails routes -c` for controller name consists of multiple word.
| * | | | Fix `rails routes -c` for controller name consists of multiple word.Yoshiyuki Kinjo2018-08-202-23/+65
| | |_|/ | |/| |
* | | | Merge pull request #33652 from tgxworld/improve_tests_pool_configRyuta Kamizono2018-08-202-5/+50
|\ \ \ \ | |/ / / |/| | | Improve tests for ActiveRecord::ConnectionAdapters::ConnectionPool co…
| * | | Speed up slow ConnectionPool test case.Guo Xiang Tan2018-08-201-11/+19
| | | |
| * | | Improve tests for ActiveRecord::ConnectionAdapters::ConnectionPool ↵Guo Xiang Tan2018-08-192-2/+39
| | | | | | | | | | | | | | | | configurations.
* | | | Merge pull request #31132 from ↵Ryuta Kamizono2018-08-202-0/+10
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | emaxi/feature/add-missing-documentation-option-to-number-to-currency Add missing documentation option to number_to_currency [ci skip]
| * | | Add missing documentation options to number_to_currency [ci skip]emaxi2018-07-112-0/+10
| | | |
* | | | Merge pull request #33621 from sikachu/sikachu-guide-rubocopRichard Schneeman2018-08-191-2/+13
|\ \ \ \ | |_|_|/ |/| | | Update guide to mention code linters available
| * | | Update guide to mention code linters availablePrem Sichanugrist2018-08-151-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Contributors can run RuboCop locally to catch code style error in Ruby code and npm lint task for `rails-ujs` CoffeeScript and JavaScript code. [skip ci]
* | | | Don't put up with not saying it.Kasper Timm Hansen2018-08-191-1/+1
| | | | | | | | | | | | | | | | Commands generally prefer say to puts.
* | | | Merge pull request #33657 from jychen7/fix-test-association-enumRyuta Kamizono2018-08-201-0/+3
|\ \ \ \ | | | | | | | | | | Improve test case to test enum correctly
| * | | | Improve test case to test enum correctlyRich2018-08-201-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | without define the enum in class “SpecialBook”, any string status will be casted to integer 0. Then the test have no meaning. [Rich Chen]
* | | | | Merge pull request #33631 from anniecodes/initializers-commandKasper Timm Hansen2018-08-195-4/+100
|\ \ \ \ \ | | | | | | | | | | | | Move the initializers rake task to Rails::Command
| * | | | | Update 'rake initializers' to use Rails::Command under the hoodAnnie-Claude Côté2018-08-162-4/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Invoke Rails::Command within the rake task * Adds test for calling initializers with 'bin/rake' * Adds deprecation warning to the rake task
| * | | | | Move 'rails initializers' command to Rails::CommandAnnie-Claude Côté2018-08-162-0/+48
| | | | | |
| * | | | | [ci skip] Add deprecration of to CHANGELOGAnnie-Claude Côté2018-08-161-0/+4
| | | | | |
* | | | | | Merge pull request #33656 from bogdanvlviv/follow-up-33413Kasper Timm Hansen2018-08-191-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | activestorage: yarn build
| * | | | | | activestorage: yarn buildbogdanvlviv2018-08-191-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Context https://github.com/rails/rails/pull/33413#issuecomment-414137587
* | | | | | | SQLite3: Fix rename reference column not to lose foreign key constraintRyuta Kamizono2018-08-202-11/+31
| |_|/ / / / |/| | | | | | | | | | | | | | | | | Fixes #33520.
* | | | | | Merge pull request #33655 from bogdanvlviv/follow-up-33653Ryuta Kamizono2018-08-201-16/+0
|\ \ \ \ \ \ | |/ / / / / |/| | | | | DRY in Active Record Query Interface [ci skip]
| * | | | | DRY in Active Record Query Interface [ci skip]bogdanvlviv2018-08-191-16/+0
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sentence "This is exactly the same as defining a class method ..." is not true, so #33653 fixed it, but added changes repeat what is explained a few lines below. We can remove this part since a user is able to get info about the difference between scopes and class methods below. Context https://github.com/rails/rails/pull/33653#discussion_r211105969. Reverts #33653, 97feb4996b1c88f770101dfce6d4d3a6baf6bb33.
* | | | | Fix syntax error in the doc [ci skip]Ryuta Kamizono2018-08-191-1/+1
| | | | |
* | | | | Merge pull request #33653 from LemonAndroid/patch-1Richard Schneeman2018-08-191-3/+9
|\ \ \ \ \ | | | | | | | | | | | | Explained difference between scope & class method
| * | | | | Explained difference between scope & class methodLemonAndroid2018-08-191-3/+9
| | |_|_|/ | |/| | |
* | | | | Update `google-cloud-storage` gem version [ci skip]yuuji.yaginuma2018-08-191-1/+1
| | | | | | | | | | | | | | | | | | | | Now requires version 1.11 or newer. Ref: bf5f41d948b6f3f27db7fdc2b70897aec991065f
* | | | | Retry ActiveStorage::AnalyzeJobs on download integrity check failuresGeorge Claghorn2018-08-191-0/+2
| | | | |
* | | | | Remove superfluous testGeorge Claghorn2018-08-191-10/+0
| | | | | | | | | | | | | | | | | | | | This test no longer covers the behavior of ActiveStorage::PurgeJob. Attached blobs are ignored by ActiveStorage::Blob#purge as of 934fccd, which includes an equivalent model test.
* | | | | Address intermittent CI failure due to non-determined sort orderRyuta Kamizono2018-08-191-1/+1
|/ / / / | | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/417783260#L1173-L1179
* | | | Ensure `foreign_keys` assertions after alter tableRyuta Kamizono2018-08-191-1/+5
| | | | | | | | | | | | | | | | | | | | If `foreign_keys` is fetched before alter table, it couldn't notice whether foreign keys are broken or not after alter table.
* | | | Enable Style/ParenthesesAroundCondition copRyuta Kamizono2018-08-196-7/+10
| | | | | | | | | | | | | | | | To prevent style check in review like https://github.com/rails/rails/pull/33608#discussion_r211087605.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-25 23:46:00 +0000