| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
This fixes following warnings:
```
actionpack/lib/action_dispatch/middleware/debug_locks.rb:46: warning: shadowing outer local variable - threads
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, `DebugLocks` middleware raises an error as follwing:
```
Puma caught this error: can't modify frozen String (RuntimeError)
actionpack/lib/action_dispatch/middleware/debug_locks.rb:97:in `block in render_details'
actionpack/lib/action_dispatch/middleware/debug_locks.rb:64:in `each'
actionpack/lib/action_dispatch/middleware/debug_locks.rb:64:in `map'
actionpack/lib/action_dispatch/middleware/debug_locks.rb:64:in `render_details'
actionpack/lib/action_dispatch/middleware/debug_locks.rb:37:in `call'
railties/lib/rails/engine.rb:524:in `call'
```
|
|
|
|
| |
https://travis-ci.org/rails/rails/jobs/268599781#L784
|
|\
| |
| | |
Use tt in doc for action_pack [ci skip]
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/fix_cant_modify_forzen_string_error_in_display_image
Fix `can't modify frozen String` error in `display_image`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Without this, `display_image` raises an error as follwing:
```
RuntimeError: can't modify frozen String
rails/actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb:72:in `display_image'
rails/actionpack/test/dispatch/system_testing/screenshot_helper_test.rb:40:in `block (2 levels) in <class:ScreenshotHelperTest>'
```
|
|\ \ \
| | | |
| | | | |
Use tt in doc for action_mailer [ci skip]
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
Use typewriter in doc for Action Cable [ci skip]
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Fix broken doc for Active Record [ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Enable links in Active Storage docs [ci skip]
|
| | |/ /
| |/| | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
yhirano55/add_nodoc_for_active_record_attribute_methods
Add :nodoc: for ActiveRecord::AttributeMethods [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fix link in doc for active storage [ci skip]
|
| |/ / |
|
|/ /
| |
| |
| |
| |
| |
| | |
This regression was caused by caa178c1. The block for
`set_inverse_instance` should also be passed to join dependency.
Fixes #30402.
|
|\ \
| |/
|/| |
Add paths to docs for Active Storage
|
|/ |
|
|\
| |
| | |
Address `test_after_save_callback_with_autosave` failure
|
|/
|
|
|
|
|
| |
when other `AutomaticInverseFindingTests` load `:comments` fixture
but does not load `:posts`.
Refer #30385 for similar issue
|
| |
|
| |
|
|\
| |
| | |
Refactor `SchemaDumper` to make it possible to adapter specific customization
|
| |
| |
| |
| |
| |
| |
| | |
Currently `SchemaDumper` is only customizable for column options. But
3rd party connection adapters (oracle-enhanced etc) need to customizable
for table or index dumping also. To make it possible, I introduced
adapter specific `SchemaDumper` classes for that.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix indentation [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Update active_support_core_extensions.md [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Update azure-core to 0.1.11 to fix rails-dev-box
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
rails-dev-box was failing to install gems with a filesystem permission
error. The issue was introduced when azure-core was bumped from 0.1.9 to
0.1.10 in d2f493c. azure-core has fixed the build problem [1] and
released a new version, 0.1.11 with the fix.
This change is just to run `bundle update azure-core` to pick up that
fix.
[1]: https://github.com/Azure/azure-ruby-asm-core/commit/536c3fc21cc48c292959cc10a9e5551e165aa0ed
|
|\ \ \ \
| |/ / /
|/| | | |
[ci skip]Revert commits changing wrong place
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commits 5147ab121d628f29451c654a8c312d5a3f491ffb and 391043ab04007bfd4c4c4c8e8d3308c1eae60175.
These commits looked to intend to change documents of has_many dependent options, but actually changed documents of belongs_to dependent options.
|
|\ \ \ \
| | | | |
| | | | | |
Remove `alt` text from `image_tag` example [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
Follow up of #30213
|
|\ \ \ \
| | | | |
| | | | | |
Fix broken link for Java xml [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Use REDIS_URL var for Action Cable config template
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | |
| | | | | | |
Do not generate default alt text for images
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
`counter_cache` requires association class before `attr_readonly`
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
There were similar pull requests #26370 #27575 fixed by different way
by moving `require "models/post"` before `require "models/comment"`
|