Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #10533 from vipulnsward/fix_test | Rafael Mendonça França | 2013-06-15 | 1 | -1/+2 |
|\ | | | | | Fix test, addresss => address | ||||
| * | Make test name descriptive and add reference to original regression commit | Vipul A M | 2013-06-15 | 1 | -1/+2 |
| | | |||||
* | | Merge pull request #10907 from senny/fixtures_and_database_url | Yves Senn | 2013-06-15 | 3 | -4/+21 |
|\ \ | | | | | | | fixture setup does not rely on `AR::Base.configurations`. | ||||
| * | | fixture setup does not rely on `AR::Base.configurations`. | Yves Senn | 2013-06-15 | 3 | -4/+21 |
|/ / | | | | | | | | | | | | | | | As you can also configure your database connection using `ENV["DATABASE_URL"]`, the fixture setup can't reply on the `.configurations` Hash. As the fixtures are only loaded when ActiveRecord is actually used (`rails/test_help.rb`) it should be safe to drop the check for an existing configuration. | ||||
* | | Merge pull request #10955 from arunagw/jruby_json_not_required | Rafael Mendonça França | 2013-06-15 | 1 | -1/+0 |
|\ \ | | | | | | | 'json' gem is no more required under JRuby | ||||
| * | | 'json' gem is no more required under JRuby | Arun Agrawal | 2013-06-15 | 1 | -1/+0 |
| | | | |||||
* | | | Merge pull request #10925 from senny/10917_test_to_prevent_regression | Yves Senn | 2013-06-15 | 3 | -3/+36 |
|\ \ \ | | | | | | | | | regression test + mysql2 adapter raises correct error if conn is closed. | ||||
| * | | | regression test + mysql2 adapter raises correct error if conn is closed. | Yves Senn | 2013-06-15 | 3 | -3/+36 |
|/ / / | |||||
* | | | cleanup, remove trailing whitespace from AR changelog | Yves Senn | 2013-06-15 | 1 | -4/+4 |
| | | | |||||
* | | | Merge pull request #10953 from acapilleri/fix_typos | Yves Senn | 2013-06-15 | 1 | -1/+1 |
|\ \ \ | |/ / |/| | | fix typos | ||||
| * | | fix typos | Angelo Capilleri | 2013-06-15 | 1 | -1/+1 |
| | | | |||||
* | | | Fix AS changelog [ci skip] | Carlos Antonio da Silva | 2013-06-14 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #10950 from appscape-forks/fix-wrong-method-name | Carlos Antonio da Silva | 2013-06-14 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Fix wrong method name | ||||
| * | | | valid_app_const? -> valid_const? | Martin Schürrer | 2013-06-15 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #10946 from arunagw/build_fix_for_object_const_get_nil | Xavier Noria | 2013-06-14 | 1 | -0/+3 |
|\ \ \ \ | |/ / / |/| | | | We need to check exception name to be nil | ||||
| * | | | Changing const_regexp to check for constant name. | Arun Agrawal | 2013-06-15 | 1 | -0/+3 |
| | | | | | | | | | | | | | | | | We need to return Regexp.escape(camel_cased_word) if the split is blank. | ||||
* | | | | Add CHANGELOG entry for #10740 | Rafael Mendonça França | 2013-06-14 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Merge pull request #10740 from mrsimo/hash-with-indifferent-access-select | Rafael Mendonça França | 2013-06-14 | 2 | -0/+34 |
|\ \ \ \ | | | | | | | | | | | HashWithIndifferentAccess#select working as intended | ||||
| * | | | | HashWithIndifferentAccess#select working as intended | Albert Llop | 2013-05-23 | 2 | -0/+34 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, #reject returned a HashWithIndifferentAccess, whereas #select returned a Hash. Now #select also returns a HashWithIndifferentAccess. | ||||
* | | | | | Merge pull request #10898 from dmitry/find_first_refactor_duplication | Rafael Mendonça França | 2013-06-14 | 1 | -11/+10 |
|\ \ \ \ \ | | | | | | | | | | | | | Refactored ActiveRecord `first` method to get rid of duplication. | ||||
| * | | | | | rename method `find_first_records` to `find_first_with_limit` | Dmitry Polushkin | 2013-06-10 | 1 | -3/+3 |
| | | | | | | |||||
| * | | | | | Refactored ActiveRecord `first` method to get rid of duplication. | Dmitry Polushkin | 2013-06-09 | 1 | -11/+10 |
| | | | | | | |||||
* | | | | | | Properly namespace DatabaseTasks | Piotr Sarnacki | 2013-06-14 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Use DatabaseTasks.env instead of Rails.env in databases.rake | Piotr Sarnacki | 2013-06-14 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #10937 from prathamesh-sonpatki/except_example | Yves Senn | 2013-06-14 | 1 | -0/+8 |
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | Added an example of the query without except before the example with except | ||||
| * | | | | | Added an example of the query without except before the example with except | Prathamesh Sonpatki | 2013-06-14 | 1 | -0/+8 |
| | | | | | | |||||
* | | | | | | Merge pull request #10943 from killthekitten/10932_constantize_empty | Xavier Noria | 2013-06-14 | 2 | -5/+10 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Fix #10932. Treat "" and "::" as invalid on constantize | ||||
| * | | | | | Fix #10932. Treat "" and "::" as invalid on constantize | Nikolay Shebanov | 2013-06-14 | 2 | -5/+10 |
| | | | | | | |||||
* | | | | | | Merge pull request #10833 from hone/remove_initialize_on_precompile | Guillermo Iguaran | 2013-06-13 | 4 | -35/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | `initialize_on_precompile` is not used anymore. | ||||
| * | | | | | | `initialize_on_precompile` is not used anymore. | Terence Lee | 2013-06-13 | 4 | -35/+1 |
|/ / / / / / | |||||
* | | | | | | quoted table name is also cached | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | table name is cached on the class, so stop caching twice | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | calculate types on construction | Aaron Patterson | 2013-06-13 | 1 | -8/+4 |
| | | | | | | |||||
* | | | | | | only cache the primary key column in one place | Aaron Patterson | 2013-06-13 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | these methods are never called, so remove them | Aaron Patterson | 2013-06-13 | 1 | -8/+0 |
| | | | | | | |||||
* | | | | | | This test does not test anything that happens in the real world. If you | Aaron Patterson | 2013-06-13 | 2 | -27/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recreate the models without mucking with internal caches of the relation objects, then the test fails. For example: class Man < ActiveRecord::Base has_many :interests end class Interest < ActiveRecord::Base belongs_to :man end Then do this test: def test_validate_presence_of_parent_fails_without_inverse_of repair_validations(Interest) do Interest.validates_presence_of(:man) assert_no_difference ['Man.count', 'Interest.count'] do man = Man.create(:name => 'John', :interests_attributes => [{:topic=>'Cars'}, {:topic=>'Sports'}]) assert_not_predicate man.errors[:"interests.man"], :empty? end end end The test will fail. This is a bad test, so I am removing it. | ||||
* | | | | | | Don't set X-UA-Compatible header by default | Guillermo Iguaran | 2013-06-13 | 2 | -5/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are setting this header to chrome=1 for Chrome Frame and this will be retired soon. Check http://blog.chromium.org/2013/06/retiring-chrome-frame.html for details | ||||
* | | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-06-14 | 58 | -169/+332 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | | | | | | copy editing AS guide [ci skip] | Vijay Dev | 2013-06-14 | 1 | -19/+4 |
| | | | | | | | |||||
| * | | | | | | copy edits [ci skip] | Vijay Dev | 2013-06-14 | 4 | -34/+27 |
| | | | | | | | |||||
| * | | | | | | Revert "Add detailed steps on how to squash multiple commits into a single ↵ | Vijay Dev | 2013-06-14 | 1 | -25/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | detailed commit" This reverts commit 6df9c595ad8e473d15a81a9291e891476bc833c2. | ||||
| * | | | | | | Revert "Whitespace trimming in guides generation" | Vijay Dev | 2013-06-14 | 4 | -13/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 91a1cf7013252753567b36f61bfcd5fd0a5bb2b8. Reason: code changes disallowed in docrails, even if they are guides generation related. | ||||
| * | | | | | | Using 1.9 syntax for edge guides | Rashmi Yadav | 2013-06-12 | 1 | -2/+2 |
| | | | | | | | |||||
| * | | | | | | minor doc changes to `ActiveSupport::BacktraceCleaner`. | Yves Senn | 2013-06-12 | 1 | -5/+5 |
| | | | | | | | |||||
| * | | | | | | Image optimized for web view | Rashmi Yadav | 2013-06-09 | 23 | -0/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Used imageoptim, Saved few bytes http://imageoptim.com/ | ||||
| * | | | | | | Merge branch 'master' of github.com:rails/docrails | Jeff Cohen | 2013-06-08 | 1 | -1/+48 |
| |\ \ \ \ \ \ | |||||
| | * | | | | | | doc: renaming table name to follow the file's standards | Thiago Pinto | 2013-06-08 | 1 | -2/+2 |
| | | | | | | | | |||||
| | * | | | | | | instructions for variations and alternatives for ActiveRecord#find | Thiago Pinto | 2013-06-08 | 1 | -1/+35 |
| | | | | | | | | |||||
| | * | | | | | | Merge branch 'master' of github.com:rails/docrails | Thiago Pinto | 2013-06-08 | 1 | -0/+6 |
| | |\ \ \ \ \ \ | |||||
| | * | | | | | | | explaining ActiveRecord#first in rails 3 and 4 | Thiago Pinto | 2013-06-08 | 1 | -0/+13 |
| | | | | | | | | |