| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
Action Controller guide edits for grammar and clarity
|
| | | |
|
| |\ \
| | |
| | | |
`ActiveJob::QueueAdapters::*` are no longer singletons
|
| | | | |
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This introduces undesirable `Rails.logger` formatters (such as the syslog
formatter) onto a `Logger.new(STDERR)` for the console. The production
logger may be going elsewhere than standard io, so we can't presume to
reuse its formatter.
With syslog, this causes missing newlines in the console, so irb prompts
start at the end of the last log message.
We can work to expose the console formatter in another way to address
the original issue.
This reverts commit 026ce5ddf11c4cda0aae7f33a9266e54117db318, reversing
changes made to 6f0a69c5899ebdc892e2aa23e68e2604fa70fb73.
|
| |\ \
| | |
| | | |
Unnecessary usage of self in the guides [ci skip]
|
| | | |
| | |
| | | |
I deleted self from the callbacks guides code example because it's unnecessary and this way it's more like the other examples where self was not used.
|
| |\ \ \
| | | |
| | | | |
[ci skip] Change to code element
|
| |/ / / |
|
| | | |
| | |
| | |
| | | |
This change was prompted by 598b841.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
There was a typo in the `:requires_new` option. This led
to `#<ArgumentError: unknown keyword: require_new>` leaving all the
triggers in a disabled state.
|
| |\ \ \
| | | |
| | | | |
Upd pg json_test
|
| |/ / / |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Let strip_tags leave HTML escaping to Rails.
|
| | | | |
| | | |
| | | |
| | | | |
Prevents double escaping errors, such as "&" becoming "&amp;".
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As of Ruby 2.2, Psych can handle any object which is marshallable. This
was not true on previous versions of Ruby, so our delegator types had to
provide their own implementation of `init_with` and `encode_with`.
Unfortunately, this doesn't match up with what Psych will do today.
Since by the time we hit this layer, the objects will have already been
created, I think it makes the most sense to just grab the current type
from the class.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I should have done this in the first place. We are now serializing an
explicit version so we can make more careful changes in the future. This
will load Active Record objects which were serialized in Rails 4.1.
There will be bugs, as YAML serialization was at least partially broken
back then. There will also be edge cases that we might not be able to
handle, especially if the type of a column has changed.
In addition, we're passing this as `from_database`, since that is
required for serialized columns at minimum. All other types were
serializing the cast value. At a glance, there should be no types for
which this is a problem.
Finally, dirty checking information will be lost on records serialized
in 4.1, so no columns will be marked as changed.
|
| |\ \ \ \
| | | | |
| | | | | |
remove unnecessary autoload path parameters
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Gaurav2728/gaurav-remove_test_after_commit_gem_msg
‘test_after_commit’ gem is not require in Rails 5, remove note from doc ...
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Changed 'blank space' to 'blank line'
|
| |/ / / /
| | | |
| | | | |
Line 85 stated that fixtures are typically separated by a blank space. I changed the wording to blank line because blank space could be misinterpreted as a non-breaking space character when in reality, each fixture record (in YAML) is separated by a blank line.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The table is being modified in tests, without reloading the column
information on the appropriate class. This is leading to incorrect
column information in many cases.
The failures fixed by this commit can be replicated with:
ARCONN=postgresql ruby -Itest test/cases/adapters/postgresql/hstore_test.rb --seed 21574
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes the reasons 4cf3b8a, 303567e, and fa63448 needed to be
reverted in 7142059. The revert has been reverted and this fixes
the issues caused previously.
If we call `super` first we will end up nuking the session settings in the
application tests that do `setup do` - so any session login or cookie
settings will not be persisted thoughout the test sessions.
Calling `super` last prevents `@integration_session` from getting nuked
and set to nil if it's already set.
Test added to prevent regression of this behavior in the future.
|
| | | | |
| | | |
| | | |
| | | | |
This reverts commit 714205988315d2f98aa3e749747c44470e18676b.
|
| |\ \ \ \
| | | | |
| | | | | |
Fix place of require 'rails_guides/markdown'
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The default value of `"pg_arrays"."tags"` is being changed to `[]` in
one test, but the column information on the model isn't reset after it's
changed back. As such, we think the default value is `[]` when in the
database it's actually `nil`. That means any test which was assigning
`[]` to a new record would have that key skipped with partial writes, as
it hasn't changed from the default. However since the *actual* default
value is `nil`, we get back values that the test doesn't expect, and it
fails.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
use public Module#include instead of send :include [ci skip]
|
| | | | | | | |
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Reverting this as it's not the implementation that we would like it to be.
This is being used inside of ActiveSUpport::TimeZone[] and it's unaware
of the context in which to find the timezone period so the timezone found
changes depending on whether DST is in effect for the current period.
This means that `'2001-01-01'.in_time_zone(-9)` changes from winter/summer
even though it's the same date that we're trying to convert.
Since finding timezones by numeric offsets is a bit hit and miss we should
introduce a new API for finding them which supplies the date context in
which we want to search and we should probably also deprecate the finding
of timezones via the [] method, though this needs further discussion.
This reverts commit 2cc2fa3633edd96773023c6b09d07c7b9d9b841d.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Target Ruby 2.2.1 in gemspecs
|
| |/ / / / /
| | | | |
| | | | |
| | | | | |
This is a follow-up to #19257
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Rails 5.0 needs ruby 2.2.1 or higher
|
| |/ / / / /
| | | | |
| | | | |
| | | | | |
Since there was a bug in 2.2.0, the minimum ruby requirement is 2.2.1. See https://github.com/rails/rails/commit/8ed0b89b
[skip ci]
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
Fix rollback of frozen records
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Doc fixes [ci skip]
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Doc fix [ci skip]
|
| |/ / / / / |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
update integration test example as is not output deprecation warning [ci skip]
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
[ci skip] Fix `AS` and `AR` to full name
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Doc fix [ci skip]
|
