| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In encrypted secrets, the tmp file is used as a fixed file
(`secrets.yml.enc` under the tmp directory).
And that tmp file will be removed after process.
Therefore, if edit secrets at the same time with multiple applications,
the tmp file was conflicting.
In order to avoid the above issue, added pid to tmp file.
|
|\ \ \ \
| |/ / /
|/| | | |
[ci skip] `Response#charset=` uses `default_charset` when `nil` is passed
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Change sqlite3 boolean serialization to use 1 and 0
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Abstract boolean serialization has been using 't' and 'f', with MySQL
overriding that to use 1 and 0.
This has the advantage that SQLite natively recognizes 1 and 0 as true
and false, but does not natively recognize 't' and 'f'.
This change in serialization requires a migration of stored boolean data
for SQLite databases, so it's implemented behind a configuration flag
whose default false value is deprecated. The flag itself can be
deprecated in a future version of Rails. While loaded models will give
the correct result for boolean columns without migrating old data,
where() clauses will interact incorrectly with old data.
While working in this area, also change the abstract adapter to use
`"TRUE"` and `"FALSE"` as quoted values and `true` and `false` for
unquoted. These are supported by PostreSQL, and MySQL remains
overriden.
|
|\ \ \ \
| | | | |
| | | | | |
Fix configuring third-party cache stores such as ActiveSupport::Cache::RedisStore
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveSupport::Cache::RedisStore
Broken in 8da30ad.
|
| | | |
| | | |
| | | |
| | | | |
fixes a regression introduced at 8607c25ba7810573733d9b37d0015154ba059f5e
|
|\ \ \ \
| | | | |
| | | | | |
Extract `FakeKlass` in `relation_test.rb` and `relation/mutation_test.rb`
|
| | |/ /
| |/| |
| | | |
| | | |
| | | | |
`FakeKlass` in `relation_test.rb` and `relation/mutation_test.rb` are
almost the same.
|
|\ \ \ \
| | | | |
| | | | | |
Enable Layout/EmptyLineAfterMagicComment cop
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix english for the rescue_from warning [ci skip]
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix PostgreSql adapter setup for ActionCable tests
|
|/ / /
| | |
| | |
| | |
| | | |
(cherry picked from commit e2093c1f678175bde7c37c848686d979427346e1)
(cherry picked from commit d7dbe48273bd9e0adb1de5b52e3cdaeb4a65630b)
|
|\ \ \
| |/ /
|/| | |
Fix typo in method name
|
|/ / |
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
|\ \
| | |
| | | |
Default protect from forgery
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since we now default to `protect_from_forgery with: :exception`,
provide a wrapper to `skip_before_action :verify_authenticity_token`
for disabling forgery protection.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rather than protecting from forgery in the generated
ApplicationController, add it to ActionController::Base by config. This
configuration defaults to false to support older versions which have
removed it from their ApplicationController, but is set to true for
Rails 5.2.
|
|\ \ \
| |/ /
|/| | |
Don't eagerly require Rails' minitest plugin.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By making the Rails minitest behave like a standard minitest plugin
we're much more likely to not break when people use other minitest
plugins. Like minitest-focus and pride.
To do this, we need to behave like minitest: require files up front
and then perform the plugin behavior via the at_exit hook.
This also saves us a fair bit of wrangling with test file loading.
Finally, since the environment and warnings options have to be applied
as early as possible, and since minitest loads plugins at_exit, they
have to be moved to the test command.
* Don't expect the root method.
It's likely this worked because we eagerly loaded the Rails minitest plugin
and that somehow defined a root method on `Rails`.
* Assign a backtrace to failed exceptions.
Otherwise Minitest pukes when attempting to filter the backtrace (which
Rails' backtrace cleaner then removes).
Means the exception message test has to be revised too.
This is likely caused by the rails minitest plugin now being loaded for
these tests and assigning a default backtrace cleaner.
|
| |
| |
| |
| | |
Time.now` (#29681)
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/make_sidekiq_and_resque_integration_tests_work_in_ci
Make sidekiq and resque integration tests work in CI
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Since f55ecc6, the integration test of sidekiq and resque is not working
in CI.
https://travis-ci.org/rails/rails/jobs/251783876
Because f55ecc6 required a password to access redis.
Therefore, handling by passing passwords when connecting to redis.
|
|\ \
| | |
| | | |
Use frozen-string-literal in ActiveJob
|
|/ / |
|
|\ \
| | |
| | | |
[ci skip] Updated language on validations.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Update MessageEncryptor example to use dynamic key length
|
| | |
| | |
| | |
| | | |
by OpenSSL
|
|\ \ \
| | | |
| | | | |
Treat secrets as binary
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Until Rails 5.1.1 secrets was treated as binary inside Rails.
https://github.com/rails/rails/blob/v5.1.1/railties/lib/rails/secrets.rb#L59
https://github.com/rails/rails/blob/v5.1.1/railties/lib/rails/secrets.rb#L63
However, it is treated as String in Rails 5.1.2(changed by 157db872103429e8782b62d1cb5d1d91337177a7).
https://github.com/rails/rails/blob/v5.1.2/railties/lib/rails/secrets.rb#L104
https://github.com/rails/rails/blob/v5.1.2/railties/lib/rails/secrets.rb#L108
As a result, when upgrading from Rails 5.1.1 to 5.1.2, to write the value
treated as binary using `File.write`, causing an error.
In order to avoid `UndefinedConversionError`, fixed it to treat it as
binary like 5.1.1.
Fixes #29696
|
|\ \ \ \
| | | | |
| | | | | |
Load environment file in `dbconsole` command
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently the environment file is not loaded in `dbconsole` command.
Therefore, for example, if use encrypted secrets values in database.yml,
`read_encrypted_secrets` will not be true, so the value can not be
used correctly.
Fixes #29717
|
|\ \ \ \
| | | | |
| | | | | |
Prepare AP and AR to be frozen string friendly
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Use frozen-string-literal in ActiveSupport
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Don't allow uuids with orphan curly braces
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The uuid validation regex was allowing uuids to have a single leading
curly brace or single trailing curly brace. Saving with such a uuid
would cause Postgres to generate an exception even though the record
seemed valid. With this change, the regex requires both a leading *and*
a trailing curly brace or neither to be valid.
|
| | | | | |
|