Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Remove some indirection in rake dbs test | Carlos Antonio da Silva | 2014-03-20 | 1 | -34/+20 | |
| | | | | | | | | | | | | | | | Just pass in the expected database as argument rather than "caching" it in a hash and using the hash in the helper methods. | |||||
* | | | Check if the output is empty rather than asserting for equality | Carlos Antonio da Silva | 2014-03-20 | 1 | -5/+4 | |
| | | | | | | | | | | | | Also fix indent of test block. | |||||
* | | | Improve touch docs with extra attributes passed in [ci skip] | Carlos Antonio da Silva | 2014-03-20 | 2 | -11/+10 | |
| | | | ||||||
* | | | Merge pull request #14423 from yakko/persistence-touches-many | Carlos Antonio da Silva | 2014-03-20 | 3 | -2/+27 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord#touch should accept multiple attributes Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | ActiveRecord#touch should accept multiple attributes #14423 | Thiago Pinto | 2014-03-19 | 3 | -2/+27 | |
| |/ / | ||||||
* | | | only dump schema information if migration table exists. Closes #14217 | Yves Senn | 2014-03-20 | 2 | -1/+9 | |
| | | | ||||||
* | | | Merge pull request #14433 from adomokos/cleaning_up_and_adding_session_tests | Godfrey Chan | 2014-03-19 | 1 | -7/+34 | |
|\ \ \ | | | | | | | | | Cleaning up and adding tests for Session | |||||
| * | | | Cleaning and adding tests for Session | Attila Domokos | 2014-03-19 | 1 | -7/+34 | |
| | | | | | | | | | | | | Adding tests for Session `destroy`, `update` and `delete` methods. No changes for code under test. | |||||
* | | | | Refactor assertion of line numbers matching 4 spaces | Carlos Antonio da Silva | 2014-03-19 | 1 | -16/+4 | |
| | | | | ||||||
* | | | | Move booting/loading tasks setup to the rake notes helper method | Carlos Antonio da Silva | 2014-03-19 | 1 | -15/+3 | |
| | | | | ||||||
* | | | | Extract rake notes command and lines scan boilerplate | Carlos Antonio da Silva | 2014-03-19 | 1 | -19/+14 | |
| | | | | | | | | | | | | | | | | Refactor to a reusable method. | |||||
* | | | | Remove extra space assertion | Carlos Antonio da Silva | 2014-03-19 | 1 | -3/+2 | |
| | | | | | | | | | | | | | | | | | | | | No need to check that each line contains an extra space, just matching the space in the regexp is enough to ensure that. | |||||
* | | | | Extract common setup for loading tasks in rake notes tests | Carlos Antonio da Silva | 2014-03-19 | 1 | -29/+14 | |
|/ / / | ||||||
* | | | Merge pull request #14431 from chancancode/warn_about_json_cookie_jars | Guillermo Iguaran | 2014-03-19 | 2 | -0/+48 | |
|\ \ \ | | | | | | | | | Added a warning about serializing data with JSON cookie jars [skip ci] | |||||
| * | | | Added a warning about serializing data with JSON cookie jars [skip ci] | Godfrey Chan | 2014-03-19 | 2 | -0/+48 | |
|/ / / | | | | | | | | | | Closes #14409 | |||||
* | | | Merge pull request #14429 from chriskohlbrenner/fix_typo_ar_querying_guide | Arthur Nogueira Neves | 2014-03-19 | 1 | -1/+1 | |
|\ \ \ | |/ / |/| | | Fix a typo to make clause plural [ci skip] | |||||
| * | | Fix a typo to make clause plural [ci skip] | chriskohlbrenner | 2014-03-19 | 1 | -1/+1 | |
|/ / | ||||||
* | | Merge pull request #14421 from davidpdrsn/reorder-conditionals | Rafael Mendonça França | 2014-03-18 | 1 | -10/+10 | |
|\ \ | | | | | | | Reorder conditional logic in link_to_if and link_to_unless | |||||
| * | | Reorder conditional logic | David Pedersen | 2014-03-18 | 1 | -10/+10 | |
|/ / | | | | | | | | | | | According to the best practice that "unless not" and "unless else" is hard to follow logically the link_to_unless and link_to_if were reversed. | |||||
* | | Merge pull request #14413 from arthurnn/port_test_cc | Godfrey Chan | 2014-03-18 | 1 | -0/+11 | |
|\ \ | | | | | | | Add counter cache test for class_name | |||||
| * | | Add counter cache test for class_name | Arthur Neves | 2014-03-17 | 1 | -0/+11 | |
|/ / | | | | | | | Backport test from #14410 | |||||
* | | test should only pass if the pool.size+1 checkout fails | Aaron Patterson | 2014-03-17 | 1 | -3/+2 | |
| | | | | | | | | | | Previously, any of the connection checkouts could have failed, and this test would pass. | |||||
* | | use a latch to avoid busy loops | Aaron Patterson | 2014-03-17 | 1 | -3/+4 | |
| | | ||||||
* | | Merge pull request #14360 from matthewd/thread_aware_reaper | Aaron Patterson | 2014-03-17 | 8 | -69/+103 | |
|\ \ | | | | | | | Track owning thread for connection pool | |||||
| * | | Reap connections based on owning-thread death | Matthew Draper | 2014-03-18 | 7 | -68/+66 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .. not a general timeout. Now, if a thread checks out a connection then dies, we can immediately recover that connection and re-use it. This should alleviate the pool exhaustion discussed in #12867. More importantly, it entirely avoids the potential issues of the reaper attempting to check whether connections are still active: as long as the owning thread is alive, the connection is its business alone. As a no-op reap is now trivial (only entails checking a thread status per connection), we can also perform one in-line any time we decide to sleep for a connection. | |||||
| * | | Teach PostgreSQLAdapter#reset! to actually reset | Matthew Draper | 2014-03-18 | 2 | -1/+37 | |
|/ / | | | | | | | It wasn't doing anything beyond clearing the statement cache. | |||||
* | | Merge pull request #14379 from robertomiranda/rake-notes.config | Guillermo Iguaran | 2014-03-17 | 6 | -30/+81 | |
|\ \ | | | | | | | Add Public Api for Register New Extensions for Rake Notes | |||||
| * | | Rake notes should picked up new Extensions registered in the ↵ | robertomiranda | 2014-03-17 | 1 | -3/+19 | |
| | | | | | | | | | | | | config/application.rb file | |||||
| * | | Update command line guide | robertomiranda | 2014-03-17 | 1 | -1/+7 | |
| | | | ||||||
| * | | Add Changelog Entry ref #14379 | robertomiranda | 2014-03-17 | 1 | -0/+8 | |
| | | | ||||||
| * | | Add config.annotations, in order to register new extensions for Rake notes ↵ | robertomiranda | 2014-03-16 | 2 | -0/+14 | |
| | | | | | | | | | | | | at config level | |||||
| * | | Fix Shadowing extensions variable in Register Annotation Exentsions | robertomiranda | 2014-03-16 | 2 | -7/+7 | |
| | | | ||||||
| * | | Supporting .ruby, .yml and .yaml Extension in Rake Notes | robertomiranda | 2014-03-14 | 2 | -2/+7 | |
| | | | ||||||
| * | | Remove .scss, .sass, .less, .haml, .slim, coffee from Rake Notes. Now we ↵ | robertomiranda | 2014-03-14 | 2 | -17/+5 | |
| | | | | | | | | | | | | have an API for register it in the corresponding gems | |||||
| * | | Add Public Api for register new extensions for Rake Notes | robertomiranda | 2014-03-14 | 2 | -15/+29 | |
| | | | ||||||
* | | | Merge pull request #14090 from ↵ | Aaron Patterson | 2014-03-17 | 2 | -10/+30 | |
|\ \ \ | | | | | | | | | | | | | | | | | Fortisque/kevin/stream_error_in_main_thread_if_not_committed re-raise error if error occurs before committing in streaming | |||||
| * | | | re-raise error if error occurs before committing in streaming | Kevin Casey | 2014-03-14 | 2 | -10/+30 | |
| | |/ | |/| | | | | | | | update the tests, using an if-else | |||||
* | | | `where.not` adds `references` for `includes`. | Yves Senn | 2014-03-17 | 4 | -0/+26 | |
| | | | | | | | | | | | | Closes #14406. | |||||
* | | | fix `number_to_percentage` with `Float::NAN`, `Float::INFINITY`. | Yves Senn | 2014-03-17 | 4 | -2/+14 | |
| | | | | | | | | | | | | | | | | | | | | | Closes #14405. This is a follow-up to 9e997e9039435617b6a844158f5437e97f6bc107 to restore the documented behavior. | |||||
* | | | format ActiveRecord CHANGELOG. [ci skip] | Yves Senn | 2014-03-17 | 1 | -8/+9 | |
| | | | ||||||
* | | | Fix assertions | Carlos Antonio da Silva | 2014-03-16 | 1 | -2/+2 | |
| | | | ||||||
* | | | Add an explicit require for 4ece124396669d3580e7f229ab407a0d4882727a rather ↵ | Jeremy Kemper | 2014-03-16 | 1 | -0/+1 | |
| | | | | | | | | | | | | than assume SecureRandom is available | |||||
* | | | Avoid concurrent test collision on the same memcache server by namespacing keys | Jeremy Kemper | 2014-03-16 | 1 | -1/+1 | |
| | | | ||||||
* | | | Use nested_scope? not shallow? to determine whether to copy options | Andrew White | 2014-03-16 | 3 | -1/+49 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The method `shallow?` returns false if the parent resource is a singleton so we need to check if we're not inside a nested scope before copying the :path and :as options to their shallow equivalents. Fixes #14388. | |||||
* | | | Remove extra white-spaces [ci skip] | Robin Dupret | 2014-03-16 | 1 | -13/+13 | |
| | | | | | | | | | | | | Follow up to 024e5e31 | |||||
* | | | Let COMMAND_WHITELIST be an Array, not a String | Akira Matsuda | 2014-03-16 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #14399 from genericsteele/fixture-label-string-interpolation | Jeremy Kemper | 2014-03-15 | 4 | -1/+19 | |
|\ \ \ | | | | | | | | | Extend fixture label replacement to allow string interpolation | |||||
| * | | | Extend fixture label replacement to allow string interpolation | Eric Steele | 2014-03-15 | 4 | -1/+19 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows fixtures to use their $LABEL as part of a string instead of limiting use to the entire value. mark: first_name: $LABEL username: $LABEL1973 email: $LABEL@$LABELmail.com users(:mark).first_name # => mark users(:mark).username # => mark1973 users(:mark).email # => mark@markmail.com | |||||
* | | | Merge pull request #14396 from afshinator/master | Jeremy Kemper | 2014-03-15 | 1 | -11/+28 | |
|\ \ \ | | | | | | | | | Reword 5.6 strong parameters and private method stuff [ci skip] | |||||
| * | | | Reword 5.6 strong parameters and private method stuff [ci skip] | Afshin Mokhtari | 2014-03-15 | 1 | -11/+28 | |
| | | | |