Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Prefer class << self; def over def self. | Akira Matsuda | 2016-12-25 | 1 | -200/+200 |
| | |||||
* | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instances | Akira Matsuda | 2016-12-25 | 1 | -4/+6 |
| | |||||
* | `protected` here doesn't protect anything | Akira Matsuda | 2016-12-25 | 1 | -26/+25 |
| | | | | there aren't any instance method defined in this class | ||||
* | Shuffle travis matrix | Matthew Draper | 2016-12-25 | 1 | -3/+3 |
| | | | | | | * Run actionpack and actioncable tests together * Demote ac:integration to allow_failures -- it works most of the time, but still fails too frequently to rely upon | ||||
* | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 26 | -158/+145 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 11 | -31/+31 |
| | |||||
* | Shave a couple of allocations off Journey scan & parse | Matthew Draper | 2016-12-25 | 4 | -203/+208 |
| | |||||
* | self. is not needed when calling its own instance method | Akira Matsuda | 2016-12-24 | 1 | -2/+1 |
| | |||||
* | Privatize unneededly protected methods in Action View | Akira Matsuda | 2016-12-24 | 7 | -39/+32 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 9 | -20/+20 |
| | |||||
* | Privatize unneededly protected methods in Action Cable | Akira Matsuda | 2016-12-24 | 5 | -25/+24 |
| | |||||
* | Privatize unneededly protected method in Active Job | Akira Matsuda | 2016-12-24 | 1 | -2/+2 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 1 | -5/+5 |
| | |||||
* | Privatize unneededly protected methods in Action Mailer | Akira Matsuda | 2016-12-24 | 4 | -27/+20 |
| | |||||
* | No need to nodoc private method | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
| | |||||
* | Privatize unneededly protected methods in Action Pack | Akira Matsuda | 2016-12-24 | 15 | -83/+82 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 5 | -24/+24 |
| | |||||
* | Privatize unneededly protected methods in Active Model | Akira Matsuda | 2016-12-24 | 6 | -27/+23 |
| | |||||
* | No need to :nodoc: private methods | Akira Matsuda | 2016-12-24 | 2 | -6/+6 |
| | |||||
* | Privatize unneededly protected methods in Active Support | Akira Matsuda | 2016-12-24 | 15 | -56/+46 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 5 | -10/+10 |
| | |||||
* | Wrong rake task name in the document | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | bundle u rake to 12.0.0 | Akira Matsuda | 2016-12-24 | 1 | -1/+1 |
| | |||||
* | Privatize unneededly protected methods in Active Support tests | Akira Matsuda | 2016-12-24 | 7 | -8/+8 |
| | |||||
* | Privatize unneededly protected methods in Railties tests | Akira Matsuda | 2016-12-24 | 6 | -6/+6 |
| | |||||
* | Privatize unneededly protected methods in Active Record tests | Akira Matsuda | 2016-12-24 | 11 | -11/+11 |
| | |||||
* | Privatize unneededly protected methods in Action Cable tests | Akira Matsuda | 2016-12-24 | 3 | -3/+3 |
| | |||||
* | Privatize unneededly protected methods in Active Job tests | Akira Matsuda | 2016-12-24 | 2 | -2/+2 |
| | |||||
* | Privatize unneededly protected methods in Action Mailer tests | Akira Matsuda | 2016-12-24 | 3 | -3/+3 |
| | |||||
* | Privatize unneededly protected methods in Action Pack tests | Akira Matsuda | 2016-12-23 | 10 | -22/+20 |
| | |||||
* | Privatize unneededly protected methods in Action View tests | Akira Matsuda | 2016-12-23 | 5 | -5/+5 |
| | |||||
* | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 37 | -0/+78 |
| | |||||
* | Unneeded attr_accessor with side effects | Akira Matsuda | 2016-12-23 | 2 | -8/+0 |
| | |||||
* | Merge pull request #27424 from utilum/fix_complex_and_rational_are_duplicable | Kasper Timm Hansen | 2016-12-22 | 3 | -2/+27 |
|\ | | | | | Fix duplicable? for Complex and Rational | ||||
| * | Fix Complex and Rational are duplicable? | utilum | 2016-12-21 | 3 | -2/+27 |
| | | | | | | | | See [this test](https://gist.github.com/utilum/78918f1b64f8b61ee732cb266db7c43a). | ||||
* | | Merge pull request #27431 from y-yagi/quiet_generator_log_in_test | Kasper Timm Hansen | 2016-12-22 | 1 | -1/+1 |
|\ \ | | | | | | | quiet generators log in test | ||||
| * | | quiet generators log in test | yuuji.yaginuma | 2016-12-22 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This quiet the following log. ``` create app/mailers/notifier_mailer.rb invoke erb create app/views/notifier_mailer identical app/views/layouts/mailer.text.erb identical app/views/layouts/mailer.html.erb create app/views/notifier_mailer/foo.text.erb create app/views/notifier_mailer/foo.html.erb invoke test_unit create test/mailers/notifier_mailer_test.rb create test/mailers/previews/notifier_mailer_preview.rb ``` | ||||
* | | | Merge pull request #27430 from kirs/aj-warning | Matthew Draper | 2016-12-22 | 1 | -1/+1 |
|\ \ \ | |/ / |/| | | Remove warning in ActiveJob | ||||
| * | | Remove warning in ActiveJob | Kir Shatrov | 2016-12-21 | 1 | -1/+1 |
|/ / | | | | | | | | | | | | | | | Currently it causes: ``` activejob/Rakefile:5: warning: already initialized constant ACTIVEJOB_ADAPTERS ``` | ||||
* | | Merge pull request #27427 from rails/binary-params | Aaron Patterson | 2016-12-21 | 6 | -54/+56 |
|\ \ | | | | | | | Document and update API for `skip_parameter_encoding` | ||||
| * | | updating docs | Aaron Patterson | 2016-12-21 | 1 | -0/+4 |
| | | | |||||
| * | | Document and update API for `skip_parameter_encoding` | Aaron Patterson | 2016-12-21 | 6 | -54/+52 |
|/ / | | | | | | | | | | | | | | | This commit changes `parameter_encoding` to `skip_parameter_encoding`. `skip_parameter_encoding` will set encoding on all parameters to ASCII-8BIT for a given action on a particular controller. This allows the controller to handle data when the encoding of that data is unknown, for example file systems or truly binary parameters. | ||||
* / | fix typo in getting_started [ci skip] (#27423) | yachibit | 2016-12-21 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #27355 from yukideluxe/fixtures-deleted-tables | Kasper Timm Hansen | 2016-12-21 | 6 | -3/+28 |
|\ | | | | | fix fixtures loading for models with same table names in different databases | ||||
| * | fix #create_fixtures when equal table names in different databases | Julia Lopez | 2016-12-21 | 6 | -3/+28 |
|/ | |||||
* | Fix grammar in asset tag documentation | eileencodes | 2016-12-20 | 1 | -1/+1 |
| | | | | | Updated the docmentation because "options supports" is not grammatically correct. | ||||
* | Improve `javascript_include_tag` documentation (#27403) | Pablo Ifrán | 2016-12-20 | 1 | -5/+24 |
| | | | | Add all the available options, and correct the samples of the `javascript_include_tag`. | ||||
* | Merge pull request #27412 from maclover7/jm-ruby-24 | Kasper Timm Hansen | 2016-12-20 | 3 | -5/+6 |
|\ | | | | | Ruby 2.4 compatibility | ||||
| * | Add Ruby v2.4.0-rc1 to Travis matrix | Jon Moss | 2016-12-20 | 1 | -0/+1 |
| | | |||||
| * | Limit length of secret being passed | Jon Moss | 2016-12-20 | 1 | -3/+3 |
| | | | | | | | | Very similar to PR #25758, see more in depth reasoning there. |