| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
Created a registry for ActiveSupport::Subscriber queues
|
| |/
|
|
| |
subscriber queues. Helps limit the number of thread locals.
|
| |\
| |
| | |
Also assign nil in dirty nullable_datetime test. Closes #10237
|
| | | |
|
| |\ \
| | |
| | | |
Update counter cache when pushing into association
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit fixes a regression bug in which counter_cache columns
were not being updated correctly when newly created records were
being pushed into an assocation. EG:
# this was fine
@post.comment.create!
# this was fine
@comment = Comment.first
@post.comments << @comment
# this would not update counters
@post.comments << Comment.create!
|
| |\ \ \
| |_|/
|/| | |
extract no content response codes to a constant
|
| | | | |
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| |\ \ \
| |/ /
|/| | |
Fixes skipping object callback filters
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows you to skip callbacks that are defined by objects, e.g. for
`ActionController`:
skip_after_filter MySpecialFilter
Previously this didn't work due to a bug in how Rails compared callbacks
in `Callback#matches?`. When a callback is compiled, if it's an object
filter (i.e. not a method, proc, etc.), `Callback` now defines a method on
`@klass` that is derived from the class name rather than `@callback_id`.
So, when `skip_callback` tries to find the appropriate callback to
remove, `Callback` can regenerate the method name for the filter
object and return the correct value for `Callback#matches?`.
|
| |\ \ \
| |_|/
|/| | |
extract array to a constant
|
| |/ / |
|
| |\ \
| | |
| | | |
Extract path into variable
|
| |/ / |
|
| |\ \
| | |
| | | |
fix README links in the main README.md
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
neerajdotname/fix-wrong-test-name-and-failure-message
fix wrong test description and failure message
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Added tests for if condition in Active Model callbacks
|
| | |/ / |
|
| |\ \ \
| | | |
| | | | |
Removing tests for deprecated options in active support.
|
| |/ / /
| | |
| | |
| | |
| | | |
+use_full_path+ option was removed in 3b3790a4 and passing the template
handler to render was deprecated in 43d27e91.
|
| |\ \ \
| | | |
| | | | |
fix typos [ci skip]
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Increase readability of ternary statement in build method
|
| |/ / / / |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Object#respond_to? returns singletons and thus we inherit that contract.
The implementation of the predicate is good, but the test is only
checking boolean semantics, which in this case is not enough.
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The entry is basically copy & paste of the commit message, but the CHANGELOG
has a different purpose than Git history, it just communicates what is new:
* No need to explain why did the bug happen (unless it is truly relevant).
* No need to explain how was the bug fixed.
* Whether the user gives new names to columns does not really matter, use of
select to cherry-pick a column for example also presented that behaviour.
Non-selected attributes are the key, either because they were not included
in the selected list, or because they were but with a different alias.
* In the case of an attribute alias, what you really want to depict is that
respond_to? returns false for the original attribute name.
|
| |\ \ \
| |/ /
|/| | |
Typo Fix in AR CHANGELOG [ci skip]
|
| |/ / |
|
| |\ \
| | |
| | | |
fix respond_to? for non selected column
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
fixes #4208
If a query selects only a few columns and gives custom names to
those columns then respond_to? was returning true for the non
selected columns. However calling those non selected columns
raises exception.
post = Post.select("'title' as post_title").first
In the above case when `post.body` is invoked then an exception is
raised since `body` attribute is not selected. Howevere `respond_to?`
did not behave correctly.
pos.respond_to?(:body) #=> true
Reason was that Active Record calls `super` to pass the call to
Active Model and all the columns are defined on Active Model.
Fix is to actually check if the data returned from the db contains
the data for column in question.
|
| |\ \
| | |
| | | |
symbolize_keys => symbolize_keys! on new hash; change sentence
|
| | | |
| | |
| | |
| | | |
"There're" => There are for better readability
|
| |\ \ \
| | | |
| | | | |
Adding documentation to Renderer
|
| | | | |
| | | |
| | | |
| | | | |
renderer is clearer.
|
| |\ \ \ \ |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit e8727d37fc49d5bf9976c3cb5c46badb92cf4ced, reversing
changes made to d098e1c24bc145e0cc14532348436e14dc46d375.
Reason: it broke the mysql build
|
| | |\ \ \ \
| | | | | |
| | | | | | |
autosave_association issue that occurs when table has unique index
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
fixes bug introduced by #3329
These are the conditions necessary to reproduce the bug:
- For an association, autosave => true.
- An association record is being destroyed
- A new association record is being created.
- There is a unique index one of the association's fields.
- The record being created has the same value as the record being
destroyed on the indexed field.
Before, the deletion of records was postponed until after all
insertions/saves. Therefore the new record with the identical value in
the indexed field caused a non-unique value error to be thrown at the database
level.
With this fix, the deletions happen first, before the insertions/saves.
Therefore the record with the duplicate value is gone from the database
before the new record is created, thereby avoiding the non-uniuqe value
error.
|
| | |\ \ \ \
| | | | | |
| | | | | | |
Postgresql array columns don't properly escape single quote strings when loading fixtures
|
| | | |/ / /
| | | | |
| | | | |
| | | | | |
- A string in an array of strings that has a quote char (') needs to have that quote char escaped if the array is getting wrapped in quote chars.
|
| | | | | | |
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Support transactions in Migrator.run
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | | |
|
| | |\ \ \ \ \
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
calebthompson/ct-fix-freeze-freezing-cloned-models
Fix freeze applying to cloned objects
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously, freezing a cloned ActiveRecord object froze the original
too. By cloning `@attributes` before freezing, we prevent cloned objects
(which in Ruby share state of ivars) from being effected by `#freeze`.
Resolves issue #4936, which has further information on this issue, as
well as steps to reproduce.
* Add a test case for `#freeze` not causing `cloned.frozen?` to be true.
* Clone @attributes before freezing in `ActiveRecord::Core`, then
reassign the cloned, frozen hash to the frozen model's `@attributes`
ivar.
/cc @steveklabnik
|
| | |\ \ \ \ \
| | |_|_|/ /
| |/| | | | |
Reorganize MessageEncryptor
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
1) According to OpenSSL's documentation, cipher.random_iv must be called
after cipher.encrypt and already sets the generated IV on the cipher.
2) OpenSSL::CipherError was moved to OpenSSL::Cipher::CipherError in
Ruby 1.8.7. Since Rails 4 requires at least Ruby 1.9.3, support for
the old location can be dropped.
|
