aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #35269 from y-yagi/allow_to_pass_options_to_csp_meta_tagYuji Yaginuma2019-02-162-2/+8
|\ | | | | Allow to pass options to `csp_meta_tag`
| * Allow to pass options to `csp_meta_tag`yuuji.yaginuma2019-02-162-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | Currently `csp_meta_tag` generates `name` attribute only. However, in libraries like `Material-UI` and `JSS`, expect that the meta tag that contains the nonce with `property` attribute. https://material-ui.com/css-in-js/advanced/#how-does-one-implement-csp https://github.com/cssinjs/jss/blob/master/docs/csp.md This patch allows `csp_meta_tag` to specify arbitrary options and allows `nonce` to be passed to those libraries.
* | Implement AS::Dependencies.verbose= compatibility for :zeitwerk modeXavier Noria2019-02-152-0/+41
| |
* | Merge pull request #35289 from LinkUpStudioUA/masterRafael França2019-02-151-0/+1
|\ \ | | | | | | AbstractController::Translation#t: dup options
| * | AbstractController::Translation#t: dup optionsNazar Matus2019-02-151-0/+1
| | |
* | | Merge pull request #35262 from gmcgibbon/reword_ar_rdbms_noteGannon McGibbon2019-02-151-1/+1
|\ \ \ | |/ / |/| | Reword RDBMS note in ActiveRecord basics
| * | Reword RDBMS note in ActiveRecord basicsGannon McGibbon2019-02-131-1/+1
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #35288 from conradbeach/fix-typosVipul A M2019-02-152-2/+2
|\ \ \ | | | | | | | | Fix Small Typo in Docs [ci skip]
| * | | Fix small typo in docs Conrad Beach2019-02-152-2/+2
|/ / / | | | | | | | | | | | | [ci skip]
* | | Merge pull request #35280 from kamipo/deprecate_leaking_scopeRyuta Kamizono2019-02-159-33/+88
|\ \ \ | | | | | | | | Deprecate using class level querying methods if the receiver scope regarded as leaked
| * | | Deprecate using class level querying methods if the receiver scope regarded ↵Ryuta Kamizono2019-02-156-21/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as leaked This deprecates using class level querying methods if the receiver scope regarded as leaked, since #32380 and #35186 may cause that silently leaking information when people upgrade the app. We need deprecation first before making those.
| * | | Revert "Merge pull request #35186 from ↵Ryuta Kamizono2019-02-156-37/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_leaking_scope_on_relation_create" This reverts commit b67d5c6dedbf033515a96a95d24d085bf99a0d07, reversing changes made to 2e018361c7c51e36d1d98bf770b7456d78dee68b. Reason: #35186 may cause that silently leaking information when people upgrade the app. We need deprecation first before making this.
* | | | Replace autoloader accessors with Rails.autoloaders.{main,once}Xavier Noria2019-02-148-50/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails.autoloader and Rails.once_autoloader was just tentative API good enough for a first patch. Rails.autoloader is singular and does not convey in its name that there is another autoloader. That might be confusing, for example if you set a logger and miss traces. On the other hand, the name `once_autoloader` is very close to being horrible. Rails.autoloaders.main and Rails.autoloaders.once read better for my taste, and have a nice symmetry. Also, both "main" and "once" are four letters long, short and same length. They are tagged as "rails.main" and "rails.once", respectively. References #35235.
* | | | Merge pull request #35279 from yahonda/pg_channel_prefixMatthew Draper2019-02-151-0/+1
|\ \ \ \ | |/ / / |/| | | Address uninitialized constant PostgresqlAdapterTest::ChannelPrefixTest (NameError)
| * | | Address uninitialized constant PostgresqlAdapterTest::ChannelPrefixTest ↵Yasuo Honda2019-02-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (NameError) ``` $ bundle exec ruby -w -Itest test/subscription_adapter/postgresql_test.rb Traceback (most recent call last): 1: from test/subscription_adapter/postgresql_test.rb:8:in `<main>' test/subscription_adapter/postgresql_test.rb:10:in `<class:PostgresqlAdapterTest>': uninitialized constant PostgresqlAdapterTest::ChannelPrefixTest (NameError) ``` https://travis-ci.org/rails/rails/jobs/493530508 Follow up #35276
* | | | Merge pull request #35249 from Edouard-chin/ec-config-for-hash-in-arrauRafael Mendonça França2019-02-142-4/+40
|\ \ \ \ | |/ / / |/| | | | | | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:
| * | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:Edouard CHIN2019-02-143-4/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If you have hashes inside array, the hashes were getting initialized as regular HWIA wereas we want them to be NonSymbolAccessDeprecatedHash in order to trigger a deprecation warning when keys are accessed with string. This patch fixes that by overwriting the `[]=` to to the same as what HWIA does (with the difference that we don't call `convert_key` to not trigger a deprecation when setting value). I also took the liberty to extract `hash.nested_under_indifferent_access`, into a separate method to allow subclasses to return whatever they want. Inheriting HWIA is not common, but I think it's useful for cases like this one where we want to preprocess reading and writing values in the hash (for deprecation purposes or other reasons).
* | | | feat: support channel_prefix in pg subscription adapterVladimir Dementyev2019-02-143-0/+9
| | | |
* | | | Merge pull request #35277 from abhaynikam/minor-doc-update-after-35242Eileen M. Uchitelle2019-02-143-6/+6
|\ \ \ \ | | | | | | | | | | Minor changes to deprecation warning message after #35242
| * | | | Minor changes to deprecation warning message after 35242Abhay Nikam2019-02-153-6/+6
| | | | |
* | | | | Merge pull request #35268 from abhaynikam/35252-add-delegate-for-path-for-methodGeorge Claghorn2019-02-142-1/+5
|\ \ \ \ \ | |/ / / / |/| | | | Fixes missing method `path_for` when using MirrorService with DiskService as the primary service
| * | | | Delegated path_for to primary in the MirrorServiceAbhay Nikam2019-02-142-1/+5
| | | | |
* | | | | Merge pull request #35242 from ↵Eileen M. Uchitelle2019-02-143-49/+141
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | eileencodes/add-setter-and-deprecation-for-configurations-hashes Add setter and deprecation for configurations hashes
| * | | | Improve errors and handling of hashes for database configurationseileencodes2019-02-143-49/+141
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In chat Sam Saffron asked how to use the setter now that configurations is no longer a hash and you need to do AR::Base.configurations["test"]=. Technically you can do `ActiveRecord::Base.configurations = { the hash }` but I realized the old way throws an error and is unintuitive. To aid in the transition from hashes to objects this PR makes a few changes: 1) Re-adds a deprecated hash setter `[]=` that will add a new hash to the configurations list OR replace an existing hash if that environment is already present. This won't be supported in future Rails versions but a good error is important. 2) Changed to throw deprecation warnings on the methods we decided to support for hash conversion and raise on the methods we don't support. 3) Refactored the setter/getter hash deprecation warnings messages and rewrote them. Getters message: ``` DEPRECATION WARNING: `ActiveRecord::Base.configurations` no longer returns a hash. Methods that act on the hash like `values` are deprecated and will be removed in Rails 6.1. Use the `configs_for` method to collect and iterate over the database configurations. ``` Setter message: ``` DEPRECATION WARNING: Setting `ActiveRecord::Base.configurations` with `[]=` is deprecated. Use `ActiveRecord::Base.configurations=` directly to set the configurations instead. ``` 4) Rewrote the legacy configurations test file to test all the public methods in the DatabaseConfigurations class.
* | | | | Register new autoloading in AS CHANGELOG [ci skip]Xavier Noria2019-02-141-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is too much to say about it for a CHANGELOG entry, and linking to the original PR could mislead if there are later changes as already happened with the gem dependency, so just a one-liner. For final we'll up to date documentation.
* | | | | Merge pull request #35261 from rails/zeitwerk-as-dependencyXavier Noria2019-02-137-25/+13
|\ \ \ \ \ | | | | | | | | | | | | Let Zeitwerk be a dependency of Active Support
| * | | | | Let Zeitwerk be a dependency of Active SupportXavier Noria2019-02-137-25/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Zeitwerk is a strong dependency, planned to replace AS::Dependencies. A line in the generated Gemfile does not convey this as much.
* | | | | | Merge pull request #35266 from ricardotk002/use-dir-childrenRyuta Kamizono2019-02-142-11/+4
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Use Dir#children and Dir#each_child in ActiveSupport::Cache::FileStore
| * | | | | Use Dir#children and Dir#each_child instead of excluding "." and ".."Ricardo Díaz2019-02-132-11/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Both methods were introduced in Ruby 2.5 and fit this use case very nicely: listing a directory's entries excluding the "." and ".." nodes. The private method #exclude_from was removed as it no longer serves its original purpose.
* | | | | | Add test for `csp_meta_tag`yuuji.yaginuma2019-02-141-0/+31
|/ / / / /
* | | | | Merge pull request #35238 from gwincr11/cg-active-job-queue-timeRafael Mendonça França2019-02-134-2/+20
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | Adding enque time tracking and logging
| * | | | Adding enque time tracking and loggingCory Gwin @gwincr112019-02-134-2/+20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Motivation: - Currently we have 2 seperate monkey patches in place for tracking enqueded time for 2 seperate workers. It seems that activejob could be a source of truth for how long an item has been enqued so that we can easily use it for consistent monitoring across workers/apps to ensure that jobs are running at an acceptable speed. Changes: - Add an enqueded at attribute and serilization tooling. - Add a method to get how long a job has been enqueded for. - Add a logging item to show how long a job was enqued prior to the perform method firing.
* | | | Merge pull request #35258 from kamipo/revert_32380Ryuta Kamizono2019-02-146-15/+7
|\ \ \ \ | | | | | | | | | | Revert "Chaining named scope is no longer leaking to class level querying methods"
| * | | | Revert "Chaining named scope is no longer leaking to class level querying ↵Ryuta Kamizono2019-02-146-15/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | methods" This reverts #32380, since this may cause that silently leaking information when people upgrade the app. We need deprecation first before making this.
* | | | | Merge pull request #35253 from rails/cached-collections-must-have-a-templateAaron Patterson2019-02-132-3/+22
|\ \ \ \ \ | |_|/ / / |/| | | | Cached collections only work if there is one template
| * | | | Cached collections only work if there is one templateAaron Patterson2019-02-132-3/+22
| | | | | | | | | | | | | | | | | | | | | | | | | Cached collections only work if there is one template. If there are more than one templates, the caching mechanism doesn't have a key.
* | | | | Refactors a loopXavier Noria2019-02-131-6/+8
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I believe the current style does not clearly communicate that we are ignoring non-existing autoload paths altogether. Your eyes may even be looking for an else clause that is easy to miss but that does not exist. With the early `next` and code comment the loop reads better for my taste.
* | | | Merge pull request #35255 from kamipo/fix_useless_assignmentRafael França2019-02-132-5/+1
|\ \ \ \ | | | | | | | | | | Address to useless assignment `formats = nil` after #35254
| * | | | Address to useless assignment `formats = nil` after #35254Ryuta Kamizono2019-02-142-5/+1
|/ / / / | | | | | | | | | | | | https://codeclimate.com/github/rails/rails/pull/35254
* | | | Merge pull request #35254 from abhaynikam/35229-some-minor-cleanupAaron Patterson2019-02-131-2/+2
|\ \ \ \ | | | | | | | | | | Clean for fix done in #35229. Removed unused arguments for `build_lookup_context `
| * | | | Clean for fix done in #35229. Removed unused argumentsAbhay Nikam2019-02-131-2/+2
|/ / / /
* | | | Merge pull request #35229 from rails/fix-35222Aaron Patterson2019-02-1319-29/+111
|\ \ \ \ | | | | | | | | | | Convert lookup context's to a stack for fixing #35222 and #34138
| * | | | Turn lookup context in to a stack, push and pop if formats changeAaron Patterson2019-02-119-29/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit keeps a stack of lookup contexts on the ActionView::Base instance. If a format is passed to render, we instantiate a new lookup context and push it on the stack, that way any child calls to "render" will use the same format information as the parent. This also isolates "sibling" calls to render (multiple calls to render in the same template). Fixes #35222 #34138
| * | | | Adding another failing test caseAaron Patterson2019-02-1111-6/+39
| | | | |
| * | | | Add a failing test for #35222Aaron Patterson2019-02-115-0/+14
| |/ / /
* | | | Merge pull request #35244 from palkan/fix/activerecord-database-uri-resolveEileen M. Uchitelle2019-02-132-1/+11
|\ \ \ \ | | | | | | | | | | Fix database configurations building when DATABASE_URL present
| * | | | Fix database configurations building when DATABASE_URL presentVladimir Dementyev2019-02-122-1/+11
| | | | |
* | | | | Don’t log recipients when sending mailJaap van der Plas2019-02-135-10/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since production applications typically run with log level info and email adresses should be considered as sensitive data we want to prevent them from ending up in the logs. In development mode (with log level debug) they are still logged as part of the Mail::Message object.
* | | | | Revert "Merge pull request #35127 from bogdan/counter-cache-loading"Ryuta Kamizono2019-02-133-47/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit eec3e28a1abf75676dcee58308ee5721bb53c325, reversing changes made to 5588fb4802328a2183f4a55c36d6703ee435f85c. Reason: Marking as loaded without actual loading is too greedy optimization. See more context #35239. Closes #35239. [Edouard CHIN & Ryuta Kamizono]
* | | | | Support running AR isolated tests in parallelMatthew Draper2019-02-131-4/+35
| |_|_|/ |/| | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-16 14:12:30 +0000