| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Fix rake db:structure:dump on Postgres when multiple schemas are used
Conflicts:
activerecord/CHANGELOG.md
Closes #22346.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If postgresql is being used and there are multiple schemas listed on the
`schema_search_path`, then `structure.sql` dumps (triggered by `rake
db:structure:dump` or `config.active_record.schema_format = :sql`) began
failing in Rails 4.2.5.
This is due to the changes made in
https://github.com/rails/rails/pull/17885 The problem is that multiple
schemas were getting getting passed to `Kernel.system` as a single,
space delimited string argument (for example, "--schema=foo
--schema=bar"). However, with the updated array style of calling
`Kernel.system`, these need to be passed as separate arguments (for
example, "--schema=foo", "--schema=bar"). If they get passed as a single
string, then the underlying pg_dump program isn't sure how to interpret
that single argument and you'll get an error reporting: "pg_dump: No
matching schemas were found"
|
|\ \
| | |
| | | |
Refactor `AbstractAdapter#initialize`
|
| | |
| | |
| | |
| | | |
`pool` in args is unused anymore. And `config` is used in all adapters.
|
|\ \ \
| | | |
| | | | |
Fix indentation in CHANGELOG.md [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Move some bind related test cases from finder_test.rb to sanitize_t…
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`replace_named_bind_variables` and `replace_bind_variables` are
definded in `sanitization.rb`, so it is reasonable these tests are
on `sanitize_test.rb`.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Document message validation option accepts Proc [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add `Routing` namespace to point appropriate constant
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Make it clear we use `ActionDispatch::Routing::Endpoint`
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Bugfix collection association #create method
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When same association is loaded in the model creation callback
The new object is inserted into association twice
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
kamipo/connection_options_is_only_needed_for_mysql_adapter
`connection_options` is only needed for `MysqlAdapter`
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Not needed for `Mysql2Adapter` and `AbstractMysqlAdapter`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Added dollarsign to the README.md for consistancy [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] add `controller:` argument to routing.md
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Passing a `Symbol` to the `to:` argument for a `get` route requires a `controller` argument to also be defined.
The documentation is missing the `controller:` argument, which leaving out raises a routing exception:
```ruby
get 'profile', to: :show
```
```
$ rake routes
ArgumentError: Missing :controller key on routes definition, please check your routes.
```
Adding the `controller:` argument maps the route correctly:
```ruby
get 'profile', to: :show, controller: 'users'
```
```
$ rake routes
profile GET /profile(.:format) users#show
```
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix set_autoload_paths and set_load_path document [ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Brush up errors of `ActionDispatch::Routing::Mapper#mount`
|
| | |_|_|/ / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
* Integrate to raise `ArgumentError`
* Detailed error message when `path` is not defined
* Add a test case, invalid rack app is passed
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
[ci skip] Add author's name to CHANGELOG
|
| | |_|_|_|/ / /
| |/| | | | | | |
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
disable rails minitest extension in rails plugin
|
|/ / / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The failure have returned, so disabling the tests again. (The upgrade is
fine to keep.)
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
See https://github.com/rails/rails/commit/14b20ce9b38314943dcaf73b8dab7508b70ba487.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
In url_for, never append ? when the query string is empty anyway.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
It used to behave like this:
url_for(controller: 'x', action: 'y', q: {})
# -> "/x/y?"
We previously avoided empty query strings in most cases by removing
nil values, then checking whether params was empty. But as you can
see above, even non-empty params can yield an empty query string. So
I changed the code to just directly check whether the query string
ended up empty.
(To make everything more consistent, the "removing nil values"
functionality should probably move to ActionPack's Hash#to_query, the
place where empty hashes and arrays get removed. However, this would
change a lot more behavior.)
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
rails/revert-22415-prepared_statements_for_mysql2_adapter
Revert "Add prepared statements support for `Mysql2Adapter`"
|
|/ / / / / / / / |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
In listen 3.0.4 and below, the `#stop` method on the notification
backends are a no-op, meaning that we are leaking them per test. This
ended up triggering another bug in Ruby that causes our builds to fail
randomly on CI.
listen bug: https://github.com/guard/listen/issues/353
ruby bug: https://bugs.ruby-lang.org/issues/11744
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Add prepared statements support for `Mysql2Adapter`
|
| | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Add option to verify Origin header in CSRF checks
[Jeremy Daer + Rafael Mendonça França]
|
| | | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | | |
Docs: ActiveRecord::QueryMethods#joins [ci skip]
|
| | |/ / / / / / / /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
[ci skip]
|
|/ / / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
There is a known issue with the listen tests that casuses files to be
incorrectly GC'ed even when they are still in-use. The current is to
only run them in isolation to avoid randomly failing our test suite.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Remove <br> from scaffold form, in favor of using CSS
|
| | | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / /
|/| | | | | | | | | |
do not show Active Job test generator
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Like the other generator, for also Active Job, I think that there is no need to
display for test generator.
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | | |
Remove unused code
|
|/ / / / / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Looking at the history of this file it seems this code was never actually used.
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | | |
Fix wrong timezone mapping for Switzerland (no deprecation warn) [22233]
|
| | | | | | | | | | | |
|