aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | fix link to `resque` [ci skip]yuuji.yaginuma2016-09-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `1-x-stable` branch does not exist, `master` is 1.x branch. Ref: http://words.steveklabnik.com/rescuing-resque-again
* | | | | | | | | Merge pull request #26552 from rafaelfranca/fix-errors-details-storageRafael França2016-09-193-15/+32
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Always store errors details information with symbols
| * | | | | | | | Always store errors details information with symbolsRafael Mendonça França2016-09-193-15/+32
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the association is autosaved we were storing the details with string keys. This was creating inconsistency with other details that are added using the `Errors#add` method. It was also inconsistent with the `Errors#messages` storage. To fix this inconsistency we are always storing with symbols. This will cause a small breaking change because in those cases the details could be accessed as strings keys but now it can not. The reason that we chose to do this breaking change is because `#details` should be considered a low level object like `#messages` is. Fix #26499. [Rafael Mendonça França + Marcus Vieira]
* | | | | | | | Merge pull request #26447 from kamipo/reduce_array_allocationSantiago Pastorino2016-09-191-3/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Reduce array allocation when `where` with passed hash
| * | | | | | | | Reduce array allocation when `where` with passed hashRyuta Kamizono2016-09-101-3/+1
| | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In most case `where` is called with passed hash. In the case initializing `binds` is unnecessary.
* | | | | | | | Merge pull request #26543 from y-yagi/use_rails_command_in_restart_testKasper Timm Hansen2016-09-191-7/+7
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | use rails command in restart task test
| * | | | | | | | use rails command in restart task testyuuji.yaginuma2016-09-191-7/+7
| | |_|_|/ / / / | |/| | | | | |
* | | | | | | | Merge pull request #26448 from kamipo/remove_collection_association_uniqKasper Timm Hansen2016-09-181-1/+0
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | Remove unnecessry `alias uniq distinct` for collection association
| * | | | | | | Remove unnecessry `alias uniq distinct` for collection associationRyuta Kamizono2016-09-101-1/+0
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | `CollectionAssociation` is internal class and `uniq` is not called.
* | | | | | | Merge pull request #26534 from Neodelf/new_branch_nameJon Moss2016-09-177-7/+7
|\ \ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | [ci skip] Fixed commas according to Oxford comma in rdoc and guides
| * | | | | | [ci skip] Fixed commas according to Oxford comma in rdoc and guidesAndrey Molchanov2016-09-177-7/+7
| | | | | | |
* | | | | | | Merge pull request #26446 from kamipo/rename_type_var_name_to_typeEileen M. Uchitelle2016-09-171-10/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Rename variable name that returning `type_for` to `type` from `column`
| * | | | | | | Rename variable name that returning `type_for` to `type` from `column`Ryuta Kamizono2016-09-111-10/+8
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `column_for` was changed to `type_for` to return `type` object at 36bd52b4. But variable name is still `column`. It is very confusing. Rename variable name `column` to `type` for readability.
* | | | | | | Merge pull request #26497 from koppen/26496-touch_with_optimistic_lockingEileen M. Uchitelle2016-09-173-1/+9
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Clear attribute changes after handling locking
| * | | | | | | Clear attribute changes after handling lockingJakob Skjerning2016-09-143-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this the changes to the lock version column will stick around even after `touch` returns. Before: model.touch model.changes # => {"lock_version"=>[0, "1"]} After: model.touch model.changes # {}
* | | | | | | | Merge pull request #26532 from Neodelf/new_branch_nameप्रथमेश Sonpatki2016-09-171-2/+11
|\ \ \ \ \ \ \ \ | | |_|/ / / / / | |/| | | | | | [ci skip] Fix bad examples in rdoc
| * | | | | | | [ci skip] Fix bad examples in rdocAndrey Molchanov2016-09-171-2/+11
|/ / / / / / /
* | | | | | | Merge pull request #26528 from y-yagi/fix_formatting_of_fetchप्रथमेश Sonpatki2016-09-171-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | fix formatting of `Cache::Store#fetch` [ci skip]
| * | | | | | | fix formatting of `Cache::Store#fetch` [ci skip]yuuji.yaginuma2016-09-171-3/+3
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | Single backticks don't work with rdoc.
* | | | | | | Merge pull request #26523 from maclover7/jm-grammar-26382Rafael França2016-09-161-1/+2
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fix small grammar issue introduced in #26382
| * | | | | | Fix small grammar issue introduced in #26382Jon Moss2016-09-161-1/+2
|/ / / / / / | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #26516 from grosser/grosser/assertRafael França2016-09-1675-362/+362
|\ \ \ \ \ \ | | | | | | | | | | | | | | improve error message when include assertions fail
| * | | | | | improve error message when include assertions failMichael Grosser2016-09-1675-362/+362
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
* | | | | | Merge pull request #26514 from louim/patch-1Rafael França2016-09-161-8/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update ActiveModel::Dirty Doc to be simpler to understand
| * | | | | | Update ActiveModel::Dirty Doc [ci skip]Louis-Michel Couture2016-09-161-8/+8
| |/ / / / /
* | | | | | Merge pull request #26509 from claudiob/rename-asRafael França2016-09-161-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Rename test to match what it does
| * | | | | | Rename test to match what it doesclaudiob2016-09-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit d270da569 changed the `form_for` API from `:object_name` to `:as`. It also change the related test body, but not its title, which is changed here. See https://github.com/rails/rails/commit/d270da569efeabd7cd563028816452236713aa9f#diff-52455f1e82acf12551bc5e7e26b82008 I realize this is a small commit but I was having trouble understanding what the test was about since there is no "object_name" in the code. I imagine the same may happen to other developers, therefore this commit.
* | | | | | | Merge pull request #26507 from Neodelf/actionview_duplicateRafael França2016-09-162-6/+2
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | DRYing duplicate methods
| * | | | | | DRYing duplicate methodsAndrey Molchanov2016-09-162-6/+2
| | | | | | |
* | | | | | | Force correct namespace when using TransactionManagerArthur Neves2016-09-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [fixes #26441]
* | | | | | | Merge pull request #26510 from y-yagi/fix_typo_in_add_column_docJon Moss2016-09-151-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | fix typo in `add_column` doc [ci skip]
| * | | | | | | fix typo in `add_column` doc [ci skip]yuuji.yaginuma2016-09-161-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #26508 from louim/patch-1Jon Moss2016-09-151-1/+1
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Update ActiveModel::Dirty Doc [ci skip]
| * | | | | | | Update ActiveModel::Dirty Doc [ci skip]Louis-Michel Couture2016-09-151-1/+1
|/ / / / / / / | | | | | | | | | | | | | | Fix potentially misleading example.
* | | | | | | bug report template for migrations (#26488)Girish Sonawane2016-09-153-0/+130
| | | | | | | | | | | | | | | | | | | | | * added bug report template for migrations
* | | | | | | Merge pull request #26469 from y-yagi/remove_useless_optionRafael França2016-09-141-5/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | remove useless `gemfile` option
| * | | | | | | remove useless `gemfile` optionyuuji.yaginuma2016-09-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails application for test creates with `--skip-gemfile` option. https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L333 Therefore, regardless of the option, Gemfile is not created.
* | | | | | | | Merge pull request #26498 from FriedSock/correct-render-text-deprecation-messageRafael França2016-09-141-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Correct `render text:` deprecation message
| * | | | | | | | Correct `render text:` deprecation messageJack Bracewell2016-09-141-1/+1
| | |_|_|/ / / / | |/| | | | | | | | | | | | | | The default Content-Type is `text/html`, not `text/plain`.
* | | | | | | | Merge pull request #26477 from kirs/action_dispatch-assert_responseRafael França2016-09-142-2/+29
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Improve assert_response helper
| * | | | | | | Improve assert_response helperKir Shatrov2016-09-142-2/+29
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the check is failed, print the actual response body if it's not too large. This could improve productivity when writing new tests. Before: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 ``` After: ``` ThemeEditorIntegrationTest#test_whatever Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>. Expected: 200 Actual: 422 Response body: {"errors":["Invalid settings object for section '1'"]} ```
* | | | | | | Merge pull request #26487 from prathamesh-sonpatki/move-preload-section-upRichard Schneeman2016-09-141-7/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Move comment about disconnecting pool close to comment about preload
| * | | | | | | Move comment about disconnecting pool close to comment about preloadPrathamesh Sonpatki2016-09-141-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - These two comments are connected to each other so kept them back to back.
* | | | | | | | Merge pull request #26486 from y-yagi/fix_broken_testRafael França2016-09-141-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | fix broken generators test
| * | | | | | | | fix broken generators testyuuji.yaginuma2016-09-142-2/+2
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
* | | | | | | | Fix test for the edge generatorRafael Mendonça França2016-09-141-1/+1
| | | | | | | |
* | | | | | | | Override the github git source instead of changing manually all entriesRafael Mendonça França2016-09-142-62/+68
| |_|_|/ / / / |/| | | | | |
* | | | | | | Merge pull request #26489 from kamipo/fix_broken_comments_indentationXavier Noria2016-09-1467-1665/+1670
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fix broken comments indentation caused by rubocop auto-correct [ci skip]
| * | | | | | Fix broken comments indentation caused by rubocop auto-correct [ci skip]Ryuta Kamizono2016-09-1467-1665/+1670
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
* | | | | | Do not point to the 5-0-stable branchRafael Mendonça França2016-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Master based applications should be pointing to master
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-28 16:20:30 +0000