| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Make AC::Params.permit_all_parameters thread safe
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
As discussed in #16299[1], this attribute is not thread safe and could
potentially create a security issue.
[1]: https://github.com/rails/rails/pull/16299#discussion_r15424533
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix default queue name prefix delimiter
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Now displays as underscore, and not an empty string, when converted from markdown to HTML.
Escaped the underscore per http://daringfireball.net/projects/markdown/syntax#em
Fixes rails/rails#18009
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
English fix [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove custom errors page section from the guides [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This pattern is too problematic and introduces a lot of edge cases:
* On 4.2, the issue https://github.com/rails/rails/issues/15124 is
back again.
* needs to define each action for each http status otherwise the
router raises ActionController::RoutingError (No route matches).
* If the router has `match "/*username",...` and some action is
missing, Rails will pick up the "match" and try to do its job.
* encourages people to copy & paste programming. Not DRY.
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/rails/rails/commit/39542fba54328ca048fb75a5d5b37f8e1d4c1f37#commitcomment-8938379
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix ProtocolViolation/bind message for polymorphic + pluck or group+calc
|
| | |_|_|/ /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Update guides with info about vendor/assets [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
fixes #17893
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix undesirable RangeError by Type::Integer. Add Type::UnsignedInteger.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Refactor `quoted_date`
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
Move microseconds formatting to `AbstractAdapter`.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit b0e7278ddbe483475d7b2e161e65ae18df91b9f8, reversing
changes made to 785d04e3109f69d0b9b9f4732179592f0ef04e52.
This is not true. It is a bug and we will fix in the latest 4.0.x
release.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add foreign_type option for polymorphic has_one and has_many.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
To be possible to use a custom column name to save/read the polymorphic
associated type in a has_many or has_one polymorphic association, now users
can use the option :foreign_type to inform in what column the associated object
type will be saved.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] fix typo in MessageVerifier#verify docs
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Adding information about 'allow_nil' option for 'numericality' [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add guides for `required` model generator option
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Related to this PR #16062
[ci skip]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Testing Guides: adding TIP about database permission problems [ci skip]
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
loading fixtures to the database.
Reference #17542
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix options overwritten by super
|
|/ / / / / / |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused "Developer" fixtures from tests
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The `RecursiveCallbackDeveloper` and `ImmutableMethodDeveloper` classes
are not used anymore in tests, and neither is the `@cancelled` variable.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Fix typo
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The test added in 42418cfc94d1356d35d28d786f63e7fab9406ad6 wasn't
actually testing anything, since the bug was with TZ aware attributes
only.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
PostgreSQL for example, allows infinity as a valid value for date time
columns. The PG type has explicit handling for that case. However, time
zone conversion will end up trampling that handling. Unfortunately, we
can't call super and then convert time zones.
However, if we get back nil from `.in_time_zone`, it's something we
didn't expect so we can let the superclass handle it.
Fixes #17971
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`freeze` will ultimately end up freezing the `AttributeSet`, which in
turn freezes its `@attributes` hash. However, we actually insert a
special object to lazily instantiate the values of the hash on demand.
When it does need to actually instantiate all of them for iteration (the
only case is `ActiveRecord::Base#attributes`, which calls
`AttributeSet#to_h`), it will set an instance variable as a performance
optimization
Since it's just an optimization for subsequent calls, and that method
being called at all is a very uncommon case, we can just leave the ivar
alone if we're frozen, as opposed to coming up with some overly
complicated mechanism for freezing which allows us to continue to modify
ourselves.
Fixes #17960
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The user is able to pass PG string literals in 4.1, and have it
converted to an array. This is also possible in 4.2, but it would remain
in string form until saving and reloading, which breaks our
`attr = save.reload.attr` contract. I think we should deprecate this in
5.0, and only allow array input from user sources. However, this
currently constitutes a breaking change to public API that did not go
through a deprecation cycle.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Also avoid using try since is_a? is faster for this case.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
carols10cents/improve-after-commit-argumenterror-message
Make error message clearer that :on requires a symbol, not a string
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The validation added in 5a3dc8092d19c816b0b1203945639cb91d065847 will
reject values for the `:on` option for after_commit and after_rollback
callbacks that are string values like `"create"`.
However, the error message says ":on conditions for after_commit and
after_rollback callbacks have to be one of create,destroy,update". That
looks like a string value *would* be valid.
This commit changes the error message to say ":on conditions for
after_commit and after_rollback callbacks have to be one of [:create,
:destroy, :update]", making it clearer that symbols are required.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fixing mailer previews for apps with globbing route
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
add brackets around attribute_name [ci skip]
|
| | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
since 'attr_name_will_change!' is not an actual method it should
be clearer that you have to insert the attribute name as in line 104
[ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add note to Store about uniqueness validation (#17954) [skip ci]
|
| |/ / / / / / |
|