| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add schema cache to new connection pool after fork
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Active Record detects when the process has forked and automatically
creates a new connection pool to avoid sharing file descriptors.
If the existing connection pool had a schema cache associated with it,
the new pool should copy it to avoid unnecessarily querying the database
for its schema.
The code to detect that the process has forked is in ConnectionHandler,
but the existing test for it was in the ConnectionManagement test file.
I moved it to the right place while I was writing the new test for this
change.
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Added ActionDispatch::Journey::Routes#empty?
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Refactoring `ActiveRecord::Type::Integer` limit
|
| | | | | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Divide methods for handling column options separately
|
| | | |_|/ / / / / /
| |/| | | | | | | |
|
| |\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
Fix `serial?` with quoted sequence name
|
| | |/ / / / / / / |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
docs for updating nested attributes while creating parent record
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
skip]
|
| | |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
We must account for receiving one less call to #new_connection, but the
test otherwise remains valid.
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This patch
- reduces the duplication among the `reference`-family methods.
- better explains all the optians available for `add_reference`.
- redirects to user from `references` to `add_reference`.
Originated by #20184.
|
| |\ \ \ \ \ \ \ \
| |_|_|_|_|_|/ /
|/| | | | | | | |
[ci skip] remove `assigns` from the integration test example in API docs
|
| |/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Based on #19976 and #18305.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
vngrs/fix_wrong_default_value_of_javascript_engine
config.generators javascript_engine default value is :js not nil
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
formatting changes for mail options
|
| | |/ / / / / / / |
|
| |\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
vngrs/add_missing_documentation_about_generators_resource_route
add missing documentation about generators resource_route [ci skip]
|
| |/ / / / / / / |
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
[ci skip] remove unnecessary mention to Test::Unit from docs
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix the guide to state that Rails uses Minitest as the default test
framework.
Remove unnecessary mention to Test::Unit from the API docs
('constantize' and 'safe_constantize').
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Improve grammar/syntax in AR validations docs.
|
| | | |_|_|_|/
| |/| | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Pass over CHANGELOGS [ci skip]
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Reducing AR::ConPool's critical (synchronized) section
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Renamed `@reserved_connections` -> `@thread_cached_conns`. New name
clearly conveys the purpose of the cache, which is to speed-up
`#connection` method.
The new `@thread_cached_conns` now also uses `Thread` objects as keys
(instead of previously `Thread.current.object_id`).
Since there is no longer any synchronization around
`@thread_cached_conns`, `disconnect!` and `clear_reloadable_connections!`
methods now pre-emptively obtain ownership (via `checkout`) of all
existing connections, before modifying internal data structures.
A private method `release` has been renamed `thread_conn_uncache` to
clear-up its purpose.
Fixed some brittle `thread.status == "sleep"` tests (threads can go
into sleep even without locks).
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Move post checkout connection verification out of mutex.synchronize.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove redundant require 'set' lines
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Dead blog/site links [ci skip]
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
remove warning from integer ext test
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
this removes the following warning:
```
test/core_ext/integer_ext_test.rb:34: warning: ambiguous first argument; put parentheses or a space even after `-' operator
test/core_ext/integer_ext_test.rb:38: warning: ambiguous first argument; put parentheses or a space even after `-' operator
```
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Do not put partial name to local_assigns when rendering without an object
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When one rendered a partial template without specifying an object
or a collection (e.g. <%= render partial: 'partial_name' %>), Rails
would make an object called :partial_name available in local_assigns.
I don't think this was the intended behavior, since no local variable
called 'partial_name' gets defined in the view.
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
[ci skip] Remove comments about Rails 3.1
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939
where @senny said:
> From my point of view, all the docs (guides, API) are version bound.
> They should describe that version and continue to be available when newer versions are released.
> The cross referencing can be done by the interested user.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Improve phrasing in AR migrations docs.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* insert 'and' into a poorly formed sentence.
* avoid using 'reverse' twice in the same sentence (which would indicate
the opposite of what is meant)
|
| |\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Rails documentation standard is american english. [ci skip]
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
remove redundant parenthesis
|
| | | | | | | | |
|
