| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
- [Rails <= 5.0](https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/commands/test.rb#L6) used to add the `<app_root>/test` as a string; this behaviour changed in rails 5.1, it's appending a `Pathname` object
|
|\
| |
| | |
Log subscriber - avoid rescuing certain exceptions
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
halogenandtoast/mm-mailer-delayed-job-documentation
Document setting the delivery_job for ActionMailer [ci skip]
|
|/ / |
|
|\ \
| | |
| | | |
[ActiveModel] Improve the performance of mass assignments
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Don't map id to primary key in raw_write_attribute
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `raw_write_attribute` method is used to update a record's attributes
to reflect the new state of the database in `update_columns`. The hash
provided to `update_columns` is turned into an UPDATE query directly,
which means passing an `id` key results in an update to the `id` column,
even if the model uses a different attribute as its primary key. When
updating the record, we don't want to apply the `id` column change to
the primary key attribute, since that's not what happened in the query.
Without the code to handle this case, `write_attribute_with_type_cast`
no longer contains any logic shared between `raw_write_attribute` and
`write_attribute`, so we can inline the code into those two methods.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/fix_dump_schema_information_with_empty_versions
Fix `dump_schema_information` with empty versions
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #29460.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add test cases for #28274
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`object.id` is correctly restored since #29378 has merged.
Closes #28274, Closes #28395.
[Ryuta Kamizono & Eugene Kenny]
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Allow mailers to configure their delivery job
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Setting delivery_job on a mailer class will cause MessageDelivery to use
the specified job instead of ActionMailer::DeliveryJob:
class MyMailer < ApplicationMailer
self.delivery_job = MyCustomDeliveryJob
...
end
|
| |_|/ / /
|/| | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Update `working with javascript` readme to support rails-ujs behaviour. [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Allow `uuid_test.rb` to be loaded on all adapters
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Running `bin/test` from the activerecord directory produces this error:
test/cases/adapters/postgresql/uuid_test.rb:43:in `<class:PostgresqlUUIDTest>': undefined method `supports_pgcrypto_uuid?' for #<ActiveRecord::ConnectionAdapters::SQLite3Adapter:0x007fc405e72a68> (NoMethodError)
The test only actually runs on the PostgreSQL adapter; we can avoid
triggering the error on other adapters with this `respond_to?` guard.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Prevent extra `sync_with_transaction_state`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`sync_with_transaction_state` in `to_key` is unneeded because `id` also
does.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Allow translate default option to accept an array similar to i18n.t
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
#29441
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Avoid overwriting the methods of `AttributeMethods::PrimaryKey`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Currently the methods of `AttributeMethods::PrimaryKey` are overwritten
by `define_attribute_methods`. It will be broken if a table that
customized primary key has non primary key id column.
It should not be overwritten if a table has any primary key.
Fixes #29350.
|
|\ \ \ \ \ \ \
| |_|_|_|_|/ /
|/| | | | | |
| | | | | | |
| | | | | | | |
bogdanvlviv/use-require_relative-instead-of_require-with-full-path
Use `require_relative` instead of `require` with full path
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Add test for backward compatibility when using change_table
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Fix formatting of AD::FileHandler and AD::Static doc [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Add note to Railtie docs to use unique filenames
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The fact that the names need to be globally unique was not obvious to me, so I
thought it'd be worth documenting. This not being clear was the cause of both
ctran/annotate_models#468 and instructure/outrigger#1.
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Drop IRB out of the web-console Gemfile comment
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We don't provide exactly the same experience as IRB does, so let's not
advertize it like that. We can say that it's an interactive console,
without further references. I have also followed byebug's comment and
changed the calling `console` part. Hopefully, this can hint that the
invocation is not view specific and you can use it like the debugger
statement.
[ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix `Message::Encryptor` default cipher [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Follow up of #29263
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Default Message Encryptor Cipher to AES-256-GCM From AES-256-CBC
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Introduce a method to select default cipher, and maintain backward compatibility
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Generate field ids in `collection_check_boxes` and `collection_radio_buttons`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This makes sure that the labels are linked up with the fields.
Fixes #29014
|
| | | | | | | | |
|