aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* stop calling `scope` internallyAaron Patterson2015-08-082-13/+24
| | | | | | | we need to get a grip on what `scope` actually does. This commit removes some of the internal calls to `scope`. Eventually we should add public facing methods that provide the API that `scope` is trying to accomplish.
* remove useless conditionalAaron Patterson2015-08-081-1/+1
| | | | | | `prepare_params!` would raise an exception if `params` wasn't initialized, so it must always be available. Remove the existence conditional from the `controller` method.
* eliminate assignment in conditionalAaron Patterson2015-08-081-1/+3
| | | | | The method we called already has the conditional we need. Just add an else block so that we don't need two tests.
* Remove `defaults` hash from `Dispatcher`Aaron Patterson2015-08-082-9/+9
| | | | | | | `Dispatcher` doesn't need to hold on to the defaults hash. It only used the hash to determine whether or not it should raise an exception if there is a name error. We can pass that in further up the stack and alleviate Dispatcher from knowing about that hash.
* eliminate runtime conditionalAaron Patterson2015-08-081-10/+9
| | | | | | We know in advance whether the object is a dispatcher or not, so we can configure the Constraints object with a strategy that will call the right method.
* whitespaceAaron Patterson2015-08-081-3/+3
|
* remove the setter from `Scope`Aaron Patterson2015-08-081-4/+0
| | | | it isn't used.
* Merge pull request #21175 from gringocl/middleware-deprecationsRichard Schneeman2015-08-081-5/+5
|\ | | | | Reference actual classes
| * Reference actual classesMiles Starkenburg2015-08-081-5/+5
| |
* | Merge pull request #21173 from repinel/fix-callback-terminator-docsClaudio B.2015-08-081-3/+3
|\ \ | | | | | | [ci skip] Fix the AS::Callbacks terminator docs
| * | [ci skip] Fix the AS::Callbacks terminator docsRoque Pinel2015-08-081-3/+3
| | | | | | | | | | | | | | | | | | | | | The second argument of the terminator lambda is no longer the result of the callback, but the result lambda. https://github.com/rails/rails/blob/3a7609e2bafee4b071fe35136274e6ccbae8cacd/activesupport/test/callbacks_test.rb#L553
* | | Merge pull request #21166 from brooksreese/migration_seed_explanationClaudio B.2015-08-081-4/+9
|\ \ \ | |_|/ |/| | [ci skip] Give in-depth explanation of migrations vs. seeds.rb
| * | [ci skip] Give in-depth explanation of migrations vs. seeds.rbBrooks Reese2015-08-081-4/+9
| | |
* | | Merge pull request #21174 from melissawahnish/document_gmailRafael Mendonça França2015-08-081-0/+3
|\ \ \ | | | | | | | | [ci skip] Adding a note to Action Mailer Basics documentation that Google increased its security measures
| * | | [ci skip] Adding a note to Action Mailer Basics documentation that Google ↵melissawahnish2015-08-081-0/+3
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | increased its security measures so using the example for Gmail will return a “Password Incorrect” error, and you will receive an email from Google that they blocked a sign-in attempt. You can change your Gmail settings or use another ESP. I discovered this when I was testing a simple mailer example app and was just going to use my personal Gmail account for the test. I think it would be best to note this change since now Gmail may not be the best option for a quick test. I hope this saves time for other Rails developers. The Gmail example does show a good example of how to configure the smpt settings.
* | | Merge pull request #21167 from AaronLasseigne/use_each_keyKasper Timm Hansen2015-08-082-2/+2
|\ \ \ | |_|/ |/| | replace each with each_key when only the key is needed
| * | replace each with each_key when only the key is neededAaron Lasseigne2015-08-082-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using each_key is faster and more intention revealing. Calculating ------------------------------------- each 31.378k i/100ms each_key 33.790k i/100ms ------------------------------------------------- each 450.225k (± 7.0%) i/s - 2.259M each_key 494.459k (± 6.3%) i/s - 2.467M Comparison: each_key: 494459.4 i/s each: 450225.1 i/s - 1.10x slower
* | | Refactor route assertion methods in resources testeileencodes2015-08-081-50/+51
| | | | | | | | | | | | | | | | | | | | | | | | The tests and methods were hard to read with `options[:options]` all over the place. This refactoring makes the code easier to understand. The change came out of work for moving the underlying code of controller tests to integraiton tests.
* | | Merge pull request #11352 from xaviershay/dispatcher-apiRafael Mendonça França2015-08-084-21/+23
|\ \ \ | | | | | | | | Allow a custom dispatcher to be provided to routing.
| * | | Allow a custom dispatcher to be provided to routing.Xavier Shay2015-08-074-19/+17
| | | |
| * | | Move `controller_reference` and `controller_class_names` to protectedXavier Shay2015-08-071-2/+6
| | | | | | | | | | | | | | | | scope so that they are available to subclasses.
* | | | Fix deprecation warning in testseileencodes2015-08-083-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ```
* | | | Rename `extra_keys` variables to `query_string_keys`eileencodes2015-08-082-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | `extra_keys` is a confusing variable name because it's not clear what is "extra". This renames it to `query_string_keys` so it's clear that the "extra" is just the query string.
* | | | Refactor to remove DrawOnce moduleeileencodes2015-08-081-27/+8
| | | | | | | | | | | | | | | | | | | | | | | | We were doing extra work that could be pushed off to Integration test and SharedRoutes. Creating an extra module isn't necessary when those are created by their respective classes.
* | | | Merge pull request #21170 from y-yagi/fix_uuid_exampleAbdelkader Boudih2015-08-081-1/+1
|\ \ \ \ | | | | | | | | | | use uuid method to define the UUID type [ci skip]
| * | | | use uuid method to define the UUID type [ci skip]yuuji.yaginuma2015-08-081-1/+1
|/ / / /
* | | | Merge pull request #21169 from yui-knk/doc/route_statusRichard Schneeman2015-08-071-1/+5
|\ \ \ \ | |/ / / |/| | | [ci skip] Add an explanation for `status` option
| * | | [ci skip] Add an explanation for `status` optionyui-knk2015-08-081-1/+5
|/ / /
* | | deprecate the env method on controller instancesAaron Patterson2015-08-073-2/+4
| | | | | | | | | | | | | | | | | | people should be accessing request information through the request object, not via the env hash. If they really really want at the env hash, then they can get it off the request.
* | | the request object manages `env`Aaron Patterson2015-08-071-2/+0
| | | | | | | | | | | | | | | remove the setter. The request object manages the env hash, so any mutations need to go through it
* | | remove vestigial codeAaron Patterson2015-08-072-82/+0
| | | | | | | | | | | | | | | Looks like this was left over from converting Rails to Rack. I think it's safe to remove now.
* | | stop using @_env in the controller instanceAaron Patterson2015-08-075-7/+14
| | | | | | | | | | | | | | | | | | | | | Actions are processed through `dispatch`, so they should have the request set on them before any user land code can be executed. Lets stop setting _env on the controller, and give access to it through the `env` method.
* | | finish deprecating handling strings and symbolsAaron Patterson2015-08-076-80/+24
| | | | | | | | | | | | | | | since we only work with instances of classes, it greatly simplifies the `Middleware` implementation.
* | | Using strings or symbols for middleware class names is deprecated.Aaron Patterson2015-08-076-50/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert things like this: middleware.use "Foo::Bar" to this: middleware.use Foo::Bar
* | | move `valid?` conditional to the constructorAaron Patterson2015-08-071-11/+21
| | | | | | | | | | | | | | | use a strategy pattern to calculate the conditional in `valid?` in advance.
* | | simplify the Middleware constructorAaron Patterson2015-08-073-57/+54
| | | | | | | | | | | | | | | | | | We should do the hard work outside the constructor. Also fix the tests to not directly construct middleware objects, but to go through the stack object.
* | | use Proc.new to reduce some conditionalsAaron Patterson2015-08-071-3/+1
| | | | | | | | | | | | | | | | | | Proc.new will pick up the passed in block, but since it's a default param, it won't get evaluated unless someone doesn't pass in an app. It will raise an exception if no block is provided.
* | | the request class is never changed, so just use it directly in the method bodyAaron Patterson2015-08-072-6/+6
|/ /
* | Merge pull request #21161 from rails/rm-xml-serializerRafael Mendonça França2015-08-0713-1204/+12
|\ \ | |/ |/| Remove XML Serialization from core
| * Remove XML Serialization from core.Zachary Scott2015-08-0713-1204/+12
| | | | | | | | | | | | | | This includes the following classes: - ActiveModel::Serializers::Xml - ActiveRecord::Serialization::XmlSerializer
* | Regexp#=== is faster than String#=~schneems2015-08-071-1/+1
|/ | | | Discussion https://github.com/JuanitoFatas/fast-ruby/pull/59#issuecomment-128513763
* refactor param parsing middleware to use request objectsAaron Patterson2015-08-072-10/+17
| | | | | this is another place that we should stop directly accessing the env hash and let the request object take care of that for us
* move flash hash access to methods on the request objectAaron Patterson2015-08-071-2/+11
|
* Merge pull request #20933 from siadat/relations-in-batches-using-idsDavid Heinemeier Hansson2015-08-076-12/+413
|\ | | | | in_batches using ids
| * Add ActiveRecord::Relation#in_batchesSina Siadat2015-08-076-12/+413
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `in_batches` yields Relation objects if a block is given, otherwise it returns an instance of `BatchEnumerator`. The existing `find_each` and `find_in_batches` methods work with batches of records. The new API allows working with relation batches as well. Examples: Person.in_batches.each_record(&:party_all_night!) Person.in_batches.update_all(awesome: true) Person.in_batches.delete_all Person.in_batches.map do |relation| relation.delete_all sleep 10 # Throttles the delete queries end
* | Merge pull request #21159 from tcopeland/fix_spelingKasper Timm Hansen2015-08-071-1/+1
|\ \ | | | | | | Fix doc typo
| * | Fix doc typoTom Copeland2015-08-071-1/+1
|/ /
* | Merge pull request #21158 from ↵Rafael Mendonça França2015-08-072-1/+7
|\ \ | |/ |/| | | | | lsylvester/only-invoke-mattr_accessor-default-block-once Prevent the default block for mattr_accessor being called multiple times
| * Only invoke the default block for mattr_accessor once so that it does not ↵Lachlan Sylvester2015-08-072-1/+7
|/ | | | cause issues if it is not idempotent
* Merge pull request #21156 from yui-knk/fix/guide_instumentationMatthew Draper2015-08-071-8/+0
|\ | | | | [ci skip] Remove `identity.active_record`
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-10 08:37:50 +0000