| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Restore ActiveRecord connection to original environment after rake:db:test:prepare task.
|
| | |
|
|\ \
| | |
| | | |
Improving the performance of callbacks
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
callbacks in the CallbackChain, so you don't have to iterate over all
callbacks when checking for duplicates.
Benchmark results when the tests in
activerecord/test/cases/associations_test.rb were run with and without
the change:
== On master (when scanning all of the callbacks):
---------------------------------------------------------
% cumulative self self total
time seconds seconds calls ms/call ms/call name
---------------------------------------------------------
1.85 9.26 0.82 18412 0.04 0.05
ActiveSupport::Callbacks::Callback#matches?
1.22 12.32 0.54 18412 0.03 0.08
ActiveSupport::Callbacks::Callback#duplicates?
0.93 14.61 0.41 19600 0.02 0.21
ActiveSupport::Callbacks::CallbackChain#remove_duplicates
Finished tests in 1.217065s, 30.4010 tests/s, 53.4072 assertions/s.
---------------------------------------------------------
== On my branch (when using a hash to check callback duplication):
---------------------------------------------------------
% cumulative self self total
time seconds seconds calls ms/call ms/call name
---------------------------------------------------------
0.15 29.63 0.06 1188 0.05 0.72
ActiveSupport::Callbacks::CallbackChain#handle_duplicates
0.00 40.50 0.00 84 0.00 0.12
ActiveSupport::Callbacks::Callback#matches?
0.00 40.50 0.00 84 0.00 0.12
ActiveSupport::Callbacks::Callback#duplicates?
0.00 40.50 0.00 91 0.00 0.22
ActiveSupport::Callbacks::CallbackChain#scan_and_remove_duplicates
Finished tests in 1.117757s, 33.1020 tests/s, 58.1522 assertions/s.
---------------------------------------------------------
|
|\ \
| | |
| | | |
Add parameter :sslcompression to PostgreSQL adapter.
|
| | |
| | |
| | |
| | | |
It is new in PostgreSQL-9.2 .
|
|\ \ \
| |/ /
|/| | |
Add styling to h1 for default rescue layout
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Refactoring the creation of TestTasks to remove code duplication.
|
|/ / |
|
|\ \
| | |
| | | |
Add test for `AR::Base#to_param`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
According to the doc of `AR::Base#to_param`(
https://github.com/rails/rails/blob/04cda1848cb847c2bdad0bfc12160dc8d554
7775/activerecord/lib/active_record/integration.rb#L18 ), it returns
`nil` if the record is not persisted.
|
|\ \ \
| | | |
| | | | |
Fix typo in test
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Fixes Dependency bug in Active Support
|
|/ / /
| | |
| | |
| | | |
DateTime defined in date.rb
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Extract tests code out from AR's base_test.rb to integration_test.rb
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`AR::Base#to_param` and `AR::Base#cache_key` is defined at
active_record/integration.rb, so tests for those methods should be at
integration_test.rb
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
patricksrobertson/convert_activemodel_to_new_hash_syntax
Convert ActiveModel to 1.9 hash syntax.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
I also attempted to fix other styleguide violations such as
{ a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
chancancode/handle_aliased_attributes_in_ar_relation
Handle aliased attributes in AR::Relation
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When using symbol keys, ActiveRecord will now translate aliased attribute names to the actual column name used in the database:
With the model
class Topic
alias_attribute :heading, :title
end
The call
Topic.where(heading: 'The First Topic')
should yield the same result as
Topic.where(title: 'The First Topic')
This also applies to ActiveRecord::Relation::Calculations calls such as `Model.sum(:aliased)` and `Model.pluck(:aliased)`.
This will not work with SQL fragment strings like `Model.sum('DISTINCT aliased')`.
Github #7839
*Godfrey Chan*
|
| | | | |
| | | | |
| | | | |
| | | | | |
Introduced in 09ac1776abc0d3482f491f2d49f47bcb3d9a4ad7.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Use constant for encoding
|
| | |_|/
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Allow override of PostgreSQL UUID primary key default
|
| |/ / /
| | | |
| | | |
| | | | |
without this, it's not possible to use UUID primary keys without uuid-ossp installed and activated
|
|\ \ \ \
| |/ / /
|/| | | |
Make railties version match RAILS_VERSION
|
|/ / / |
|
|\ \ \
| |_|/
|/| | |
Remove varargs from `Object#in?`
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit ebf69ab1636df74c76332c53bcd3d8494fb91b45.
`in?` must not take multiple parameters because its behavior would be
ambiguous:
# Test if "B" is included in a list of names with `"B".in?(*names)`:
names = ["BMorearty"]
"B".in?(*names) # => true
names = ["BMorearty","rubyduo"]
"B".in?(*names) # => false
Conflicts:
activesupport/lib/active_support/core_ext/object/inclusion.rb
activesupport/test/core_ext/object/inclusion_test.rb
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
Same rationale as previous revert.
This reverts commit 887225e69b6cdd27f00cf043c4ac918ca5e18cbf.
|
|/
|
|
|
|
|
| |
It is not in the contract that flags have to be singletons,
the use of regular font indicates that.
This reverts commit 80036f9a5341bd831d125dc684841a8433d92070.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
* it's Action Mailer not ActionMailer
* it's Action Pack not ActionPack
* it's Active Support not ActiveSupport
/cc @fxn
|
| |
| |
| |
| | |
/cc @fxn
|
| | |
|
| |
| |
| |
| | |
guide already in this folder.
|
| | |
|
| | |
|
| |\ |
|
| | | |
|