| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| | | | | |
| | | | | | |
Suppress `WARNING: nonstandard use of \\ in a string literal` warning
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
by setting `escape_string_warning = off`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Tried to make the sentence read more clearly.
[ci skip]
|
| |/ / /
|/| | |
| | | |
| | | |
| | | | |
These tests double-stub connection.pubsub, so we need to ensure the
first call's completed before we set up for the second.
|
|\ \ \ \
| | | | |
| | | | | |
[PostgreSQL] Replace deprecated PG constants.
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
The old top level classes PGconn, PGresult and PGError were deprecated
since pg-0.13.0: https://github.com/ged/ruby-pg/blob/master/History.rdoc#v0130-2012-02-09-michael-granger-gedfaeriemudorg
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
names and simplify error logging to a single line when not
|
|\ \ \
| | | |
| | | | |
[docs] fix ActionDispatch documentation
|
| | | | |
|
| | | | |
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Wrap stored accessors in parameters
|
| | | |
| | | |
| | | |
| | | | |
Modified params wrapper to account for model's stored_attributes
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit c6f9f8c28a720ad4ec7cf3613dddfa451d5968e2, reversing
changes made to c309073c7476f50dfb1e796d058580f176101c36.
Reason: This is fixing the behavior in the wrong place. Now the request
path after the request is nil and there is no way to assert that.
Also the test that was added in that PR also fails in 4.2 where the
reporter says it was passing. The reason the bahavior changed between
Rails 4.2 and Rails 5 is that the format in the path is now respected.
The correct way to fix the problem is not doign two requests in the same
controller test and use integrations tests. This change caused a
regression between Rails 5.0.1 and 5.0.2.
|
|\ \ \
| | | |
| | | | |
Fix typo in actionview error message in to_form_params helper method
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix where_clause#except with specific where value
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes a regression introduced in
22ca710f20c3c656811df006cbf1f4dbc359f7a6 where Relation#unscope with a
specific where value (vs unscoping the entire where clause) could result
in the wrong binds being left on the query.
This was caused by an index variable not being incremented properly.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The entry for PR #25430 is currently present both in the CHANGELOG
for Rails 5.0 and for Rails 5.1:
https://github.com/rails/rails/blame/9d3a352777c2594123583b0bc02d0dd80f1e385b/railties/CHANGELOG.md#L61-L72
Since the PR was backported to 5-0-stable in #25499, I believe it
should be removed from the CHANGELOG of 5.1, otherwise it looks like
something changed from 5.0 to 5.1
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix typo in Caching with Rails Guide
|
|/ / / / |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
More intention revealing and means `f` can go F itself 😋
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
chukitow/feature/user-form-with-instead-of-form-for-scaffold
user form with instead of form for in scaffold generator
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix extension method with dirty target in has_many associations
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Extension methods should not delegate to `scope` to respect dirty
target on `CollectionProxy`.
Fixes #28419.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove duplicated `columns` definition
|
| |/ / / / / |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add `app:update` task to engines
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Occasionally we update the file generated by engine.
Therefore, I think that there is a task for updating as well as
application in the engine, it is convenient for updating.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Delegate `uniq` to `records`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Since b644964b `ActiveRecord::Relation` includes `Enumerable` so
delegating `collect`, `all?`, and `include?` are also unneeded.
`collect` without block returns `Enumerable` without preloading by that.
We should use `load` rather than `collect` for force loading.
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Fix `select_all` with legacy `binds`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #27923.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix `warning: character class has duplicated range`
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This fixes the following warnings:
```
railties/test/generators/encrypted_secrets_generator_test.rb:15: warning: character class has duplicated range: /[\w\d]+/
railties/test/generators/encrypted_secrets_generator_test.rb:18: warning: character class has duplicated range: /production:\n# external_api_key: [\w\d]+/
railties/test/generators/encrypted_secrets_generator_test.rb:19: warning: character class has duplicated range: /production:\n# external_api_key: [\w\d]+/
```
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Evaluate the default block only when necessary
|
| | |_|/ / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | | |
Follow up of #28453.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This fixes CI failure due to 48f3be8c.
`Enumerable#uniq` was introduced since Ruby 2.4. We should delegate
`uniq` to `records` explicitly.
And since b644964b `ActiveRecord::Relation` includes `Enumerable` so
delegating `map` is unneeded.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
y-yagi/fix_changelog_entry_about_transaction_error_classes
Fix changelog entry about transaction error classes [ci skip]
|
| | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`ActiveRecord::TransactionSerializationError` was introduces in #25093.
However, refactored in #25107, `TransactionSerializationError` is gone.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Correctly check whether key is defined in configuration
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
It can not check correctly with `defined?`
```ruby
irb(main):001:0> Rails.application.config.active_record
=> {:maintain_test_schema=>true, :belongs_to_required_by_default=>true}
irb(main):002:0> defined?(Rails.application.config.active_record)
=> nil
```
Follow up to #28469
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove stray back-end from ActiveJob Basics guide
|