| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`column_for` was changed to `type_for` to return `type` object at
36bd52b4. But variable name is still `column`. It is very confusing.
Rename variable name `column` to `type` for readability.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Clear attribute changes after handling locking
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Without this the changes to the lock version column will stick around
even after `touch` returns.
Before:
model.touch
model.changes
# => {"lock_version"=>[0, "1"]}
After:
model.touch
model.changes
# {}
|
|\ \ \ \ \ \ \
| | |_|/ / / /
| |/| | | | | |
[ci skip] Fix bad examples in rdoc
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix formatting of `Cache::Store#fetch` [ci skip]
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
Single backticks don't work with rdoc.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix small grammar issue introduced in #26382
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
improve error message when include assertions fail
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message
assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update ActiveModel::Dirty Doc to be simpler to understand
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Rename test to match what it does
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Commit d270da569 changed the `form_for` API from `:object_name` to `:as`.
It also change the related test body, but not its title, which is changed here.
See https://github.com/rails/rails/commit/d270da569efeabd7cd563028816452236713aa9f#diff-52455f1e82acf12551bc5e7e26b82008
I realize this is a small commit but I was having trouble understanding what
the test was about since there is no "object_name" in the code.
I imagine the same may happen to other developers, therefore this commit.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
DRYing duplicate methods
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[fixes #26441]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix typo in `add_column` doc [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Update ActiveModel::Dirty Doc [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | | |
Fix potentially misleading example.
|
| | | | | |
| | | | | |
| | | | | | |
* added bug report template for migrations
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove useless `gemfile` option
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Rails application for test creates with `--skip-gemfile` option.
https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L333
Therefore, regardless of the option, Gemfile is not created.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Correct `render text:` deprecation message
|
| | |_|_|/ / /
| |/| | | | |
| | | | | | | |
The default Content-Type is `text/html`, not `text/plain`.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Improve assert_response helper
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When the check is failed, print the actual response body if it's not too large.
This could improve productivity when writing new tests.
Before:
```
ThemeEditorIntegrationTest#test_whatever
Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>.
Expected: 200
Actual: 422
```
After:
```
ThemeEditorIntegrationTest#test_whatever
Expected response to be a <200: ok>, but was a <422: Unprocessable Entity>.
Expected: 200
Actual: 422
Response body: {"errors":["Invalid settings object for section '1'"]}
```
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Move comment about disconnecting pool close to comment about preload
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- These two comments are connected to each other so kept them back to back.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
fix broken generators test
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
|
| | | | | | | |
|
| |_|_|/ / /
|/| | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix broken comments indentation caused by rubocop auto-correct [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772.
But comments was still kept absolute position. This commit aligns
comments with method definitions for consistency.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Master based applications should be pointing to master
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Address warning: ambiguous first argument
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
after `/' operator`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
close it (#26473)
* activerecord/mysql2: Avoid setting @connection to nil, just close it
Backport of https://github.com/rails/rails/pull/26434
* Add a CHANGELOG entry
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Disconnects all connections in the pool before forking.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
See discussion in https://github.com/puma/puma/issues/1001
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove duplicated fixture set names
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If using namespaced fixtures, get following Ruby warning.
```
activerecord/lib/active_record/fixtures.rb:922: warning: method redefined; discarding old admin_foos
activerecord/lib/active_record/fixtures.rb:922: warning: previous definition of admin_foos was here
```
This is happening because of the multiple set the same path when setting the
fixture name. Fix to remove the duplicate path.
|
|\ \ \ \ \ \ \
| |_|_|_|_|/ /
|/| | | | | | |
fixed guide to add correct documentation for partial render 'as' option
|
|/ / / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Lacks some proper creds to the homies who went the... distance ;)
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
kamipo/remove_useless_test_string_with_crazy_column
Remove useless `test_string_with_crazy_column`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Passing `FakeColumn` was removed at #15336 therefore
`test_string_with_crazy_column` is duplicated with
`test_quote_string_no_column`.
|