Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Forgot to set Migration.verbose at f8d9a51949d6f6cfcab7cc7d501e137836eb88dc ↵ | Akira Matsuda | 2014-08-30 | 1 | -1/+1 |
| | | | | :bomb: | ||||
* | reduce object allocations in utc_offset | Aaron Patterson | 2014-08-29 | 1 | -2/+2 |
| | | | | | | `try` allocates an array on every call, we should avoid calling it in hotspots. This reduced AttributeMethodsTest#test_setting_time_zone_aware_attribute_with_string from 18k allocations to 14k | ||||
* | We tenderized the wrong method! Object#try already had the yield option, ↵ | David Heinemeier Hansson | 2014-08-29 | 5 | -34/+20 |
| | | | | just needed some tenderloving instance_eval to fit the bill | ||||
* | Clarify the origin of this great addition to Rails :trollface: :trollface ↵ | David Heinemeier Hansson | 2014-08-29 | 1 | -1/+1 |
| | | | | :trollface: | ||||
* | Use instance_eval on @tenderlove's suggestion :trollface: | David Heinemeier Hansson | 2014-08-29 | 3 | -7/+8 |
| | |||||
* | Update examples to show real worth | David Heinemeier Hansson | 2014-08-29 | 2 | -2/+11 |
| | |||||
* | Added yield to Object#presence | David Heinemeier Hansson | 2014-08-29 | 3 | -1/+23 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2014-08-29 | 181 | -1044/+1779 |
|\ | |||||
| * | Merge pull request #16746 from cristianbica/fix-backburner-adapter | Godfrey Chan | 2014-08-29 | 1 | -1/+1 |
| |\ | | | | | | | Fixed Active Job Backburner adapter | ||||
| | * | Fixed Active Job Backburner adapter | Cristian Bica | 2014-08-30 | 1 | -1/+1 |
| |/ | |||||
| * | Don't allow AR::Tasks::DatabaseTasks.migrate to mutate Migration.verbose value | Akira Matsuda | 2014-08-30 | 1 | -1/+3 |
| | | | | | | | | This fixes random test failure in migrator_test.rb | ||||
| * | Merge pull request #16741 from robin850/am-isolated-wo-bundle | Santiago Pastorino | 2014-08-29 | 1 | -3/+2 |
| |\ | | | | | | | Make test:isolated run without bundler for Action Mailer | ||||
| | * | Make test:isolated run without bundler for Action Mailer | Robin Dupret | 2014-08-29 | 1 | -3/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | Action Mailer tests weren't able to run in isolation without the bundle exec prefix since we were requiring gems before requiring abstract_unit. We don't need the `gem` call thus and the require_relative since the test directory should be present in the load path when we run any test. | ||||
| * | | Merge pull request #16742 from robin850/rbx-aj-sidekiq | Santiago Pastorino | 2014-08-29 | 1 | -8/+2 |
| |\ \ | | |/ | |/| | Avoid skipping Sidekiq tests on Rubinius | ||||
| | * | Avoid skipping Sidekiq tests on Rubinius | Robin Dupret | 2014-08-29 | 1 | -8/+2 |
| |/ | | | | | | | | | Now that Travis provides support for Rubinius 2.2.10, we can run the Sidekiq tests against this version. | ||||
| * | Some documentation fixes [ci skip] | Robin Dupret | 2014-08-29 | 3 | -10/+10 |
| | | |||||
| * | Don't test PostgreSQL implementation details | Akira Matsuda & Kohei Suzuki | 2014-08-29 | 1 | -3/+0 |
| | | | | | | | | | | Asserting that the message contains "QUERY PLAN" is enough for the adapter's test. The plan may vary according to number of tuples etc. but that's out of our concern. | ||||
| * | Merge pull request #16740 from seuros/activejob | Yves Senn | 2014-08-29 | 5 | -20/+25 |
| |\ | | | | | | | [ActiveJob] extract JobBuffer from helper | ||||
| | * | [ActiveJob] extract JobBuffer from helper | Abdelkader Boudih | 2014-08-29 | 5 | -20/+25 |
| |/ | |||||
| * | Revert "Merge pull request #16254 from ↵ | Yves Senn | 2014-08-29 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_activerecord_attribute_decorators_test" This reverts commit 16fe19831548f108c113094d106663497fc190d5, reversing changes made to 4c81c8ce533896be28bdc0b055ff30bb9dee1316. The call to `Model.reset_column_information` was to express the intent of the test. `reset_column_information` itself can trigger SQL queries because it checks for a tables existance. Let's move it outside of the block. /cc @sgrif | ||||
| * | Merge pull request #16739 from y-yagi/patch-6 | Yves Senn | 2014-08-29 | 2 | -2/+2 |
| |\ | | | | | | | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_class | ||||
| | * | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_class | yuuji.yaginuma | 2014-08-29 | 2 | -2/+2 |
| | | | |||||
| * | | Merge pull request #16728 from splattael/invalid_address_error | Yves Senn | 2014-08-29 | 2 | -1/+8 |
| |\ \ | | |/ | |/| | Don't rescue IPAddr::InvalidAddressError | ||||
| | * | Don't rescue IPAddr::InvalidAddressError | Peter Suschlik | 2014-08-29 | 2 | -1/+8 |
| |/ | | | | | | | | | | | | | | | IPAddr::InvalidAddressError does not exist in Ruby 1.9.3 and fails for JRuby in 1.9 mode. As IPAddr::InvalidAddressError is a subclass of ArgumentError (via IPAddr::Error) just rescuing ArgumentError is fine. | ||||
| * | Reset ActiveRecord::Migration.message_count counter before start testing | Akira Matsuda | 2014-08-29 | 1 | -1/+1 |
| | | |||||
| * | Bring original puts back after finishing tests | Akira Matsuda | 2014-08-29 | 2 | -4/+12 |
| | | |||||
| * | Silence another test that runs migrations | Akira Matsuda | 2014-08-29 | 1 | -0/+5 |
| | | |||||
| * | MigrationTest doesn't need to be verbose anymore | Akira Matsuda | 2014-08-29 | 1 | -1/+1 |
| | | |||||
| * | No tests are dealing with ActiveRecord::Migration.message_count here anymore | Akira Matsuda | 2014-08-29 | 1 | -1/+0 |
| | | |||||
| * | Reset ActiveRecord::Migration.verbose to the value before | Akira Matsuda | 2014-08-29 | 2 | -2/+5 |
| | | |||||
| * | Demodulize ActiveRecord::MigratorTest | Akira Matsuda | 2014-08-29 | 1 | -284/+282 |
| | | |||||
| * | Merge pull request #16637 from Agis-/redirect-with-constraint-route | Aaron Patterson | 2014-08-28 | 3 | -2/+31 |
| |\ | | | | | | | Fix the router ignoring constraints when used together with a redirect route | ||||
| | * | Don't ignore constraints in redirect routes | Agis- | 2014-08-25 | 3 | -2/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/402c2af55053c2f29319091ad21fd6fa6b90ee89 introduced a regression that caused any constraints added to redirect routes to be ignored. Fixes #16605 | ||||
| * | | Avoid using heredoc for user warnings | Godfrey Chan | 2014-08-28 | 10 | -61/+51 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long. | ||||
| * | | No transaction for a test that creates fixtures in the test body | Akira Matsuda | 2014-08-29 | 1 | -0/+1 |
| | | | |||||
| * | | make it easy to copy & paste the config from deprecation warning. | Yves Senn | 2014-08-28 | 1 | -2/+3 |
| | | | | | | | | | | | | [ci skip] | ||||
| * | | User Model#last to certainly get lastly created data | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | | | | | | | | | | This test would fail when executed after any test that calls fixtures(:binaries) | ||||
| * | | Move model definition to test/models for test order indenendency | Akira Matsuda | 2014-08-28 | 3 | -29/+15 |
| | | | |||||
| * | | Move association definition to the model file | Akira Matsuda | 2014-08-28 | 2 | -2/+1 |
| | | | |||||
| * | | Be sure that test fixtures satisfy referential integrity before calculating | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | There exists some other test files that load :minivans fixtures but don't load :speedometers. Loading :speedometers here prevents the following error when this test was run after such test: CalculationsTest#test_should_group_by_association_with_non_numeric_foreign_key: ActiveRecord::RecordNotFound: Couldn't find all Speedometers with 'speedometer_id': (ABC, s1) (found 1 results, but was looking for 2) | ||||
| * | | Expectations first | Akira Matsuda | 2014-08-28 | 4 | -9/+9 |
| | | | |||||
| * | | Reset RACK_ENV after modified in a test case | Akira Matsuda | 2014-08-28 | 1 | -0/+1 |
| | | | |||||
| * | | Rails.root should be a Pathname | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | |||||
| * | | No need to sort tests | Akira Matsuda | 2014-08-28 | 3 | -3/+3 |
| | | | | | | | | | | | | Dir.glob result must be already sorted anyway | ||||
| * | | Test everything | Akira Matsuda | 2014-08-28 | 1 | -1/+1 |
| | | | | | | | | | | | | This actually was testing test everything, so why not do it simpler? | ||||
| * | | AP test files does no more need to be alphabetically sorted here | Akira Matsuda | 2014-08-28 | 1 | -4/+1 |
| | | | |||||
| * | | Ignore SCHEMA queries when asserting no queries | Akira Matsuda | 2014-08-28 | 5 | -22/+22 |
| | | | |||||
| * | | Reset schema properly after schema changing test | Akira Matsuda | 2014-08-28 | 1 | -0/+2 |
| | | | |||||
| * | | Merge pull request #16727 from BanzaiMan/travis-yml-fix | Rafael Mendonça França | 2014-08-27 | 1 | -0/+1 |
| |\ \ | | | | | | | | | Add language directive to .travis.yml | ||||
| | * | | Add language directive to .travis.yml | Hiro Asari | 2014-08-27 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, Travis CI assumes that the project is in Ruby in the absence of the `language` key. This behavior may change in the future. (For example, switch to a "blank" image which *may* be created.) |