Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Merge pull request #4490 from EmmanuelOga/master | José Valim | 2012-01-17 | 3 | -2/+19 | |
|\ \ \ \ | | | | | | | | | | | when validating a record, if a validation context is used, use the same context when validating related records | |||||
| * | | | | validate related records in the same validation context as parent. | Emmanuel Oga | 2012-01-17 | 3 | -2/+19 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | E.G.: ```ruby class Parent < ActiveRecord::Base has_one :child validates_presence_of :name, :on => "custom_context" validates_associated :child end class Child < ActiveRecord::Base belongs_to :parent validates_presence_of :name, :on => "custom_context" end p = Parent.new(:name => "Montoto", :child => Child.new) p.valid?(:custom_context) # => Returns true, even though the child is not valid under the same context. ``` | |||||
* | | | | Merge pull request #4484 from lest/patch-1 | José Valim | 2012-01-17 | 1 | -3/+2 | |
|\ \ \ \ | | | | | | | | | | | use thread variable in TaggedLogging | |||||
| * | | | | use thread variable in TaggedLogging | Sergey Nartimov | 2012-01-17 | 1 | -3/+2 | |
| | | | | | | | | | | | | | | | | | | | | previous solution can cause race conditions under GIL-free ruby implementations | |||||
* | | | | | Merge pull request #4491 from pkondzior/master | Piotr Sarnacki | 2012-01-16 | 2 | -1/+14 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | Wrong behavior of ActiveModel::Errors#dup is causing regressions on Rails master | |||||
| * | | | | Remove redundant #to_sym | Paweł Kondzior | 2012-01-16 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Fix ActiveModel::Errors#dup | Paweł Kondzior | 2012-01-16 | 2 | -0/+13 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since ActiveModel::Errors instance keeps all error messages as hash we should duplicate this object as well. Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash, which results in different behavior on `dup`, this may result in regression for people relying on it. | |||||
* | | | | stop more ddl changes | Aaron Patterson | 2012-01-16 | 2 | -14/+16 | |
| | | | | ||||||
* | | | | stop ddl modifications for another test | Aaron Patterson | 2012-01-16 | 2 | -12/+10 | |
| | | | | ||||||
* | | | | use one based indexes for the mock migrations | Aaron Patterson | 2012-01-16 | 1 | -16/+16 | |
| | | | | ||||||
* | | | | stop making ddl changes for migrator tests | Aaron Patterson | 2012-01-16 | 2 | -67/+78 | |
| | | | | ||||||
* | | | | actually use the variable I created. :bomb: thanks @exviva | Aaron Patterson | 2012-01-16 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | move another migrator to use sensors | Aaron Patterson | 2012-01-16 | 2 | -12/+18 | |
| | | | | ||||||
* | | | | Make it more explicit that the feature is deprecated, not removed. | Jon Leighton | 2012-01-16 | 1 | -2/+4 | |
| | | | | ||||||
* | | | | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 23 | -66/+216 | |
| | | | | | | | | | | | | | | | | | | | | | | | | See the CHANGELOG for details. Fixes #950. | |||||
* | | | | infer references from Relation#order | Jon Leighton | 2012-01-16 | 2 | -2/+28 | |
| | | | | ||||||
* | | | | store references as a string | Jon Leighton | 2012-01-16 | 4 | -8/+8 | |
| | | | | ||||||
* | | | | Avoid sanitize_sql when we can use Relation#where instead | Jon Leighton | 2012-01-16 | 4 | -22/+16 | |
| | | | | ||||||
* | | | | automatically add references when we can | Jon Leighton | 2012-01-16 | 3 | -1/+29 | |
| | | | | ||||||
* | | | | Make referencing an included item trigger eager loading | Jon Leighton | 2012-01-16 | 2 | -1/+13 | |
| | | | | ||||||
* | | | | Add ActiveRecord::Relation#references (#950) | Jon Leighton | 2012-01-16 | 4 | -4/+35 | |
| | | | | ||||||
* | | | | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 27 | -181/+99 | |
|/ / / | | | | | | | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. | |||||
* | | | moving verbosity tests to the migrator test, removing ddl changes | Aaron Patterson | 2012-01-16 | 3 | -20/+25 | |
| | | | ||||||
* | | | silencing migrator tests, refactoring the migration test helper | Aaron Patterson | 2012-01-16 | 4 | -23/+13 | |
| | | | ||||||
* | | | fix tests on sqlite3 | Aaron Patterson | 2012-01-16 | 1 | -0/+4 | |
| | | | ||||||
* | | | prefer method sensors over actual ddl changes | Aaron Patterson | 2012-01-16 | 2 | -69/+84 | |
| | | | ||||||
* | | | testing the current version method | Aaron Patterson | 2012-01-16 | 1 | -1/+26 | |
| | | | ||||||
* | | | test that migrations have connections, and method missing delegates | Aaron Patterson | 2012-01-16 | 1 | -7/+16 | |
| | | | ||||||
* | | | making sure the temp connection and the real connection are different after dup | Aaron Patterson | 2012-01-16 | 1 | -3/+3 | |
| | | | ||||||
* | | | Merge pull request #4462 from spohlenz/fix-routing-tests | Aaron Patterson | 2012-01-16 | 1 | -0/+4 | |
|\ \ \ | |/ / |/| | | Stub ip method of alternative request class in router tests | |||||
| * | | Stub ip method of alternative request class | Sam Pohlenz | 2012-01-14 | 1 | -0/+4 | |
| | | | ||||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-01-16 | 3 | -18/+83 | |
|\ \ \ | ||||||
| * | | | minor edits in getting started guide | Vijay Dev | 2012-01-16 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | copy editing asset pipeline changes | Vijay Dev | 2012-01-16 | 1 | -7/+6 | |
| | | | | ||||||
| * | | | [docs] Update pipeline asset organization section. | Richard Hulse | 2012-01-16 | 1 | -4/+57 | |
| | | | | | | | | | | | | | | | | | | | | * Calified how assets are included. * Added information about using index manifests. | |||||
| * | | | change class to id per scaffold change | Dan Pickett | 2012-01-15 | 1 | -7/+7 | |
| | |/ | |/| | | | | #4472 | |||||
| * | | Improve description of :allow_destroy option for nested attributes in ↵ | Carlos Antonio da Silva | 2012-01-15 | 1 | -7/+7 | |
| | | | | | | | | | | | | getting started guide | |||||
| * | | Fix styling of example layout. Fixes #4461 | Jason Noble | 2012-01-13 | 1 | -1/+1 | |
| | | | ||||||
| * | | Mention how use config.assets.prefix to avoid conflicting with an existing ↵ | Guillermo Iguaran | 2012-01-13 | 1 | -1/+8 | |
| | | | | | | | | | | | | "/assets" route | |||||
| * | | Getting Started Guide: Update reference about JavaScript runtimes | Guillermo Iguaran | 2012-01-13 | 1 | -1/+7 | |
| | | | ||||||
* | | | Add ActiveModel::Errors#delete, which was not available after move to use ↵ | Piotr Sarnacki | 2012-01-16 | 2 | -0/+12 | |
| | | | | | | | | | | | | delegation | |||||
* | | | Merge pull request #4480 from lest/use-rack-body-proxy | José Valim | 2012-01-16 | 10 | -135/+44 | |
|\ \ \ | | | | | | | | | Use Rack::BodyProxy | |||||
| * | | | use rack from master branch | Sergey Nartimov | 2012-01-16 | 2 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | | | it's needed until new rack release with Rack::BodyProxy fixes https://github.com/rack/rack/commit/b06ef82876416fe69429f7d3ee6e51bf26aec75f | |||||
| * | | | use Rack::BodyProxy in activerecord middlewares | Sergey Nartimov | 2012-01-16 | 6 | -102/+37 | |
| | | | | ||||||
| * | | | use Rack::BodyProxy in AD::Reloader | Sergey Nartimov | 2012-01-16 | 2 | -33/+3 | |
| | | | | ||||||
* | | | | Merge pull request #4478 from amatsuda/rake_stats_mailer | José Valim | 2012-01-16 | 1 | -0/+1 | |
|\ \ \ \ | | | | | | | | | | | show stats for app/mailers | |||||
| * | | | | show stats for app/mailers | Akira Matsuda | 2012-01-16 | 1 | -0/+1 | |
|/ / / / | ||||||
* | | | | Try to create schema migrations table in schema dumper test | Piotr Sarnacki | 2012-01-16 | 1 | -0/+5 | |
| | | | | ||||||
* | | | | Fix ActiveRecord mysql tests | Piotr Sarnacki | 2012-01-16 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TL;DR: MySQL sucks. Since it does not support transactions for schema changes, when you run `create_table` in setup block, it will commit current transaction. Now tests want to run `RELEASE SAVEPOINT` after finishing tests which fails since there is no transaction. | |||||
* | | | | Fix test class name that should read Without | Carlos Antonio da Silva | 2012-01-16 | 1 | -2/+2 | |
|/ / / |