| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ |
|
|
|
|
| |
https://travis-ci.org/rails/rails/jobs/375326992#L1160-L1166
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I saw these ones while working on #32362.
File.write was introduced in Ruby 1.9.3 and it is the most concise way
to perform bulk writes (as File.read is for bulk reading).
The existing flags enabled binmode, but we are dumping text here.
The portable way to dump text is text mode. The only difference is
newlines, and portable code should in particular emit portable newlines.
Please note the hard-coded \ns are still correct. In languages with C
semantics for newlines like Ruby, Python, Perl, and others, "\n" is a
portable newline. Both when writing and when reading. On Windows, the
I/O layer is responsible for prepending a CR before each LF on writing,
and removing CRs followed by LFs on reading. On Unix, binmode is a
no-op.
|
|\
| |
| | |
Don't generate assets' initializer in `app:update` task if sprockets is skipped
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Execute `rails new myapp -S` and then upgrade the app by using the `app:update` task, `bin/rails c` results in `NoMethodError`.
```
$ bin/rails app:update
$ bin/rails c
Traceback (most recent call last):
44: from bin/rails:4:in `<main>'
(snip)
1: from /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/config/initializers/assets.rb:4:in `<top (required)>'
/Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x00007fcb8d3697e0> (NoMethodError)
Did you mean? asset_host
```
|
|\ \
| | |
| | | |
Fix logic on disabling afer_commit callbacks
|
| | |
| | |
| | |
| | | |
Commit callbacks are intentionally disabled when errors occur when calling the callback chain in order to reset the internal record state. However, the implicit order of operations on the logic for checking if callbacks are disabled is wrong. The result is that callbacks can be unexpectedly when errors occur in transactions.
|
|\ \ \
| | | |
| | | | |
Fix #29632 - nil #path leads to NoMethodError in LoadError#is_missing?
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
See #29632 for details. In short, it's possible to enter `LoadError#is_missing?` when `LoadError#path` returns `nil`, leading to `path.sub` throwing an none-to-helpful `NoMethodError`.
This tiniest of patch inserts `#to_s` before the `sub` call to make sure it succeeds. Affected surface area should be just as tiny since something has already gone wrong to get us into `#is_missing?` and the current behavior when `#path` returns `nil` seems clearly not intended.
[Gannon McGibbon + Neil Souza]
|
|\ \ \
| | | |
| | | | |
Remove confusion in the sentence [ci skip]
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
Updates documentation on ActionDispatch::Integration::Session#process
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds missing information on 2 parameters: +xhr+ and +as+
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Minor edits to the Active Storage guide
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix spelling, grammar, and formatting.
[ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Use usual method definition instead of extracting args from array
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follows #32612
|
|/ / / /
| | | |
| | | |
| | | | |
weblog.jamisbuck.org is not GitHub Pages.
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
Specification: https://w3c.github.io/webappsec-csp/#directive-prefetch-src
This directive can already be used as an experimental feature in Chrome.
Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=801561
|
| | | |
|
|\ \ \
| | | |
| | | | |
Use https with weblog URI
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Remove unused `assert_like` from `Arel::Test`
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It had been added at https://github.com/rails/arel/commit/05b5bb12270b32e094c1c879273e0978dabe5b3b
and removed at https://github.com/rails/arel/commit/db1bb4e9a728a437d16f8bdb48c3b772c3e4edb0
|
|/ / / |
|
| | |
| | |
| | |
| | | |
`require 'rubygems'` is already required in Ruby 1.9 or later.
|
|\ \ \
| | | |
| | | | |
Allow a belonging to object to be created from a new record
|
| | | |
| | | |
| | | |
| | | | |
If a 'has one' object is created from a new record, an ActiveRecord::RecordNotSaved error is raised but this behavior was also applied to the reverse scenario.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Ensure that do not accidentally remove an index of different
definitions.
|
|\ \ \ \
| | | | |
| | | | | |
Partly revert #32289 to provide Rails' custom fallback in case did_you_mean is not available
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`DidYouMean::SpellChecker` is not defined.
`did_you_mean` is bundled in Ruby but can be uninstalled, and is not always
available, sometimes even on our CI:
https://travis-ci.org/rails/rails/jobs/372638523#L2405
https://travis-ci.org/rails/rails/jobs/372638523#L2416
https://travis-ci.org/rails/rails/jobs/372638523#L2427
...
|
|\ \ \ \
| | | | |
| | | | | |
Fix typo in ActiveRecord test method name
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a job was just deserialized `arguments` is `nil` and the serialized
arguments are in the `@serialized_arguments` variable. If we try to
serialize this job again the arguments are going to be `nil` instead of
what was serialized.
The test we had was not checking this case because it was deserializing
the job in the same object that had the arguments.
To fix this, when the `@serialized_arguments` are present we return it
instead of the result of the `arguments` serialized.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
It will cause "undefined method `test_order' for ActiveSupport:Module
(NoMethodError)".
https://travis-ci.org/rails/rails/jobs/373472604#L1208
|
|\ \ \
| |_|/
|/| | |
Make `Arel::Test` subclass of `ActiveSupport::TestCase`
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
not `Minitest::Test` to address `CustomCops/RefuteNot` and `CustomCops/AssertNot` offenses
for Arel test cases
Also including `ActiveSupport::Testing::Assertions` to `Arel::Spec`
and add test/unit backwards compatibility methods
Fixes #32720
|
|\ \
| | |
| | | |
Reset CONTENT_LENGTH between test requests
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If a POST request is followed by a GET request in a controller test, the
`rack.input` and `RAW_POST_DATA` headers from the first request will be
reset but the `CONTENT_LENGTH` header will leak, leading the request
object in the second request to incorrectly believe it has a body.
|
|\ \ \
| |/ /
|/| | |
Add quotes to code in rdoc comment in ActionController [ci skip]
|
|/ /
| |
| |
| | |
The example code is meant to be a string.
|
|\ \
| | |
| | | |
Document rails new <app> storage folder
|
| | |
| | |
| | |
| | |
| | | |
[ci skip] Active Storage now adds a storage folder to newly generated
rails applications.
|
|\ \ \
| |/ /
|/| | |
Fix an oxford comma
|
|/ /
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Fix test: threads being nil in ensure
|
| | |
| | |
| | |
| | | |
when connection_pool is not installed.
|
|\ \ \
| |/ /
|/| | |
Remove reference to Tokaido
|
|/ / |
|