aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Document nested attributes as hash of hashesAlexey Muranov2013-04-131-17/+41
| | | | | | Document the possibility to use a hash of hashes for nested attributes for a one-to-many association (in addition to the documented possibility to use an array of hashes). Align indentation in comments.
* Merge pull request #10172 from senny/10098_backportRafael Mendonça França2013-04-114-1/+13
|\ | | | | Backport: Correctly parse bigint defaults in PostgreSQL
| * Correctly parse bigint defaults in PostgreSQL, Backpost #10098.Erik Peterson2013-04-114-1/+13
|/ | | | | | | | Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb activerecord/test/cases/schema_dumper_test.rb
* Merge branch '3-2-later' into 3-2-stableAaron Patterson2013-04-091-0/+10
|\ | | | | | | | | * 3-2-later: adding test for CVE
| * adding test for CVEAaron Patterson2013-02-091-0/+10
| |
* | Improve the changelog entry [ci skip]Rafael Mendonça França2013-04-051-3/+4
| |
* | Merge pull request #10105 from rmm5t/fix-explicit-name-on-multiple-fieldsRafael Mendonça França2013-04-053-8/+24
|\ \ | | | | | | Fix explicit names on multiple file fields
| * | Fix explicit names on multiple file fieldsRyan McGeary2013-04-053-8/+24
|/ / | | | | | | | | | | | | | | If a file field tag is passed the multiple option, it is turned into an array field (appending "[]"), but if the file field is passed an explicit name as an option, leave the name alone (do not append "[]"). Fixes #9830
* | Fix typo in view nameCarlos Antonio da Silva2013-04-032-1/+1
| | | | | | | | Introduced in 2c22376fe04b89e8f34620139720b85a85ce3428
* | Use 1.8 hash style in test viewsCarlos Antonio da Silva2013-04-032-2/+2
| | | | | | | | Introduced in 2c22376fe04b89e8f34620139720b85a85ce3428
* | Merge pull request #7792 from seejee/chained_scopes_preload_properlyCarlos Antonio da Silva2013-04-034-2/+22
|\ \ | | | | | | Fixes Issue #7490: Chained scopes will preload properly
| * | Chained scopes will be preloaded properly. Fixes #7490Chris Geihsler2013-04-034-2/+22
| | |
* | | Common behavior with adding formats to lookup_context for TemplateRenderer ↵Dmitry Vorotilin2013-04-0212-4/+33
| | | | | | | | | | | | and PartialRenderer
* | | Fix formatting and minor review in AP changelogCarlos Antonio da Silva2013-03-301-9/+8
| | | | | | | | | | | | Sentences starting with # are considered headings.
* | | Add attr_accessible to the Getting Started Guide.Steve Klabnik2013-03-291-0/+2
| | | | | | | | | | | | | | | This was brought up in #9995, but is only present in 3-2-stable, since mass assignment is removed from Rails 4.
* | | Removing explain support warning from the RailtieRafael Mendonça França2013-03-282-7/+7
| | | | | | | | | | | | | | | | | | | | | This is causing a regression since the Active Record Railtie is trying to connect to the development database in the application boot. See https://github.com/rails/rails/pull/6197#issuecomment-15199273
* | | Merge pull request #9943 from fredwu/test_fix_for_74e59eaCarlos Antonio da Silva2013-03-261-1/+1
|\ \ \ | | | | | | | | Fixed test failures on 1.8.7 caused by 74e59ea
| * | | Fixed test failures on 1.8.7 caused by 74e59eaFred Wu2013-03-271-1/+1
|/ / /
* | | Merge pull request #9576 from ↵Rafael Mendonça França2013-03-263-1/+18
|\ \ \ | | | | | | | | | | | | | | | | fredwu/backport_fix_explicitly_inheraitance_column_to_3_2_stable [Backport to 3-2-stable] Don't reset inheritance_column when setting explicitly.
| * | | Added changelog for 55e2954Fred Wu2013-03-271-0/+5
| | | |
| * | | Don't reset inheritance_column when setting explicitly.Fred Wu2013-03-272-1/+13
|/ / / | | | | | | This is backported from master (cdfcbc4).
* | | Merge pull request #9899 from macksmind/backport_5808Jeremy Kemper2013-03-243-6/+60
|\ \ \ | | | | | | | | Backport #5808
| * | | Backport #5808Mack Earnhardt2013-03-243-6/+60
|/ / / | | | | | | | | | | | | | | | df36c5f - Fix assert_template assertion with :layout option 4bd05a7 - Fix assert_template :layout => nil assertion 0d19a08 - Improve assert_template layout checking
* | | Merge pull request #9873 from senny/use_old_hash_syntaxJon Leighton2013-03-221-1/+1
|\ \ \ | | | | | | | | use ruby 1.8 Hash syntax [ci skip]
| * | | use ruby 1.8 Hash syntax [ci skip]Yves Senn2013-03-221-1/+1
|/ / /
* | | Merge pull request #9870 from senny/9806_eager_loading_regressionJon Leighton2013-03-222-2/+8
|\ \ \ | | | | | | | | do not reset associations when preloading twice.
| * | | do not reset associations when preloading twice.Yves Senn2013-03-222-2/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | Closes #9806. As the `through_options` always contained `{:order=>nil}` the second time, the preloader ran, the association was always reset. This patch only adds the `:order` to the `through_options` if it is set.
* | | Fix test to Ruby 1.8Rafael Mendonça França2013-03-211-1/+1
| | | | | | | | | | | | Pathname doesn't respond to to_path
* | | Improve CHANGELOG entry [ci skip]Rafael Mendonça França2013-03-211-1/+5
| | |
* | | Merge branch '3-2-stable' into fredwu-slow_view_loading_fixAaron Patterson2013-03-206-2/+32
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 3-2-stable: Merge pull request #9802 from newsline/fix-broken-action-missing Remove bad changelog entry from AR [ci skip] Wrong exception is occured when raising no translatable exception Don't crash exception translation w/ nil result attribute. Conflicts: actionpack/CHANGELOG.md
| * | | Merge pull request #9802 from newsline/fix-broken-action-missingRafael Mendonça França2013-03-203-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix missing action_missing Conflicts: actionpack/CHANGELOG.md Conflicts: actionpack/test/controller/base_test.rb Fixes #9799
| * | | Remove bad changelog entry from AR [ci skip]Carlos Antonio da Silva2013-03-201-3/+0
| | | | | | | | | | | | | | | | Introduced in dc2bc388bc8c6c345337052bf0d60f5243d899d4.
| * | | Wrong exception is occured when raising no translatable exceptionkennyj2013-03-203-0/+16
| | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md
| * | | Don't crash exception translation w/ nil result attribute.Steve Jorgensen2013-03-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Exception.result is nil when attempting a query after PostgreSQL disconnect, resulting in new exception: NoMethodError: undefined method `error_field' for nil:NilClass
* | | | Added changelog for 687e68dFred Wu2013-03-211-0/+6
| | | |
* | | | Fixed assets loading performance in 3.2.13Fred Wu2013-03-202-1/+10
|/ / / | | | | | | | | | | | | The PR #8756 uses Sprockets for resolving files that already exists on disk, for those files their extensions don't need to be rewritten. Fixes #9803
* | | Be consistent with quotes in smtp example guide [ci skip]Carlos Antonio da Silva2013-03-191-1/+1
| | |
* | | Merge pull request #9796 from dembskoi/clone_structureRafael Mendonça França2013-03-192-0/+8
|\ \ \ | | | | | | | | Reset postgreSQL search path in db:test:clone_structure.
| * | | Reset postgreSQL search path in db:test:clone_structure.Alexander2013-03-192-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch resets the postgres search path in the structure.sql after the structure is dumped in order to find schema_migrations table when multiples schemas are used. Fixes #945
* | | | Merge pull request #9804 from samsonasu/backport_number_to_human_fixesRafael Mendonça França2013-03-193-1/+20
|\ \ \ \ | |/ / / |/| | | Backport #9347 to rails 3.2
| * | | Backport #9347 to rails 3.2hoffm2013-03-193-1/+20
|/ / /
* | | Merge pull request #9789 from puma/3-2-stableJosé Valim2013-03-181-1/+1
|\ \ \ | | | | | | | | Change @env_config to @app_env_config
| * | | Change @env_config to @app_env_configEvan Phoenix2013-03-181-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moral of the story: One must be careful about lazily initializing instance variables when subclassing. I would like to draw your attention to https://github.com/rails/rails/issues/4652 where the reader will see that there appears to be some kind of initialization issue in rails. The source of this issue is that: 1) Engine#env_config contains "@env_config ||= ..." 2) Application#env_config contains "@env_config ||= ..." 3) Threads are in the picture 4) Thread A calls Application#env_config, which super's to Engine#env_config 5) After Engine#env_config returns but before Application#env_config sets @env_config again, Thread B begins running 6) Thread B calls Application#env_config 7) Thread B finds @env_config to contain a value (the one set by Engine#env_config) and returns it 8) Thread B blows up because key set by Application#env_config are there. 9) People report bugs with puma, thin, rainbows, webrick, etc 10) Evan becomes tired of seeing these bugs 11) Evan pours himself a stiff drink, puts on Top Gear(tm), and begins debugging 12) Evan finds the source of the bug 13) Evan authors a PR 14) RIGHT NOW. The bug is fixed by simply using a different ivar name in the methods. Alternately, Engine#env_config could just return a new Hash each time, not memoizing into @env_config. I bid you adieu.
* | | Merge pull request #9785 from claudiob/add-3-2-13-release-date-to-changelogsRafael Mendonça França2013-03-187-8/+8
|\ \ \ | | | | | | | | Add release dates to documentation [ci skip]
| * | | Add release dates to documentation [ci skip]claudiob2013-03-187-8/+8
|/ / / | | | | | | | | | Set "March 18, 2013" as the release date for 3.2.13
* | | Bring back test and changelog entry from #pluck method and select clauseCarlos Antonio da Silva2013-03-182-0/+16
| | |
* | | Fix method name indent [ci skip]Carlos Antonio da Silva2013-03-181-1/+1
| | |
* | | Fix changelog conflicts and remove release dates [ci skip]Carlos Antonio da Silva2013-03-183-14/+8
| | |
* | | Merge branch '3-2-13' into 3-2-stableAaron Patterson2013-03-1828-50/+98
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 3-2-13: bumping to 3.2.13 fix protocol checking in sanitization [CVE-2013-1857] JDOM XXE Protection [CVE-2013-1856] fix incorrect ^$ usage leading to XSS in sanitize_css [CVE-2013-1855] stop calling to_sym when building arel nodes [CVE-2013-1854] Merge pull request #9616 from exviva/multiple_select_name_double_square_brackets bumping to rc2 Revert "Merge pull request #8209 from senny/backport_8176" Freeze columns only once per Result Preparing for 3.2.13.rc1 release Update CHANGELOGs for 3.2.13 release. Conflicts: actionmailer/CHANGELOG.md actionpack/CHANGELOG.md activemodel/CHANGELOG.md activeresource/CHANGELOG.md activesupport/CHANGELOG.md railties/CHANGELOG.md
| * | | bumping to 3.2.13Aaron Patterson2013-03-189-9/+9
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 12:37:13 +0000