Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Return processing lock to dispatcher, the finer grained lock was ↵ | Aliaksey Kandratsenka | 2008-10-04 | 2 | -9/+14 | |
| | | | | | | | | | | incompatible with the reloading in development mode. This commit also adds ActionController::Dispatcher#dispatch_unlocking -- non-locking version of dispatch. It's named anologously to POSIX {getc,getchar,...}_unlocked functions. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1170 state:committed] | |||||
* | Fix performance bug in AttibuteMethods#respond_to? in handling of private ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+3 | |
| | | | | | | | | | | | methods We have hit dramatic increase in tests time after upgrading rails. Profiling revealed this particular place. After this fix our test times returned back to norm. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1173 state:committed] | |||||
* | call clear_active_connections! in :after_dispatch to give pooled connections ↵ | Aliaksey Kandratsenka | 2008-10-04 | 2 | -1/+17 | |
| | | | | | | | | | | | back This fixes connection pool exhaustion for web servers which create new thread per connection (e.g. Webrick). integration.rb changes are required to keep test transaction active for several requests. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1171 state:committed] | |||||
* | made ConnectionPool#checkout more robust by trying to loot dead threads when ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+5 | |
| | | | | | | | | pool is empty Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1169 state:committed] | |||||
* | Fix race in ConnectionPool#checkout | Aliaksey Kandratsenka | 2008-10-04 | 1 | -15/+14 | |
| | | | | | | | After releasing monitor some connection(s) may appear in pool before monitor is re-aquired. When this happens we'll wait for connection which is already available. Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | don't quote decimal values for mysql. It doesn't make sense and breaks in ↵ | Aliaksey Kandratsenka | 2008-10-04 | 1 | -1/+1 | |
| | | | | | | | newer versions of mysql Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1168 state:committed] | |||||
* | Fixed load path for actionmailer and activesupport tests to always load from ↵ | madlep | 2008-10-04 | 2 | -1/+3 | |
| | | | | | | | | local lib files. [#983 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Add IMB DB support to Rails application generator. [#1136 state:resolved] | Antonio Cangiano | 2008-10-04 | 2 | -1/+63 | |
| | | | | | | Usage : rails app_name -d ibm_db Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Make sure recreate MySQL test database with the proper encoding and ↵ | Luca Guidi | 2008-10-03 | 3 | -3/+8 | |
| | | | | | | | collation [#1165 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1165 state:committed] | |||||
* | Remove AS for oracle compatibility | Michael Koziarski | 2008-10-03 | 1 | -1/+1 | |
| | ||||||
* | added nicer failure reporting to #assert_difference to tell you the ↵ | madlep | 2008-10-03 | 2 | -4/+25 | |
| | | | | | | | expression that failed rather than just the expected and actual values Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1161 state:committed] | |||||
* | Provide alternate implementation of Object#subclasses_of for JRuby | Nick Sieger | 2008-10-03 | 1 | -12/+33 | |
| | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1144 state:committed] | |||||
* | Dynamic finders should use the ActiveRecord::Base::find method instead of ↵ | Eloy Duran | 2008-10-03 | 3 | -13/+30 | |
| | | | | | | | | | | | | ::find_initial, :find_last, and ::find_all. This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders. Associations for instance do go through ::find, so this makes it more consistent. Also removed the unnecessary deprecation silence blocks. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1162 state:committed] | |||||
* | Call controller_path instance method so it can be easily overridden [#1141 ↵ | David Masover | 2008-09-30 | 1 | -2/+2 | |
| | | | | | | state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Fix etag! and last_modified! to work as advertised. | Michael Koziarski | 2008-09-30 | 2 | -3/+44 | |
| | | | | Add tests too. | |||||
* | Remove unneeded interning. | Michael Koziarski | 2008-09-30 | 1 | -3/+2 | |
| | ||||||
* | fix eager loading's :condition sanitizing expanding against the wrong table | Will Bryant | 2008-09-29 | 1 | -5/+5 | |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | wrote a test showing eager loading's misbehavior (sanitizing against the ↵ | Will Bryant | 2008-09-29 | 1 | -0/+7 | |
| | | | | | | wrong table) when the association has a :conditions hash Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Add options to field_set_tag | Andrew Kaspick | 2008-09-29 | 2 | -2/+14 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1116 state:committed] | |||||
* | Protect body ivar from being clobbered by the mailer template assigns | Joshua Peek | 2008-09-28 | 4 | -2/+19 | |
| | ||||||
* | Ignore all exceptions for validates_acceptance_of columns fetch so it can ↵ | Tarmo Tänav | 2008-09-26 | 1 | -1/+1 | |
| | | | | | | run even without a database connection Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Changed ActiveRecord attributes to respect access control. | Adam Milligan | 2008-09-24 | 2 | -5/+54 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1084 state:committed] | |||||
* | Partially revert 185fe2e9cce737d69d3b47a656f3651ce152c0c1 | Michael Koziarski | 2008-09-24 | 2 | -2/+4 | |
| | | | | We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us. | |||||
* | Use ActiveSupport::SecureRandom instead of the strange fallback code. | Michael Koziarski | 2008-09-24 | 1 | -22/+2 | |
| | ||||||
* | Refactor configure_dependency_for_has_many to use a few more methods. | Hongli Lai (Phusion) | 2008-09-24 | 1 | -3/+34 | |
| | | | | | | | Add an additional conditions option to make it slightly easier for certain plugins. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1087 state:committed] | |||||
* | Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join ↵ | Pivotal Labs | 2008-09-24 | 4 | -13/+68 | |
| | | | | | | | strings to avoid table aliasing problems. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1077 state:committed] | |||||
* | Make AssociationCollection start transactions in the correct database. | Hongli Lai (Phusion) | 2008-09-23 | 5 | -6/+48 | |
| | | | | | | | | | | AssociationCollection now starts transactions by calling AssociationCollection#transaction instead of @owner.transaction or @reflection.klass.transaction. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1081 state:committed] | |||||
* | slice now returns indifferent hash if called on one | adam | 2008-09-23 | 1 | -1/+1 | |
| | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1096 state:committed] | |||||
* | Adds failed test case for slicing hash with indifferent access with symbol keys | adam | 2008-09-23 | 1 | -0/+10 | |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Modified ActiveSupport::Inflector#parameterize with code from slugalizer ↵ | Adam Cigánek | 2008-09-23 | 3 | -6/+21 | |
| | | | | | | | | | (http://github.com/henrik/slugalizer) Handles trailing and leading slashes, and squashes repeated separators into a single character. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1034 state:committed] | |||||
* | Changelog entry for manfred's multibyte changes | Michael Koziarski | 2008-09-22 | 1 | -0/+4 | |
| | ||||||
* | Merge branch 'patches' into multibyte | Michael Koziarski | 2008-09-22 | 14 | -163/+439 | |
|\ | ||||||
| * | Bump the Version constants to align with the *next* release rather than the ↵ | Michael Koziarski | 2008-09-22 | 5 | -5/+5 | |
| | | | | | | | | | | | | previous release. This allows people tracking non-release gems or git submodules to use the constants. | |||||
| * | Fixed AssetTag cache with with relative_url_root [#1022 state:resolved] | Martin Rehfeld | 2008-09-22 | 2 | -1/+51 | |
| | | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| * | Refactor AssetTagHelper and fix remaining threadsafe issues. | Joshua Peek | 2008-09-22 | 2 | -152/+326 | |
| | | ||||||
| * | Association#first and last should not load the association if not needed. ↵ | Jan De Poorter | 2008-09-22 | 3 | -4/+18 | |
| | | | | | | | | | | | | [#1091 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
| * | Add Model#delete instance method, similar to Model.delete class method. ↵ | Hongli Lai (Phusion | 2008-09-21 | 4 | -2/+40 | |
| | | | | | | | | | | | | [#1086 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | Set encoding of the multibyte test helpers file to UTF-8 so the strings can ↵ | Manfred Stienstra | 2008-09-21 | 1 | -0/+2 | |
| | | | | | | | | be read by Ruby 1.9. | |||||
* | | Change all calls to String#chars to String#mb_chars. | Manfred Stienstra | 2008-09-21 | 3 | -7/+7 | |
| | | ||||||
* | | Change call to String#chars in inflector to String#mb_chars. | Manfred Stienstra | 2008-09-21 | 1 | -1/+1 | |
| | | ||||||
* | | Deprecated String#chars in favor of String#mb_chars. | Manfred Stienstra | 2008-09-21 | 2 | -1/+10 | |
| | | ||||||
* | | Move multibyte test helpers to a separate file and make the conformance ↵ | Manfred Stienstra | 2008-09-21 | 3 | -22/+26 | |
| | | | | | | | | tests run again. | |||||
* | | Add tests for u_unpack to make sure it raises an EncodingError on invalid ↵ | Manfred Stienstra | 2008-09-21 | 2 | -1/+12 | |
| | | | | | | | | UTF-8 strings. | |||||
* | | Fix a test that assumes .mb_chars to always return an instance of the ↵ | Manfred Stienstra | 2008-09-21 | 1 | -7/+23 | |
| | | | | | | | | proxy_class. | |||||
* | | Non-string results from forwarded methods should be returned vertabim. | Manfred Stienstra | 2008-09-21 | 2 | -9/+15 | |
| | | ||||||
* | | Remove special 1.9 version of excerpt helper. | Manfred Stienstra | 2008-09-21 | 1 | -45/+45 | |
| | | ||||||
* | | Improve documentation. | Manfred Stienstra | 2008-09-21 | 4 | -67/+74 | |
| | | ||||||
* | | Change all calls to String#chars to String#mb_chars. Remove a exception for ↵ | Manfred Stienstra | 2008-09-21 | 2 | -89/+43 | |
| | | | | | | | | Ruby <= 1.9. | |||||
* | | All methods which normally return a string now return a proxy instance. | Manfred Stienstra | 2008-09-21 | 2 | -9/+43 | |
| | | ||||||
* | | Change all calls to String#chars to String#mb_chars. | Manfred Stienstra | 2008-09-21 | 2 | -15/+15 | |
| | |