| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ /
| | |
| | |
| | | |
It's not public API so don't document it.
|
|\ \ \
| |/ /
|/| | |
Fix ActiveSupport::Cache compression
|
| | |
| | |
| | |
| | | |
(See previous commit for a description of the issue)
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On Rails 5.2, when compression is enabled (which it is by default),
the actual value being written to the underlying storage is actually
_bigger_ than the uncompressed raw value.
This is because the `@marshaled_value` instance variable (typically)
gets serialized with the entry object, which is then written to the
underlying storage, essentially double-storing every value (once
uncompressed, once possibly compressed).
This regression was introduced in #32254.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
teddywing/active-support-cache-store--fix-end-tag-in-read-method-documentation
Cache::Store#read: Fix fixed-width end tag in docs
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Fix the ending `</tt>` tag for `:expires_in`. Otherwise, the "or" is
set in fixed-width also.
* Re-wrap paragraph to 80 columns.
[ci skip]
|
|\ \ \ \
| |/ / /
|/| | | |
Define callbacks on descendants.
|
| | | |
| | | |
| | | |
| | | | |
Addresses feedback from https://github.com/rails/rails/pull/31913#issuecomment-365983580
|
| | | |
| | | |
| | | |
| | | | |
We set callbacks on all descendants, so we need to make sure that they are also defined on all descendants as well.
|
|\ \ \ \
| |_|/ /
|/| | | |
Fix MySpace Samy worm link [ci skip]
|
|/ / /
| | |
| | |
| | | |
The old link https://samy.pl/popular/tech.html is 404 not found.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
lsylvester/fix-immutable-relation-error-with-http-caching-and-collection-caching
Fix ActiveRecord::ImmutableRelation is raised when collection caching and HTTP caching are used together
|
|/ / /
| | |
| | |
| | | |
effect the arel and the arel may already be generated by fresh_when
|
|\ \ \
| | | |
| | | | |
Use frozen string literal
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
See https://github.com/rails/rails-docs-server/pull/8 for reason.
[ci skip]
|
| | |
| | |
| | |
| | |
| | | |
The issue was fixed with https://github.com/petergoldstein/dalli/pull/679,
and a new version containing that fix was released.
|
|\ \ \
| | | |
| | | | |
Fix turbolinks warning in railties test
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Upgrade turbolinks from v5.0.1 to v5.1.0
* Fix warning in railties test
lib/turbolinks/assertions.rb:17:
warning: assigned but unused variable - visit_action
|
|\ \ \ \
| | | | |
| | | | | |
Include default headers by default in API mode
|
| | | | |
| | | | |
| | | | |
| | | | | |
ActionDispatch's default headers are now moved into their own module that are by default included in both Base and API. This allows API-mode applications to take advantage of the default security headers, as well as providing an easy way to add more.
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We don't want people to jump from the last release in the previous
series (4.2) straing to the first release in the current series that is
support (5.1), so we should be supporting the entire series for severe
security issues.
This will not be a problem because usually we only have 3 releases in a
series and backporting patches inside the same series is not harder than
backporting to a previous series.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add explicit global namespace to `Rails::TestUnit::Runner` to resolve a
namespace conflict between `minitest-rails` and Rails test runner.
Fixes #31324
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There's no reason to block future versions of Capybara since we don't
_know_ they are going to break. How will we know if we have a
conservative option set? This change prevents us from blocking users who
want to upgrade in the future.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Active Storage: Always exclude JSON root from direct_uploads#create response
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The JavaScript component expects a bare response.
Fixes #32365
|
| | | | |
| | | | |
| | | | |
| | | | | |
It is the last major release series.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Prevent changes_to_save from mutating attributes
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When an array of hashes is added to a `HashWithIndifferentAccess`, the
hashes are replaced with HWIAs by mutating the array in place.
If an attribute's value is an array of hashes, `changes_to_save` will
convert it to an array of HWIAs as a side-effect of adding it to the
changes hash.
Using `merge!` instead of `[]=` fixes the problem, as `merge!` copies
any array values in the provided hash instead of mutating them.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
bogdanvlviv/add-test_request_format_kwarg_doesnt_mutate_params
Add `TestCaseTest#test_request_format_kwarg_doesnt_mutate_params` to master
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Initially, the test was added to 5-0-stable in #32492
and a bit modified in #32506. This test ensures that request(in tests)
doesn't mutate params. It was fixed since v5.1.0.beta1 by
98b8309569a326910a723f521911e54994b112fb and then on 5-0-stable by #32492.
This commit adds this test to master branch in order to prevent any
regressions.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Correct Maintenance Policy for Rails 5.2
[ci skip]
|
| |/ / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Update bug report templates
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Set Rails 5.2.0 in templates
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Only disable headless chrome gpu on Windows
|
| | | | | |
| | | | | |
| | | | | | |
Per Chromium team this has not been necessary on other platforms for quite some time: https://bugs.chromium.org/p/chromium/issues/detail?id=737678#c1
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This was causing single db applications to have rake tasks named
`db:create:primary`. These tasks are only useful to multiple database
applications so they shouldn't be generated.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I realized I wasn't really testing some of the new rake tasks added so I
built out this new test that uses a multi-db database.yml and allows us
to run create/drop/migrate/schema:dump/schema:load and those that are
namespaced like create:animals. This will make our testing more robust
so we can catch problems quicker and set a good place to add future
tests as these features evolve.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Pass the spec name to load_schema in order to load from the correct
structure file when there are multiple databases
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Improve the null origin error message
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | | |
eugeneius/mutation_tracker_changed_attribute_names
Avoid generating full changes hash on every save
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`changed_attribute_names_to_save` is called in `keys_for_partial_write`,
which is called on every save when partial writes are enabled.
We can avoid generating the full changes hash by asking the mutation
tracker for just the names of the changed attributes. At minimum this
saves one array allocation per attribute, but will also avoid calling
`Attribute#original_value` which is expensive for serialized attributes.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix leftover references to VariantsController in AS documentation [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
VariantsController has been merged to RepresentationsController, this
PR fixes outdated references to VariantsController in ActiveStorage documentation.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Mocha updates
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Mocha v1.5.0 is currently the latest release.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This has been possible since Mocha v1.0 and makes it clear that we want
Mocha to integrate with Minitest, not Test::Unit.
|