| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
previously the tests with and without a custom `inheritance_column`
used the same models. Since the model then has both fields this can lead
to false positives.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
#becomes works with configured inheritance_column
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
I had to create a new table because I needed an STI table,
which does not have both a "type" and a "custom_type"
the test fails with:
1) Error:
test_alt_becomes_works_with_sti(InheritanceTest):
NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber">
/Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing'
/Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing'
/Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes'
test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti'
test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fixed markup in Upgrading RoR guide [ci skip]
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
There are two changes:
- Using <ruby> syntax for unicode character routes example instead of
<tt> since it causes single quotes to be transformed into inverted
commas. This makes this required change more eye-catching.
- Using <tt> for the j alias and related helpers as written in the
documentation guidelines.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix example code: use tasks instead of comments [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Properly reset the session on reset_session
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Use load_for_write! to ensure a refresh of the session object.
This way the new session_id and the empty data will be stored properly.
E.g. in the case of the session cookie store this means that a new
digest will be returned to the user.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #7478
|
|\ \ \ \ \ \ |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This reverts commit fc80ebb13328eb5f233f65408ba281bf0f8ce68e.
Such changes aren't allowed in docrails.
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
SessionHash isn't a thing, and tenses are wrong.
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fixed little mistake in the docs
|
| |/ / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The example is about a Person model, say that "params[:model] would usually be a
hash of all the attributes for the person to create" could be confusing.
I changed to params[:person] since the example is about a Person creation.
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Added a bullet for :enable_starttls_auto in the smtp_settings table
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
incorrectly using symbol instead of string
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Per https://github.com/lifo/docrails/commit/e94e8d8c3fcac624466afcf61f6a118abe5a6af4#commitcomment-1784677
Thanks @randomecho!
This reverts commit e94e8d8c3fcac624466afcf61f6a118abe5a6af4.
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
minor update to asset_pipeline docs describing apache config
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
In the text there is a section about how to serve the assets with
far-future headers. The snippet that is proposed doesn't work on Ubuntu
11 (probably others) as mod_expires is not enabled out-of-the-box. I
noted this, and gave an example of how to load mod_expires with a2enmod.
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Added clairifications for default security headers.
|
| |/ / / / / / / |
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Default headers description
|
| |/ / / / / / / |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
think that a quoted string will be better as it will automatically
escape double-quotes as well
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
after running, git add .
do not need -a option to git commit
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Correct :error -> :alert, mention FlashHash class, mention that
you're not limited to notices and alerts, clean up.
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix rake guides:validate
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
If the validation of a guide encounters an exception, inform about it
and continue with the loop to validate the rest.
|
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This rake task was looking for the output folder in the wrong place.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
directory; add exception handling"
This kind of changes should go on a pull request instead.
This reverts commit ecae2f0ef0452f8d333525a6aed58e5ab8d3ccb1.
|
| |\ \ \ \ \ \ \ |
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
add exception handling
|
| |/ / / / / / / |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
The app generator is not generally run under bundler, but the Bundler
constant is used here.
In particular you cannot create --dev apps without this.
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
ActionView decoupling and sprockets-rails tests fail
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Method invalid_asset_host! was delegated to controller but sprockets
compile assets in their own scope without controller. And if we set asset_host
with second parameter it should raise error through invalid_asset_host!.
But since controller is nil it cannot be reached.
|