| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |_|/ / /
| |/| | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Use appropriate type to `header` option
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | | |
The `header` option checks only whether it is specified or not.
https://github.com/rails/rails/blob/e8c33349bfabca28996ac74d344d69c7aaffec50/railties/lib/rails/commands/dbconsole/dbconsole_command.rb#L52
|
| | | | |
| | | | |
| | | | |
| | | | | |
https://bugs.ruby-lang.org/issues/13239
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Don't highlight code in anchorlink [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Minor fix to #28662
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Downplay links in Guides headers
|
|/ / / /
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Update backtrace cleaner to use `Regexp#match?`
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clear active connections after initialization
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Any connections that were checked out during initialization should be
checked back in before the first request is processed, for two reasons:
- Returning the connection to the pool allows it to be health checked
before it's used again. If the connection dies before the first
request arrives, the health check will replace it with a new one.
- If the thread that initialized Rails is not the same thread that will
be performing work, checking in the connection will allow it to be
reused instead of being stuck to the initialization thread forever.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Raise NotImplementedError when using empty_insert_statement_value with Oracle
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Refer: https://github.com/rsim/oracle-enhanced/pull/1180
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This reverts commit a680a5814184e2f37c4686aa53d0ad3c7fb6b1ee, reversing
changes made to 842f67dd242e738419f27e752ea7dcd0bbe87b6d.
Reason: I can't resist to the joke, so better to keep it there
https://github.com/rails/rails/pull/28598#issuecomment-290945339.
|
|\ \ \ \ \ \ \
| |_|_|_|/ / /
|/| | | | | | |
CI against Ruby 2.4.1
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Related #28532, #27636
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 82a7593e3ac427215a280dae5bd6cd42f9404650.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add anchor links to all headers
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
To allow easy linking at all levels and not just from index
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
No need to check nil
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
```ruby
nil.respond_to?(:stringify_keys) # => false
```
```ruby
include ActiveModel::AttributeAssignment
Object.new.assign_attributes(nil) # => ArgumentError: When assigning attributes, you must pass a hash as an argument.
```
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Limit stale checks to issues
|
| |/ / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This CHANGELOG.md is a continuation of the 5-1-stable one, there
shouldn't be any duplicate entries.
[ci skip]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add default_scope note to ActiveRecord guide
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Adds note to explain unexpected behavior described in issue #28561.
Developers may be surprised that the internal representation of similar
query conditions in Hash and Array formats in default_scope will yield
different results for model initialization.
Link: https://github.com/rails/rails/issues/28561
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix a failed AR test when running with OracleAdapter
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
CI against Ruby 2.3.4
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
https://www.ruby-lang.org/en/news/2017/03/30/ruby-2-3-4-released/
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
y-yagi/add_missing_backtick_to_deprecation_message
Add missing backtick to deprecation message
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix example usage of ActiveRecord::Base.establish_connection [ci skip]
|
| | | | | |
| | | | | |
| | | | | | |
`ActiveRecord::Base.establish_connection` accepts a single symbol argument to specify a named connection; a single string argument appears to be interpreted as a connection URI
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Restore rails-ujs.js UMD module support
|
| | | | | | | |
|
| |/ / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Move HashWithIndifferentAccess tests to separate file
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Do not include default response headers for AC::Metal
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In Rails 4.2, `ActionController::Metal` controllers did not include the
default headers from `ActionDispatch::Response`. However, through e16afe6, and a
general shift towards having `ActionController::Metal` objects contain
`ActionDispatch::Response` objects (instead of just returning an array
of status, headers, and body), this behavior was lost. This PR helps to
restore the original behavior by having `ActionController::Metal`
controllers generate Response objects without the default headers, while
`ActionController::Base` now overrides the factory method to make sure
its version does have the default headers.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Update comment in sanitizer helper test [skip ci]
|
| | |/ / / / /
| |/| | | | |
| | | | | | | |
The previously referenced file no longer appears to exist in the project.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Raise when using a bad symlink
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
There was a case where a dev made a symlink that worked on some machines and not on others. The issue manifested itself on a machine with `RAILS_ENV=staging` as the had their `config/environments/staging.rb` symlinked to another config file. The behavior was very hard to track down.
Current behavior: If you use a bad symlink in a file, you get no warnings or failures or anything. If you have a bad symlink it just ignores the file as if it didn't exist (`File.exist?` returns false for a bad symlink).
Patch behavior: With this patch when a file is not present we check if a symlink exists. If it does, that indicates there is a bad symlink and we should raise
```
File "config/environments/staging.rb" is a symlink that does not point to a valid file
```
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Add an alias for reverse_merge to with_defaults
|