| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
Because this is not a test case.
|
|\ \ \
| | | |
| | | | |
Remove outdated comment [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
We do not use double assign since 61f92f8bc5fa0b486fc56f249fa23f1102e79759.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If `reflection_scope.where_clause` is not empty, `through_scope` should
be joined the source association. But if `values[:references]` in
`reflection_scope` is empty, the source association will not be joined.
It should use `source_reflection.table_name` in that case.
Fixes #22535.
Closes #28763.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
koic/fix_cant_modify_frozen_string_error_in_ac_rendering
Fix `can't modify frozen String` error in AC::Rendering
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Replace unnecessary link with typewriter text [ci skip]
|
| | | | | | |
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If `reflection_scope.where_clause` is not empty, `through_scope` should
be joined the source association. But if the through association doesn't
have explicit `:source`, `options[:source]` will be nil and
`scope.includes_values` will also be empty. It should use
`source_reflection.name` rather than `options[:source]`.
Fixed by a26cff3c1235c61cd0135bed4ef63d7be452b458.
Fixes #11078.
Fixes #26129.
Closes #14312.
Closes #29155.
Closes #29841.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Without this fix, preloading `:comments_with_include` will cause the
following error:
```
% bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_with_has_many_through_join_model_with_include
Using sqlite3
Run options: -n test_eager_with_has_many_through_join_model_with_include --seed 1502
E
Error:
EagerAssociationTest#test_eager_with_has_many_through_join_model_with_include:
ActiveRecord::AssociationNotFoundError: Association named 'post' was not found on Post; perhaps you misspelled it?
```
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If `reflection_scope.where_clause` is empty, `scope` isn't changed. So
`scope.eager_loading?` is always false.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Bump PostgreSQL version to the latest version 9.6 at Travis CI
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Travis CI new default Ubuntu Trusty supports 9.6
https://docs.travis-ci.com/user/database-setup/#Using-a-different-PostgreSQL-Version
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Remove unnecessary `to_i` for old sqlite3 adapter
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`to_i` was added for SQLite3 adapter which did not handle number
but sqlite3 gem already supports it then `to_i` is unnecessary.
else condition is kept for adapters which return string,
i.e. mysql(not mysql2) and sqlserver.
Renamed `test_cache_does_not_wrap_string_results_in_arrays`
to `test_cache_does_not_wrap_results_in_arrays` to explain the
current behavior. most of adapters return integer, not only string.
* Refer these commits:
"future proofing the sqlite3 adapter code"
https://github.com/rails/rails/commit/beda2d43d6ac5c3435fc2fba0cbd108c20fe1c67
"Refactor calculation test to remove unneeded SQLite special case."
https://github.com/rails/rails/commit/47d568ed3fc701934ebe80b276f3d8bf6951c93f
"no need to to_i, sqlite does that for us"
https://github.com/rails/rails/commit/6cf44a1bd64ba10497742d70ad78fe68faa16e99
|
|\ \ \ \
| | | | |
| | | | | |
CI with the latest stable(GA) version of MariaDB 10.2
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
when tested with MariaDB 10.2.8 or higher
Refer #30485
https://mariadb.com/kb/en/the-mariadb-library/alter-table/#drop-column-if-exists-col_name-cascaderestrict
> MariaDB starting with 10.2.8
> Dropping a column that is part of a multi-column UNIQUE constraint is not permitted.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Travis CI is migrating Ubuntu version to Trusty
- MariaDB 10.2 is supported on Ubuntu Trusty
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
type columns
Fixes #30496.
|
| | | |
| | | |
| | | |
| | | | |
This is no longer used since 79a5ea9eadb4d43b62afacedc0706cbe88c54496.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
since r59328
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
`def a() x = x = 1; end` warns since Ruby 2.5 (r59585)
|
|\ \ \ \
| | | | |
| | | | | |
Remove needless `silence_warnings`
|
| | | | |
| | | | |
| | | | |
| | | | | |
Since ff30db1, warning is not show.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clarify intentions around method redefinitions
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Don't use remove_method or remove_possible_method just before a new
definition: at best the purpose is unclear, and at worst it creates a
race condition.
Instead, prefer redefine_method when practical, and
silence_redefinition_of_method otherwise.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/fix_cant_modify_forzen_string_error_in_XmlMini_JDOM
Fix `can't modify frozen String` error in `XmlMini_JDOM`
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Without this, `XmlMini_JDOM` raises an error as follwing:
```
RuntimeError: can't modify frozen String
org/jruby/RubyString.java:2264:in `concat'
activesupport/lib/active_support/xml_mini/jdom.rb:177:in `block in empty_content?'
org/jruby/RubyRange.java:485:in `each'
activesupport/lib/active_support/xml_mini/jdom.rb:174:in `empty_content?'
activesupport/lib/active_support/xml_mini/jdom.rb:86:in `collapse'
activesupport/lib/active_support/xml_mini/jdom.rb:66:in `merge_element!'
activesupport/lib/active_support/xml_mini/jdom.rb:84:in `block in collapse'
org/jruby/RubyRange.java:485:in `each'
activesupport/lib/active_support/xml_mini/jdom.rb:82:in `collapse'
activesupport/lib/active_support/xml_mini/jdom.rb:66:in `merge_element!'
activesupport/lib/active_support/xml_mini/jdom.rb:51:in `parse'
activesupport/lib/active_support/xml_mini.rb:101:in `parse'
```
We already have tests about `XmlMini_JDOM`. But it is not running in CI.
https://github.com/rails/rails/blob/master/activesupport/test/xml_mini/jdom_engine_test.rb
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Ignore files already deleted on GCS file deletions
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Relying on the GET request issued first to fetch the file we want to
delete is not enough to avoid this error. If the file is deleted after
our GET request but before the DELETE request we'll get a NotFound error
that after all means that the file is already deleted, so it can be
safely ignored.
|
|\ \ \ \
| |/ / /
|/| | | |
In Action View Overview guide, remove reference to custom helpers [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Support multiple versions arguments for `gem` method of Generators
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Delegate :rindex, :slice, :rotate(missing) to 'records'
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Unify the internal source control .keep file name
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
wassimk/WAM-update-rubocop-to-latest-in-code-climate
Run CodeClimate with the latest Rubocop
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | | |
Update RDOC_MAIN.rdoc
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Add documentation about template partial caching
|