aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Merge pull request #29018 from willbryant/missing_attributes_after_saveRyuta Kamizono2018-01-032-0/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | fix the dirty tracking code's save hook overwriting missing attribute…
| * | | | | | | fix the dirty tracking code's save hook overwriting missing attributes with ↵Will Bryant2017-05-102-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | initialized-to-nil attributes. fixes #29017.
* | | | | | | | Restore support for the -layers transformationGeorge Claghorn2018-01-023-14/+22
| | | | | | | |
* | | | | | | | Avoid Minitest 5.11.0 for nowyuuji.yaginuma2018-01-022-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Seems some tests not work with Minitest 5.11.0. * https://travis-ci.org/rails/rails/jobs/323997512#L1053 * https://travis-ci.org/rails/rails/jobs/323997486#L1055 Ref: https://github.com/seattlerb/minitest/issues/729
* | | | | | | | Revert unintentional change in 41e3bbdJavan Makhmali2018-01-011-1/+1
| | | | | | | |
* | | | | | | | Improve `preventDefault` fix for rails-ujsJavan Makhmali2018-01-011-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improves 049a3374aa85f33091f0e7cba8635edd4b4786bd: * Attempt native `preventDefault()` before stepping in * Fix that calling `preventDefault()` more than once would throw an error * Fix that non-cancelable events could be canceled
* | | | | | | | Active Record: Bump license years for 2018 [ci skip]Ryuta Kamizono2018-01-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #31606.
* | | | | | | | Refactor to `Array(options[:on])` only once in defining validationsRyuta Kamizono2018-01-012-11/+13
| | | | | | | |
* | | | | | | | Add test case for `collection_singular_ids` with symbol primary keysRyuta Kamizono2018-01-012-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a regression test for #27864.
* | | | | | | | Remove `association_primary_key_type` from `AssociationReflection` and ↵Ryuta Kamizono2018-01-013-19/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `ThroughReflection` This method was introduced in #26718, which is internally used only in `CollectionAssociation`. There is no need to be in the reflection classes.
* | | | | | | | Added Railties deprecations in 5.2 release notes [ci skip]Prathamesh Sonpatki2018-01-011-2/+13
| | | | | | | |
* | | | | | | | Refactor delegating `join_primary_key` instead of `join_keys` and ↵Ryuta Kamizono2018-01-014-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `association_primary_key` in `TableMetadata` Because `join_primary_key` is called by `join_keys` and it is to abstract calling `association_primary_key`.
* | | | | | | | Merge pull request #31606 from yhirano55/bump_license_years_for_2018Arun Agrawal2017-12-3121-21/+21
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Bump license years for 2018
| * | | | | | | | Bump license years for 2018Yoshiyuki Hirano2017-12-3121-21/+21
| | | | | | | | |
* | | | | | | | | Expose ActiveStorage::Analyzer#logger in API docs [ci skip]George Claghorn2017-12-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify that it's public API and may be used in third-party analyzers.
* | | | | | | | | Expose ActiveStorage::Previewer#logger in API docs [ci skip]George Claghorn2017-12-311-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify that it's public API intended for use by third-party previewers. It shouldn't be removed without deprecation even though it isn't used by the built-in previewers.
* | | | | | | | | Suppress noise from drawing command invocationsGeorge Claghorn2017-12-311-1/+1
| | | | | | | | |
* | | | | | | | | Merge pull request #31575 from bogdan/bugfix-has-many-reattachmentRyuta Kamizono2018-01-013-13/+17
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Bugfix foreign key replacement in inverse association
| * | | | | | | | | Bugfix foreign key replacement in inverse associationBogdan Gusiev2017-12-273-13/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when model is added to collection association
* | | | | | | | | | Merge pull request #31310 from kinnrot/duration-moduloRyuta Kamizono2018-01-012-1/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Duration created with no parts will have a default seconds part eqaul to 0
| * | | | | | | | | | Empty duration inspect fixChen Kinnrot2017-12-132-1/+5
| | | | | | | | | | |
* | | | | | | | | | | Append extension to tempfile nameGeorge Claghorn2017-12-313-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes analyzing an SVG image without an XML declaration. ImageMagick occasionally looks to the extension when it can't discern the type of an image file from its contents. References #31356.
* | | | | | | | | | | Merge pull request #31607 from fatkodima/fix-sqlite-partial-indexesRyuta Kamizono2018-01-012-0/+18
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / |/| | | | | | | | | | Fix recreating partial indexes after alter table for sqlite
| * | | | | | | | | | Fix recreating partial indexes after alter table for sqlitefatkodima2017-12-312-0/+18
|/ / / / / / / / / /
* | | | | | | | | | Merge pull request #31602 from eugeneius/config_eager_loadRyuta Kamizono2017-12-313-8/+8
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Clarify that config.eager_load controls eager loading [ci skip]
| * | | | | | | | | | Clarify that config.eager_load controls eager loading [ci skip]Eugene Kenny2017-12-303-8/+8
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before Rails 4.0, `config.cache_classes` determined whether application code was eager loaded. The `config.eager_load` option was introduced to allow the two behaviours to be configured independently, but this documentation was never updated to reflect that change.
* | | | | | | | | | Fix `cache_key` with a relation having distinct and orderRyuta Kamizono2017-12-302-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can't replace existing SELECT list as long as having DISTINCT, it will cause incorrect result. And also, PostgreSQL has a limitation that ORDER BY expressions must appear in select list for SELECT DISTINCT. Therefore, we should not replace existing SELECT list when using DISTINCT. Fixes #29779.
* | | | | | | | | | Remove needless blank lines [ci skip]Ryuta Kamizono2017-12-301-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This broke the doc.
* | | | | | | | | | Merge pull request #31578 from ↵George Claghorn2017-12-293-4/+34
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Aquaj/feature/allow-callables-in-select-group-methods Allow the use of callable objects as group methods for grouped selects.
| * | | | | | | | | | Allow the use of callable objects as group methods for grouped selects.Jérémie Bonal2017-12-273-4/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced the uses of `group.send(...)` in `option_groups_from_collection_for_select` by calls to `value_for_collection(group, ...)`, allowing the use of procs, lambdas and other callable objects as parameters.
* | | | | | | | | | | Tweak headings [ci skip]George Claghorn2017-12-291-16/+16
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #31591 from nobu/patch-2Yuji Yaginuma2017-12-301-8/+1
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | let drb make temprary server
| * | | | | | | | | | | let drb make temprary serverNobuyoshi Nakada2017-12-291-8/+1
| | |_|_|_|_|_|_|/ / / | |/| | | | | | | | |
* / | | | | | | | | | Use released `delayed_job` instead of master versionyuuji.yaginuma2017-12-302-9/+4
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ref: https://github.com/collectiveidea/delayed_job/blob/master/CHANGELOG.md#414---2017-12-29
* | | | | | | | | | Fix `cache_key` with a relation having custom select and orderRyuta Kamizono2017-12-292-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can't replace existing select list as long as referenced by ORDER BY.
* | | | | | | | | | Demonstrate providing keyfile data in lieu of a path [ci skip]George Claghorn2017-12-281-24/+33
| | | | | | | | | |
* | | | | | | | | | Link to the client gems [ci skip]George Claghorn2017-12-281-3/+4
| | | | | | | | | |
* | | | | | | | | | Merge pull request #31574 from Fudoshiki/patch-1Guillermo Iguaran2017-12-281-0/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix IE 10 and IE 11's broken `preventDefault` for rails-ujs
| * | | | | | | | | | Fix IE 10 and IE 11's broken `preventDefault`Yuri S2017-12-271-0/+5
| | |_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/turbolinks/turbolinks/issues/233 https://stackoverflow.com/questions/23349191/event-preventdefault-is-not-working-in-ie-11-for-custom-events
* / | | | | | | | | Remove unused methodsyuuji.yaginuma2017-12-281-16/+0
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * `assert_header` and `assert_body` were unused since 6f6a589. * `assert_success` and `assert_missing` were unused since added.
* | | | | | | | | Merge pull request #31568 from bogdanvlviv/update-action_view_overview-guideRyuta Kamizono2017-12-271-6/+8
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Update "Action View Overview" guide [ci skip]
| * | | | | | | | | Update "Action View Overview" guide [ci skip]bogdanvlviv2017-12-261-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Provide full / Fix generated HTML by `form_for` in the example. - Provide full params in the example. - Express params[:person] in the sentence.
* | | | | | | | | | Merge pull request #31570 from y-yagi/ci_against_250Matthew Draper2017-12-271-1/+8
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | CI against ruby 2.5.0
| * | | | | | | | | CI against ruby 2.5.0yuuji.yaginuma2017-12-271-1/+8
|/ / / / / / / / /
* | | | | | | | | SQLite: Add more test cases for adding primary keyRyuta Kamizono2017-12-262-58/+100
| | | | | | | | |
* | | | | | | | | Make `sql_type` of primary key in SQLite to comparable with an integer (#28008)Ryuta Kamizono2017-12-262-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally I tried to add `assert_equal pk.sql_type, ref.sql_type`. But the assert failed even though the same type due to `sql_type` of primary key in SQLite is upper case. Prefer lower case like other types.
* | | | | | | | | Merge pull request #31562 from fatkodima/sqlite_migration_compatibilityRyuta Kamizono2017-12-262-1/+20
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix `add_column` with :primary_key type compatibility for SQLite
| * | | | | | | | | Fix `add_column` with :primary_key type compatibility for SQLitefatkodima2017-12-252-1/+20
| | | | | | | | | |
* | | | | | | | | | Prevent to install gems when run test (#31564)Yuji Yaginuma2017-12-262-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `invoke_all` cause `bundle install`. This will install gems actually defined in `Gemfile`. To avoid this, stubbed `bundle_command`. Fixes #31557
* | | | | | | | | | Merge pull request #31563 from Dorian/prevent-shadowing-outer-variablesYuji Yaginuma2017-12-261-4/+4
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | Prevent shadowing outer variables
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 00:41:30 +0000