| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix repeat of test; remove unused variable by use of each_key
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove ancient TODOs [ci skip]
|
| | |_|/ / /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix some typos found in activemodel
|
| |/ / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Move tests out from base_test.rb to inheritance_test.rb
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
These tests should be in inheritance_test.rb since its testing a
feature which is implemented in inheritance.rb
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SQLite3 3.6.8+ supports nested transactions [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
http://www.sqlite.org/lang_savepoint.html
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L130-L132
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
refer to the contributing guide on how to create issues.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
`rake db:create` does not change permissions of root user.
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Closes #8079.
I had to rework some of the tests because the mock allowed any arguments
for `connection.exeucte`. I think this is very dangerous as there could
anything be executed without the tests noticing it.
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
"utf8mb4"
Please, see rationale in the included CHANGELOG patch.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix rake test warnings in actionpack
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove unused parameter passed to assert_query_equal method
|
| |/ / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix regression: allow pass multipart option to form_for
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove extra lines from Rakefile, which threw warning
|
| | |/ / / / /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
refactor test to drop unnecessary hash creation, test directly instead
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Refactor Person/Friendship relationships to be more intuitive
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
PR #5210 added a Friendship model to illustrate a bug, but in doing so
created a confusing structure because both belongs_to declarations in
Friendship referred to the same side of the join. The new structure
maintains the integrity of the bug test while changing the follower
relationship to be more useful for other testing.
|
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There was an s missing in 'views'.
Fixes #9752.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 867dc1700f32aae6f98c4651bd501597e6b52bc0, reversing
changes made to 9a421aaa8285cf2a7ecb1af370748b0337818930.
This breaks anyone who's using ForceSSL: https://travis-ci.org/rails-api/rails-api/jobs/5556065
Please see comments on #8156 for some discussion.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When I updated these images, I must have gotten this one wrong. Now it's
right.
Fixes #9749.
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix for inflector's incorrect camelCase replacement for acronyms
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
disregarding specified acronyms, fixes #8015
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
The counter cache will now work correctly when the foreign key is changed. Fixes #9722.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
the primary key on an association will make sure that the corresponding
counter on the association is changed properly. Fixes #9722.
|
|\ \ \ \
| | | | |
| | | | | |
Method #primary_key? is not reused
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit b7d9d6e2cd5082d269dafbc0316e2107febe1451.
Per discussion with @jeremy and @rubys on Campfire.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
multipart POST - utf8 param name not encoded
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Rails default logging to STDOUT
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
senny/9712_option_to_turn_references_deprecation_off
make it possible to disable implicit join references.
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
Closes #9712.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reimplements the behaviour of Rails 3, as I couldn't see why we
shouldn't cache the object, and @alindeman had a good use case for
caching it:
https://github.com/rails/rails/commit/c86a32d7451c5d901620ac58630460915292f88b#commitcomment-2784312
|
|\ \ \ \ \
| | | | | |
| | | | | | |
rename `Relation#uniq` to `Relation#distinct`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We moved more and more away from passing options to finder / calculation
methods. The `:distinct` option in `#count` was one of the remaining places.
Since we can now combine `Relation#distinct` with `Relation#count` the option
is no longer necessary and can be deprecated.
|