aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* We don't need to check if the format exists to generate the url, it already ↵Carlos Antonio da Silva2010-09-261-8/+7
| | | | does it internally
* More cleanup on form helpersCarlos Antonio da Silva2010-09-261-11/+12
|
* Remove last tests with deprecated form_for and cleanup form_for helperCarlos Antonio da Silva2010-09-262-67/+51
| | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before.
* Select tags with array options are deprecated, removingCarlos Antonio da Silva2010-09-262-10/+0
|
* Refactor form_for helperCarlos Antonio da Silva2010-09-261-21/+11
|
* Review most of the form_for deprecated tests, missing tests with index like []Carlos Antonio da Silva2010-09-262-405/+322
|
* Remove deprecated stuff in ActionControllerCarlos Antonio da Silva2010-09-2629-58/+47
| | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController.
* There is no need to open AC::Base three times to setup tests.Carlos Antonio da Silva2010-09-261-27/+20
|
* There is no DeprecatedBlockHelpers in AV, so remove itCarlos Antonio da Silva2010-09-261-1/+0
|
* Fix active_resource assertions.José Valim2010-09-251-2/+2
|
* Fix app and actions generators testsPiotr Sarnacki2010-09-252-0/+9
| | | | | | | Normally Rails.application is an instance, but for those tests Rails.application needs to be class. Signed-off-by: José Valim <jose.valim@gmail.com>
* Refactor a few methods connected with namespacing in ↵Piotr Sarnacki2010-09-251-8/+9
| | | | | | Rails::Generators::NamedBase Signed-off-by: José Valim <jose.valim@gmail.com>
* Add namespacing to mailer generatorPiotr Sarnacki2010-09-253-0/+56
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add namespacing for observer generatorPiotr Sarnacki2010-09-253-0/+26
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add namespace for test_unit generatorsPiotr Sarnacki2010-09-254-3/+9
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Allow per Resource format settingsJacques Crocker2010-09-255-17/+25
| | | | | | | | | | Previously, ActiveResource was using the connection level formatter for get requests. This made it impossible to use custom formatters per resource. Additionally this commit makes the Connection request methods more consistent. It always returns a Response. The base will then decode it each the response using its format setting. Merging this commit will allow users to add custom formatters on a per Resource basis. This enables handling pagination responses from the server side, a very common use case that was previously impossible without monkeypatching XmlFormat. Signed-off-by: José Valim <jose.valim@gmail.com>
* Allow ActiveResource to work with non-generated ids [#5660 state:resolved]Jacques Crocker2010-09-255-5/+80
| | | | | | This commit updates new? so that it knows whether or not the record was actually new or not, and doesn't rely solely on the presence of id. This enables the ability to set a custom primary_key that is not autogenerated by the server. Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix 'warning: method redefined' [#5551 state:resolved]Krekoten' Marjan2010-09-251-4/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix logging when cache key contains % sign [#5570 state:resolved]Krekoten' Marjan2010-09-252-1/+17
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove duplicate helper methodKrekoten' Marjan2010-09-251-3/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Update abort message (ht: tilsammans).José Valim2010-09-251-1/+1
|
* Don't act destructively on ActiveModel::Name#human options hash. [#5366 ↵John Firebaugh2010-09-253-2/+13
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Don't duplicate Rack::Response functionality. [#5320 state:resolved]John Firebaugh2010-09-251-18/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add ActionDispatch::TestResponse tests.John Firebaugh2010-09-251-0/+21
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Rails.application is set anyway, we don't need to set it manually, this was ↵Piotr Sarnacki2010-09-252-3/+1
| | | | | | purpose of different behavior in tests and in application Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators fix: properly check if module should be created when creating a ↵Piotr Sarnacki2010-09-253-2/+11
| | | | | | namespaced model Signed-off-by: José Valim <jose.valim@gmail.com>
* memoized protected methods should remain protectedAndrew Kaspick2010-09-242-0/+16
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) ↵Marcelo Giorgi2010-09-242-1/+7
| | | | | | [#5688 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* attr_accessor_with_default should raise an ArgumentError not a RuntimeErrorAaron Patterson2010-09-242-4/+3
|
* Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved]Brian Candler2010-09-241-1/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* got rid of the "ambiguous first argument; put parentheses or even spaces" ↵Jeff Kreeftmeijer2010-09-241-32/+32
| | | | | | warnings in the scaffold_generator tests [#4872 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Bump thor version requirement.José Valim2010-09-242-3/+1
|
* Refactor namespaced generators to use module_namespacing block helperPiotr Sarnacki2010-09-249-17/+24
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators are not aware of namespace of isolated engines and applicationsPiotr Sarnacki2010-09-247-10/+194
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* restore behavior of touch for models without :updated_xx [#5439 state:resolved]tnp2010-09-242-8/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Properly interpolate i18n keys in modules [#5572 state:resolved]Rodrigo Rosenfeld Rosas2010-09-245-8/+37
|
* These tests shouldn't depend on local time to pass or fail, we can use utc here.Emilio Tagua2010-09-242-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix typo and add sanity test for code statistics rake task.Emilio Tagua2010-09-242-2/+7
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Ensures the app generator generates the correct @app_name. [#5434 ↵Fred Wu2010-09-242-4/+8
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* There is no need to use instance_eval since the proc is created in the same ↵José Valim2010-09-241-1/+1
| | | | context it is eval'ed.
* only abort in test_help in production envDavid Chelimsky2010-09-241-3/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Make redirect_to accept blocks [#5643 state:resolved]Nando Vieira2010-09-242-1/+43
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Better shortcut options for custom validators [#5672 state:resolved]Obie Fernandez2010-09-243-5/+32
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* reject_id option should be respected while using nested_attributesNeeraj Singh2010-09-242-3/+12
| | | | | | [#5579 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Changed documentation for auto_link so that the truncate example works ↵Kevin Hughes2010-09-241-1/+1
| | | | | | [#5694 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com>
* resolves rdoc conflictXavier Noria2010-09-2314-68/+74
|\
| * some fixes in routing guideeparreno2010-09-221-5/+5
| |
| * Document form_for behaviour when using file_field inside the blockJoost Baaij2010-09-212-3/+7
| |
| * Remove mention of Rails 3 deprecated option ↵Simone Carletti2010-09-201-2/+0
| | | | | | | | | | config.action_controller.use_accept_header. See http://github.com/rails/rails/blob/v3.0.0/actionpack/lib/action_controller/deprecated/base.rb#L108-111
| * updated instructions on how to change the default session storeDiego Carrion2010-09-181-2/+2
| |