Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| | * | | | | | | | | | Routing is a named concept now | David Heinemeier Hansson | 2018-09-19 | 5 | -11/+11 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Test routing runs through a job kicked off by the inbound email | David Heinemeier Hansson | 2018-09-19 | 1 | -0/+7 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Temp routing directly to named controller | David Heinemeier Hansson | 2018-09-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Need the singleton to live somewhere proper. | |||||
| | * | | | | | | | | | Everyone needs job testing | David Heinemeier Hansson | 2018-09-19 | 3 | -5/+2 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Ensure raw email is created first | David Heinemeier Hansson | 2018-09-19 | 1 | -5/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise jobs hanging off the InboundEmail won't be able to access the Active Storage data (as it won't have been uploaded yet). | |||||
| | * | | | | | | | | | Simpler class definition | David Heinemeier Hansson | 2018-09-19 | 1 | -6/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't actually remember why we've used the explicit module wrapper before? | |||||
| | * | | | | | | | | | Add easy way to get logging information inline for test failure diagnosis | David Heinemeier Hansson | 2018-09-19 | 1 | -0/+4 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Attach a concrete router to the root mailbox and use it | David Heinemeier Hansson | 2018-09-19 | 6 | -14/+55 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't think this is how it's going to stay. Doesn't feel like the right place for it. | |||||
| | * | | | | | | | | | Included in test helper now | David Heinemeier Hansson | 2018-09-19 | 1 | -2/+0 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Add incineration by default | David Heinemeier Hansson | 2018-09-19 | 5 | -0/+76 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Follow db table convention | David Heinemeier Hansson | 2018-09-19 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Tmp files | David Heinemeier Hansson | 2018-09-19 | 1 | -0/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Make debugger available in testing | David Heinemeier Hansson | 2018-09-19 | 1 | -0/+2 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Missing suffix | David Heinemeier Hansson | 2018-09-19 | 1 | -0/+0 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Only deliver pending emails to the mailroom | David Heinemeier Hansson | 2018-09-18 | 3 | -3/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it easier to test without triggering this behavior. | |||||
| | * | | | | | | | | | Inherit from ActiveJob::Base rather than ApplicationJob | David Heinemeier Hansson | 2018-09-18 | 2 | -7/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't want to trigger app-specific behavior here. | |||||
| | * | | | | | | | | | Prefix queue name like we do routes | David Heinemeier Hansson | 2018-09-18 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Make a note for tying inbound email to exception | David Heinemeier Hansson | 2018-09-18 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Then InboundEmail doesn't need to serialize or track the exception that went with it. The arrow will point the other way. | |||||
| | * | | | | | | | | | Add callbacks | David Heinemeier Hansson | 2018-09-18 | 3 | -2/+60 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Extract mailbox test suites into feature-specific slices | David Heinemeier Hansson | 2018-09-18 | 2 | -36/+34 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | More scalable name! | David Heinemeier Hansson | 2018-09-18 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There'll probably be other concerns we need to do around the processing. | |||||
| | * | | | | | | | | | Proper order | David Heinemeier Hansson | 2018-09-18 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Process inbound emails with state and exceptions | David Heinemeier Hansson | 2018-09-18 | 2 | -1/+51 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Use rails scope by default | David Heinemeier Hansson | 2018-09-18 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Add test for unsupported content type | David Heinemeier Hansson | 2018-09-18 | 2 | -0/+9 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Remember to add access protection | David Heinemeier Hansson | 2018-09-18 | 1 | -0/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Use a test helper to create fixtures rather than rely on them being predefined | David Heinemeier Hansson | 2018-09-18 | 3 | -23/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Too much hassle to manage all the steps compared to just pointing to an .eml fixture and having it setup for you. | |||||
| | * | | | | | | | | | Add basic, unauthenticated inbound emails controller | David Heinemeier Hansson | 2018-09-17 | 3 | -0/+40 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Assert the intended email was processed | David Heinemeier Hansson | 2018-09-17 | 1 | -2/+2 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | No byebug history plz | David Heinemeier Hansson | 2018-09-17 | 1 | -0/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Keep the riff raff out | David Heinemeier Hansson | 2018-09-17 | 1 | -0/+3 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Save this for a little later | David Heinemeier Hansson | 2018-09-17 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | First end-to-end rickety test | David Heinemeier Hansson | 2018-09-17 | 8 | -24/+656 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | WIP: Router | David Heinemeier Hansson | 2018-09-17 | 3 | -0/+36 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Add dummy app for testing | David Heinemeier Hansson | 2018-09-17 | 78 | -2/+7400 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Wait on this for later | David Heinemeier Hansson | 2018-09-17 | 1 | -3/+0 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Full name for the job | David Heinemeier Hansson | 2018-09-17 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | TOC ordering | David Heinemeier Hansson | 2018-09-17 | 1 | -1/+3 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Plural table name | David Heinemeier Hansson | 2018-09-17 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Base -> Mailbox | David Heinemeier Hansson | 2018-09-17 | 3 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Won't need Base and can separate routing from execution 👍 | |||||
| | * | | | | | | | | | Action Mailbox -> Action Mailroom | David Heinemeier Hansson | 2018-09-17 | 12 | -36/+36 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Add inbound email | David Heinemeier Hansson | 2018-09-17 | 3 | -0/+37 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Copypasta is delicious! | David Heinemeier Hansson | 2018-09-17 | 1 | -1/+1 | |
| | | | | | | | | | | | ||||||
| | * | | | | | | | | | Skeleton | David Heinemeier Hansson | 2018-09-17 | 11 | -0/+160 | |
| | / / / / / / / / | ||||||
* | | | | | | | | | | Merge pull request #34791 from y-yagi/fixes_34787 | Yuji Yaginuma | 2018-12-26 | 1 | -0/+221 | |
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | Generate doc of methods provided by form builders [ci skip] | |||||
| * | | | | | | | | | | Generate doc of methods provided by form builders [ci skip] | yuuji.yaginuma | 2018-12-26 | 1 | -0/+221 | |
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because method arguments are different in the methods provided by form helpers and form builders, I think these are necessary to prevent confusion. Fixes #34787 | |||||
* / / / / / / / / / | Specify `hosts` in bug report template. | yuuji.yaginuma | 2018-12-25 | 1 | -0/+1 | |
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Host authentication introduced by #33145 allows only "0.0.0.0/0", "::/0" and "localhost" in the development environment. https://github.com/rails/rails/blob/4298df00ae6219b9b5b7c40f281d4fa4d66f4383/railties/lib/rails/application/configuration.rb#L33 But `rack-test` use `example.org` for default host. https://github.com/rack-test/rack-test/blob/6c07bf53adf4a4082e206561f5b9b43142fdc821/lib/rack/test.rb#L13 Therefore, if `hosts` is not specified, host authentication rejects the request. In Travis CI, this problem does not occur because `test` is specified by default in `RAILS_ENV` and `RACK_ENV`. https://docs.travis-ci.com/user/environment-variables/#default-environment-variables If user actually use it, env may not always be specified. Explicitly specify hosts in the file so that it works in any environment. | |||||
* | | | | | | | | | Merge pull request #34781 from kossnocorp/patch-1 | Kasper Timm Hansen | 2018-12-24 | 1 | -2/+2 | |
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Make Rails Facebook-free | |||||
| * | | | | | | | | | Make Rails Facebook-free | Sasha Koss | 2018-12-24 | 1 | -2/+2 | |
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | If Basecamp is a Facebook-free business, then Rails should be Facebook-free framework. | |||||
* | | | | | | | | | Add missing require for `IPAddr` | yuuji.yaginuma | 2018-12-24 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ref: https://travis-ci.org/rails/rails/jobs/469956825#L1694 |