| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
mcfiredrill/contributing-to-rails-bugs-arent-fixes
[ci skip] change sentence about reporting bugs in contributing guide
|
| | | | | |
|
| | | | | |
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
I think I know what this sentence is trying to say, but the sentence
didn't really make sense, bugs don't fix things! How about this take on
it? :sweat_smile:
|
|\ \ \ \
| | | | |
| | | | | |
Improve duplicable documentation [ci skip]
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Remove the reference to mocha in activemodel
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Activemodel is no longer dependent on mocha, so we can make the comments
more generic.
|
| | | |
| | | |
| | | |
| | | | |
constant loading should be thread safe now, so lets remove this
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Concurrent load interlock (rm Rack::Lock)
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We can't actually lean on Rack::Lock's implementation, so we'll just
copy it instead. It's simple enough that that's not too troubling.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We don't need to fully disable concurrent requests: just ensure that
loads are performed in isolation.
|
| | | | |
| | | | |
| | | | |
| | | | | |
See 2f26f611 for more info.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Also fix Minitest constant reference.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
PATH_INFO is already set, so this branch will never execute.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
we were already generating a path in the previous code (it was just not
returned), so lets just use the already computed path to popluate the
PATH_INFO header
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Since we only work with new instances, these ivars will not be set.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We should call the setter on `path_parameters` so that we know the hash
will only contain the values that we've set.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I'd like to put all env mutations together so we can understand how to
change this code to call `call` on the controller
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since parameters are converted to a query string, they will
automatically be turned in to strings by the query parser
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
non_path_parameters is used internally (it never escapes this method) so
we should be able to safely use a regular hash.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
since we are serializing parameters, we don't need to do all the dup
checks on each object.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We should roundtrip the parameters through their respective encoders /
decoders so that the controller will get parameters similar to what they
actually get in a real world situation
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Require yaml for time_with_zone isolation test
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Same fix as 109e71d2bb6d2305a091fe7ea96d4f6e9c7cd52d but after
mocha got removed in 2f28e5b6417fd4e5d6060983b36262737558b613.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
pass in the instance variable to start decoupling the meat of the parser
from the instance of the middleware
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We will always make an assignment to the env hash and eliminate a
conditional
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
active_support/indifferent_access: fix not raising when default_proc does
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If we only deal with proc objects, then we can eliminate type checking
in the parameter parsing middleware
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Removed use of mocha in Active Support
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Allow `pluralize` helper to take a locale.
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
This is already supported in `ActiveSupport::Inflector#pluralize` and `String#pluralize`, so we just forward the locale.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We should use rack-test's upload file objects on the test side so that
we will be able to correctly generate mime blob posts in the future
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We should convert request parameters to a query string, then let the
request object parse that query string. This should give us results
that are more similar to the real-world
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Add Deserialization section on guides at ActiveJob Exception [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We should assign parameters to the request object rather than mutate the
hash that is returned by `query_parameters` or `request_parameters`
|
| | | | | | |
|