Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove dead code | Aaron Patterson | 2014-05-12 | 1 | -12/+0 |
| | |||||
* | only test `persisted?` on the record once | Aaron Patterson | 2014-05-12 | 1 | -3/+7 |
| | | | | | also avoid the case of calling `persisted?` on something that doesn't respond to it | ||||
* | only send options if there are any options | Aaron Patterson | 2014-05-12 | 1 | -5/+7 |
| | |||||
* | add a test for the parameters sent to the url helper for new records | Aaron Patterson | 2014-05-12 | 1 | -0/+15 |
| | |||||
* | remove should_pop variable | Aaron Patterson | 2014-05-12 | 1 | -4/+1 |
| | |||||
* | only pop records when we get an array | Aaron Patterson | 2014-05-12 | 1 | -6/+7 |
| | |||||
* | remove unnecessary array allocations | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -5/+1 |
| | |||||
* | simplified route method name generation | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 2 | -27/+19 |
| | |||||
* | small refactoring | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -6/+2 |
| | |||||
* | pulling helpermethods up before refactoring | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -20/+46 |
| | |||||
* | push all is_a tests up, always pass options to the named route | Aaron Patterson | 2014-05-12 | 1 | -28/+27 |
| | |||||
* | pull nil checks up | Aaron Patterson | 2014-05-12 | 1 | -3/+5 |
| | |||||
* | skip another Array is_a check | Aaron Patterson | 2014-05-12 | 1 | -4/+6 |
| | |||||
* | only do the Array is_a check once | Aaron Patterson | 2014-05-12 | 1 | -4/+3 |
| | |||||
* | we always convert this variable to a list, so we can remove the unconversion | Aaron Patterson | 2014-05-12 | 1 | -1/+0 |
| | |||||
* | record as a hash is not possible, so rm branch | Aaron Patterson | 2014-05-12 | 1 | -2/+0 |
| | |||||
* | stop popping in build_named_route_call | Aaron Patterson | 2014-05-12 | 1 | -4/+3 |
| | |||||
* | remove extract_record since we have extracted the list | Aaron Patterson | 2014-05-12 | 1 | -12/+1 |
| | |||||
* | always pass a list to build_named_route_call | Aaron Patterson | 2014-05-12 | 1 | -10/+19 |
| | |||||
* | add a test with three objects | Aaron Patterson | 2014-05-12 | 1 | -2/+13 |
| | |||||
* | add a test for passing two models to the polymorphic_url method | Aaron Patterson | 2014-05-12 | 2 | -1/+9 |
| | |||||
* | typo: resulution -> resolution [ci skip] | Godfrey Chan | 2014-05-12 | 1 | -1/+1 |
| | |||||
* | reduce conditionals in url_for | Aaron Patterson | 2014-05-12 | 1 | -3/+6 |
| | |||||
* | extract route key translation to a method and reuse it | Aaron Patterson | 2014-05-12 | 1 | -17/+14 |
| | |||||
* | make the module version quack the same as the instance | Aaron Patterson | 2014-05-12 | 1 | -3/+10 |
| | | | | this way we can stop checking respond_to on every call. | ||||
* | Hash#except is expensive and this is a hotspot, so use a dup + delete | Aaron Patterson | 2014-05-12 | 1 | -1/+2 |
| | |||||
* | test, use `columns_hash[]` in place of `columns.find {}`. | Yves Senn | 2014-05-12 | 8 | -12/+12 |
| | |||||
* | pg, `change_column_default` accepts `[]`. Closes #11586. | Yves Senn | 2014-05-12 | 4 | -3/+18 |
| | |||||
* | pg, map `char` and `name` types as string. [dark-panda & Yves Senn] | Yves Senn | 2014-05-12 | 3 | -0/+33 |
| | | | | Closes #10802. | ||||
* | Merge pull request #13334 from gregolsen/postgresql_infinity | Yves Senn | 2014-05-12 | 3 | -3/+30 |
|\ | | | | | | | | | | | | | | | | | | | pg, fix Infinity and NaN values conversion. Closes #13334. * rebased * removed guard * inlined guard into case statement | ||||
| * | pg, fix Infinity and NaN values conversion. | Innokenty Mihailov | 2014-05-12 | 3 | -3/+30 |
|/ | | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`. | ||||
* | Merge pull request #10505 from patricksrobertson/bigserial_id_not_identifying_pk | Yves Senn | 2014-05-12 | 3 | -1/+33 |
|\ | | | | | | | | | | | | | | | | | Handle other pk types in PostgreSQL gracefully. Closes #10505. - rebased - test slightly modified | ||||
| * | Handle other pk types in PostgreSQL gracefully. | Patrick Robertson | 2014-05-12 | 3 | -1/+33 |
|/ | | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb. | ||||
* | Merge pull request #14999 from yahonda/modify_bind_variable_name | Yves Senn | 2014-05-12 | 1 | -2/+3 |
|\ | | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999. | ||||
| * | Modify assert conditions not to be affected | Yasuo Honda | 2014-05-12 | 1 | -2/+3 |
| | | | | | | | | by each database bind variable naming conventions | ||||
* | | Merge pull request #15060 from tgxworld/remove_unnecessary_tests_method | Rafael Mendonça França | 2014-05-12 | 1 | -2/+0 |
|\ \ | | | | | | | Remove redundant tests method. | ||||
| * | | Remove redundant tests method. | Guo Xiang Tan | 2014-05-11 | 1 | -2/+0 |
| | | | |||||
* | | | Update attribute_methods.rb | Guillermo Iguaran | 2014-05-11 | 1 | -1/+1 |
| | | | | | | | | | Improve documentation | ||||
* | | | Merge pull request #15063 from cbeer/correct-attribute_present-docs | Guillermo Iguaran | 2014-05-11 | 1 | -7/+7 |
|\ \ \ | |/ / |/| | | correcting method documentation [ci skip] | ||||
| * | | correcting method documentation [ci skip] | Chris Beer | 2014-05-11 | 1 | -7/+7 |
| | | | |||||
* | | | Merge pull request #10662 from ↵ | Carlos Antonio da Silva | 2014-05-11 | 1 | -9/+9 |
|\ \ \ | | | | | | | | | | | | | | | | | take/change-test-name-for-ActiveRecord--Validations#valid- Refactor AR's validations_test.rb | ||||
| * | | | Refactor AR's validations_test.rb | Takehiro Adachi | 2013-12-03 | 1 | -9/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code | ||||
* | | | | Merge pull request #15059 from marcioj/patch-1 | Robin Dupret | 2014-05-11 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Replace :base with :in [ci skip] | ||||
| * | | | | Replace :base with :in [ci skip] | Marcio Junior | 2014-05-11 | 1 | -2/+2 |
|/ / / / | |||||
* | | | | Tidy up implementation of #15010 | Andrew White | 2014-05-11 | 2 | -11/+7 |
| | | | | |||||
* | | | | Make TimeZone#parse behave more like Time#parse. | Ulysse Carion | 2014-05-11 | 3 | -1/+25 |
| | | | | | | | | | | | | | | | | | | | | Namely, if the mday is omitted but any other upper components are, then instead of supplying the mday from the current time, it defaults to 1. | ||||
* | | | | docs, make `ActionNotFound` public API. [ci skip] | Yves Senn | 2014-05-11 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #15058. This exception is regularly raised during development. This means it will enter the user realm. We should provide an API page to show that this exception is public API. /cc @schneems | ||||
* | | | | Merge pull request #15058 from Gaurav2728/gaurav-doc_message | Richard Schneeman | 2014-05-11 | 1 | -3/+4 |
|\ \ \ \ | | | | | | | | | | | adding complete message in documentation [ci skip] | ||||
| * | | | | adding complete message in documentation [ci skip] | Gaurav Sharma | 2014-05-11 | 1 | -3/+4 |
|/ / / / | |||||
* | | | | Merge branch 'master' of github.com:rails/rails | Andrew White | 2014-05-11 | 1 | -0/+59 |
|\ \ \ \ |